demarches-normaliennes/app/views/champs/repetition/_show.html.haml

- champs = champ.rows.last
- if champs.present?
  - index = (champ.rows.size - 1) * champs.size
  - row_dom_id = "row-#{SecureRandom.hex(4)}"
  %div{ class: "row row-#{champs.first.row}", id: row_dom_id }
    -# Tell the controller which DOM element should be removed once the row deletion is successful
    = hidden_field_tag 'deleted_row_dom_ids[]', row_dom_id, disabled: true

    - champs.each.with_index(index) do |champ, index|
      = fields_for "#{attribute}[#{index}]", champ do |form|
        = render partial: "shared/dossiers/editable_champs/editable_champ", locals: { champ: champ, form: form }
        = form.hidden_field :id
        = form.hidden_field :_destroy, disabled: true
    .flex.row-reverse
      %button.button.danger.remove-row
        Supprimer l’élément
-												Champ Repetition dossier editor

											
										
										
											2019-01-30 16:14:15 +01:00
+								- champs = champ.rows.last
-												Do not crash with champ repetable with no children

											
										
										
											2019-11-05 16:54:43 +01:00
+								- if champs.present?
 								  - index = (champ.rows.size - 1) * champs.size
-												autosave: remove the repetition row after deletion

Before, when autosaving a draft, removing a repetition row would
send `_destroy` inputs to the controller – but not remove the row
from the DOM. This led to the `_destroy` inputs being sent again
on the next autosave request, which made the controller raise
(because the row fields were already deleted before).

To fix this, we let the controller response remove the deleted
row(s) from the DOM.

Doing it using a controller response avoids the need to keep track
of operations on the Javascript side: the controller can easily
know which row was just deleted, and emit the relevant changes for
the DOM. This keeps the autosave requests robust: even if a request
is skipped (e.g. because of a network interruption), the next request
will still contain the relevant informations to succeed, and not let the
form in an unstable state.

Fix #5470

											
										
										
											2020-08-20 15:56:41 +02:00
+								  - row_dom_id = "row-#{SecureRandom.hex(4)}"
 								  %div{ class: "row row-#{champs.first.row}", id: row_dom_id }
 								    -# Tell the controller which DOM element should be removed once the row deletion is successful
 								    = hidden_field_tag 'deleted_row_dom_ids[]', row_dom_id, disabled: true
-												Do not crash with champ repetable with no children

											
										
										
											2019-11-05 16:54:43 +01:00
+								    - champs.each.with_index(index) do |champ, index|
 								      = fields_for "#{attribute}[#{index}]", champ do |form|
 								        = render partial: "shared/dossiers/editable_champs/editable_champ", locals: { champ: champ, form: form }
 								        = form.hidden_field :id
 								        = form.hidden_field :_destroy, disabled: true
-												form: improve wording of repetition blocks controls

											
										
										
											2020-02-10 15:43:21 +01:00
+								    .flex.row-reverse
 								      %button.button.danger.remove-row
 								        Supprimer l’élément