DGNum/colmena
10
0
Fork 1
Code Issues 6 Pull requests 2 Projects Releases Packages Wiki Activity

fix(filter): in presence of filtering, do not attempt to load all node configurations #11

Closed
rlahfa wants to merge 1 commit from fix-filtering into main
pull from: fix-filtering
merge into: DGNum:main
Conversation 0 Commits 1 Files changed 1 +1 -7
1 changed files with 1 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/nix/hive/mod.rs
View file

@ -260,8 +260,6 @@ impl Hive {
ssh_config: Option<PathBuf>, ssh_config: Option<PathBuf>,
ssh_only: bool, ssh_only: bool,
) -> ColmenaResult<HashMap<NodeName, TargetNode>> { ) -> ColmenaResult<HashMap<NodeName, TargetNode>> {
let mut node_configs = None;
log::info!("Enumerating systems..."); log::info!("Enumerating systems...");
let registry = self.get_registry_config().await?; let registry = self.get_registry_config().await?;
@ -279,8 +277,6 @@ impl Hive {
.into_iter() .into_iter()
.collect(); .collect();
node_configs = Some(all_node_configs);
filtered filtered
} else { } else {
filter.filter_node_names(&all_nodes)?.into_iter().collect() filter.filter_node_names(&all_nodes)?.into_iter().collect()
@ -291,9 +287,7 @@ impl Hive {
let n_selected = selected_nodes.len(); let n_selected = selected_nodes.len();
let mut node_configs = if let Some(configs) = node_configs { let mut node_configs = {
configs
} else {
log::debug!("Retrieving deployment info for selected nodes..."); log::debug!("Retrieving deployment info for selected nodes...");
self.deployment_info_selected(&selected_nodes).await? self.deployment_info_selected(&selected_nodes).await?
}; };