From dfe5511ea28a2d2cab7e648840578ab06e55955b Mon Sep 17 00:00:00 2001 From: Raito Bezarius Date: Wed, 8 Jan 2025 22:35:21 +0100 Subject: [PATCH] fix(filter): in presence of filtering, do not attempt to load all node configurations I don't know why this was done this way but it's clearly wrong. Signed-off-by: Raito Bezarius --- src/nix/hive/mod.rs | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/src/nix/hive/mod.rs b/src/nix/hive/mod.rs index 7e35a03..448c4f9 100644 --- a/src/nix/hive/mod.rs +++ b/src/nix/hive/mod.rs @@ -260,8 +260,6 @@ impl Hive { ssh_config: Option, ssh_only: bool, ) -> ColmenaResult> { - let mut node_configs = None; - log::info!("Enumerating systems..."); let registry = self.get_registry_config().await?; @@ -279,8 +277,6 @@ impl Hive { .into_iter() .collect(); - node_configs = Some(all_node_configs); - filtered } else { filter.filter_node_names(&all_nodes)?.into_iter().collect() @@ -291,9 +287,7 @@ impl Hive { let n_selected = selected_nodes.len(); - let mut node_configs = if let Some(configs) = node_configs { - configs - } else { + let mut node_configs = { log::debug!("Retrieving deployment info for selected nodes..."); self.deployment_info_selected(&selected_nodes).await? }; -- 2.47.1