DGNum/authens
16
0
Fork 0
Code Issues 2 Pull requests Projects Releases 2 Packages Wiki Activity

Handle LOGOUT_URL=None in the logout view #56

Merged
mpepin merged 0 commits from kerl/issue20 into master 2021-10-03 17:50:10 +02:00
Conversation 8 Commits - Files changed -
mpepin commented 2021-10-02 17:11:03 +02:00 (Migrated from git.eleves.ens.fr)
Copy link

The view used to crash when LOGOUT_URL was not set and the user was
connect via CAS.

Cause: we assumed the result of LogoutView.get_next_page() to be a
string and tried to prepend the domain name of the site to it.

Fix: redirect to the CAS' logout view without any next_page parameter.

Fixes #20

The view used to crash when `LOGOUT_URL` was not set and the user was connect via CAS. Cause: we assumed the result of `LogoutView.get_next_page()` to be a string and tried to prepend the domain name of the site to it. Fix: redirect to the CAS' logout view without any `next_page` parameter. Fixes #20
mpepin commented 2021-10-02 17:11:33 +02:00 (Migrated from git.eleves.ens.fr)
Copy link

mentioned in issue #20

mentioned in issue #20
thubrecht commented 2021-10-02 18:12:12 +02:00 (Migrated from git.eleves.ens.fr)
Copy link

Je mettrai next_page is not None plitôt non ? Si jamais on veut passer "" comme prochaine url

Je mettrai `next_page is not None` plitôt non ? Si jamais on veut passer `""` comme prochaine url
mpepin commented 2021-10-03 17:35:03 +02:00 (Migrated from git.eleves.ens.fr)
Copy link

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](/klub-dev-ens/authens/-/merge_requests/34/diffs?diff_id=3327&start_sha=acea5a6f4e977d1350c21f0ce34509c8afde0c1e#7d5b71cacc811b1c4e38a976d7f8b40a0658a548_148_148)
mpepin commented 2021-10-03 17:35:04 +02:00 (Migrated from git.eleves.ens.fr)
Copy link

added 1 commit

  • 7809a3c6 - Apply Tomate's suggestion: not x → x is not None

Compare with previous version

added 1 commit <ul><li>7809a3c6 - Apply Tomate&#39;s suggestion: not x → x is not None</li></ul> [Compare with previous version](/klub-dev-ens/authens/-/merge_requests/34/diffs?diff_id=3327&start_sha=acea5a6f4e977d1350c21f0ce34509c8afde0c1e)
mpepin commented 2021-10-03 17:39:44 +02:00 (Migrated from git.eleves.ens.fr)
Copy link

Oui, très bon point 👍 j'ai corrigé

Oui, très bon point :thumbsup: j'ai corrigé
mpepin commented 2021-10-03 17:40:32 +02:00 (Migrated from git.eleves.ens.fr)
Copy link

Oui, très bon point 👍 j'ai corrigé

Oui, très bon point :thumbsup: j'ai corrigé
mpepin commented 2021-10-03 17:40:33 +02:00 (Migrated from git.eleves.ens.fr)
Copy link

resolved all threads

resolved all threads
thubrecht commented 2021-10-03 17:50:11 +02:00 (Migrated from git.eleves.ens.fr)
Copy link

mentioned in commit 22b4d440c3

mentioned in commit 22b4d440c3ddfafdcdf0617bebb4ab27c97efde6
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
documentation

   
Doing

   
Doing

   
Good first issue

   
To Do

   
To Do
  
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No labels
documentation
Doing
Doing
Good first issue
To Do
To Do
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: DGNum/authens#56
No description provided.
Delete branch "kerl/issue20"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?