DGNum/authens
17
0
Fork 0
Code Issues 2 Pull requests Projects Releases 2 Packages Wiki Activity

Quelques tests pour les vues de login #28

Merged
mpepin merged 0 commits from kerl/login_tests into master 2020-06-12 16:15:29 +02:00
Conversation 12 Commits - Files changed -
mpepin commented 2020-05-17 21:40:29 +02:00 (Migrated from git.eleves.ens.fr)
Copy link

Ça teste essentiellement que les vues sont accessibles et qu'elles redirigent au bon endroit.

Le gros des tests de login est dans test_backend.py

  • Merger !5 avant
Ça teste essentiellement que les vues sont accessibles et qu'elles redirigent au bon endroit. Le gros des tests de login est dans `test_backend.py` - [x] Merger !5 avant
mpepin commented 2020-05-17 21:40:29 +02:00 (Migrated from git.eleves.ens.fr)
Copy link

changed milestone to %1

changed milestone to %1
mpepin commented 2020-05-29 16:36:52 +02:00 (Migrated from git.eleves.ens.fr)
Copy link

added 11 commits

  • d126694d...f43036d6 - 4 commits from branch master
  • b8e165ac - Test the behaviour described in the README
  • bbd6a5bb - Black
  • 09ad5b66 - redirect CAS-users to CAS_URL/logout at logout
  • ead85189 - Test the logout view
  • 6a75f785 - Store the connexion method in a session variable
  • 34a7783c - Test the CAS login view
  • c8071173 - Test the login switch view

Compare with previous version

added 11 commits <ul><li>d126694d...f43036d6 - 4 commits from branch <code>master</code></li><li>b8e165ac - Test the behaviour described in the README</li><li>bbd6a5bb - Black</li><li>09ad5b66 - redirect CAS-users to CAS_URL/logout at logout</li><li>ead85189 - Test the logout view</li><li>6a75f785 - Store the connexion method in a session variable</li><li>34a7783c - Test the CAS login view</li><li>c8071173 - Test the login switch view</li></ul> [Compare with previous version](/klub-dev-ens/authens/merge_requests/6/diffs?diff_id=1673&start_sha=d126694da4cabbba28cb94a5cbffb435393aabae)
mpepin commented 2020-06-10 23:58:19 +02:00 (Migrated from git.eleves.ens.fr)
Copy link

added 4 commits

  • 8e95a016 - Redirect after a CAS logout
  • 352fedb8 - Logout next url can be local or absolute
  • b8e8c0f4 - Test the CAS login view
  • 6f471160 - Test the login switch view

Compare with previous version

added 4 commits <ul><li>8e95a016 - Redirect after a CAS logout</li><li>352fedb8 - Logout next url can be local or absolute</li><li>b8e8c0f4 - Test the CAS login view</li><li>6f471160 - Test the login switch view</li></ul> [Compare with previous version](/klub-dev-ens/authens/merge_requests/6/diffs?diff_id=1768&start_sha=c80711734e2131e24f688905fb05a8cddd7284f1)
lstephan commented 2020-06-11 00:50:28 +02:00 (Migrated from git.eleves.ens.fr)
Copy link

marked the checklist item Merger !5 avant as completed

marked the checklist item **Merger !5 avant** as completed
lstephan commented 2020-06-11 17:32:26 +02:00 (Migrated from git.eleves.ens.fr)
Copy link

Pourquoi lui donner des arguments ce coup ci ?

Pourquoi lui donner des arguments ce coup ci ?
mpepin commented 2020-06-12 11:52:53 +02:00 (Migrated from git.eleves.ens.fr)
Copy link

Hum, y'a pas vraiment de raison, j'ai pas trop fait gaffe.

Tu préfères quand il y a des arguments ou pas ? Je vais harmoniser les deux fichiers de test selon ce que tu me dis.

Hum, y'a pas vraiment de raison, j'ai pas trop fait gaffe. Tu préfères quand il y a des arguments ou pas ? Je vais harmoniser les deux fichiers de test selon ce que tu me dis.
lstephan commented 2020-06-12 11:58:49 +02:00 (Migrated from git.eleves.ens.fr)
Copy link

Je dirais sans arguments, en particulier ici ou ni l'un ni l'autre ne sont utiles =)

Je dirais sans arguments, en particulier ici ou ni l'un ni l'autre ne sont utiles =)
mpepin commented 2020-06-12 12:18:51 +02:00 (Migrated from git.eleves.ens.fr)
Copy link

changed this line in version 6 of the diff

changed this line in [version 6 of the diff](/klub-dev-ens/authens/merge_requests/6/diffs?diff_id=1771&start_sha=6f471160affb2e635c6cd4b7258545f8d7ba5fdc#d41c24b6c82eb10e72ab1d7f9cbe6f3be371434a_34_34)
mpepin commented 2020-06-12 12:18:52 +02:00 (Migrated from git.eleves.ens.fr)
Copy link

added 5 commits

  • 6f471160...6fdde55b - 2 commits from branch master
  • 68e43f48 - Test the CAS login view
  • 9f2e2a23 - Test the login switch view
  • d2d7622a - Tests: instantiate FakeCASClient with no argument

Compare with previous version

added 5 commits <ul><li>6f471160...6fdde55b - 2 commits from branch <code>master</code></li><li>68e43f48 - Test the CAS login view</li><li>9f2e2a23 - Test the login switch view</li><li>d2d7622a - Tests: instantiate FakeCASClient with no argument</li></ul> [Compare with previous version](/klub-dev-ens/authens/merge_requests/6/diffs?diff_id=1771&start_sha=6f471160affb2e635c6cd4b7258545f8d7ba5fdc)
mpepin commented 2020-06-12 12:18:55 +02:00 (Migrated from git.eleves.ens.fr)
Copy link

resolved all discussions

resolved all discussions
lstephan commented 2020-06-12 16:15:29 +02:00 (Migrated from git.eleves.ens.fr)
Copy link

merged

merged
lstephan commented 2020-06-12 16:15:29 +02:00 (Migrated from git.eleves.ens.fr)
Copy link

mentioned in commit 4e9e2f62e8

mentioned in commit 4e9e2f62e8c02b0e7d2f8f0678a866293be846dc
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
documentation

   
Doing

   
Doing

   
Good first issue

   
To Do

   
To Do
  
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No labels
documentation
Doing
Doing
Good first issue
To Do
To Do
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
v1
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: DGNum/authens#28
No description provided.
Delete branch "kerl/login_tests"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?