DGNum/authens
17
0
Fork 0
Code Issues 2 Pull requests Projects Releases 2 Packages Wiki Activity

Redirection vers cas.eleves.ens.fr/logout à la déconnexion. #27

Merged
mpepin merged 0 commits from kerl/cas_logout into master 2020-06-11 00:50:17 +02:00
Conversation 21 Commits - Files changed -
mpepin commented 2020-05-17 17:42:07 +02:00 (Migrated from git.eleves.ens.fr)
Copy link
  • Redirection vers le CAS seulement si on était connecté par CAS.
  • Écrire des tests
  • Merge !4 avant
  • J'aime pas trop le fait de stocker un booléen "connecté⋅e via CAS" en bdd → voir si je peux remplacer par une variable de session.

Fixes #8

- [x] Redirection vers le CAS seulement si on était connecté par CAS. - [x] Écrire des tests - [x] Merge !4 avant - [x] J'aime pas trop le fait de stocker un booléen "connecté⋅e via CAS" en bdd → voir si je peux remplacer par une variable de session. Fixes #8
mpepin commented 2020-05-17 17:42:08 +02:00 (Migrated from git.eleves.ens.fr)
Copy link

changed milestone to %1

changed milestone to %1
mpepin commented 2020-05-17 18:52:49 +02:00 (Migrated from git.eleves.ens.fr)
Copy link

added 1 commit

  • 8b4943f0 - Store the connexion method in a session variable

Compare with previous version

added 1 commit <ul><li>8b4943f0 - Store the connexion method in a session variable</li></ul> [Compare with previous version](/klub-dev-ens/authens/merge_requests/5/diffs?diff_id=1645&start_sha=8bfd9f22a6d431c787767fbc4041e4039db3e239)
mpepin commented 2020-05-17 18:53:10 +02:00 (Migrated from git.eleves.ens.fr)
Copy link

marked the checklist item J'aime pas trop le fait de stocker un booléen "connecté⋅e via CAS" en bdd → voir si je peux remplacer par une variable de session. as completed

marked the checklist item **J'aime pas trop le fait de stocker un booléen "connecté⋅e via CAS" en bdd → voir si je peux remplacer par une variable de session.** as completed
mpepin commented 2020-05-17 21:40:31 +02:00 (Migrated from git.eleves.ens.fr)
Copy link

mentioned in merge request !6

mentioned in merge request !6
mpepin commented 2020-05-29 16:30:09 +02:00 (Migrated from git.eleves.ens.fr)
Copy link

added 9 commits

  • 8b4943f0...f43036d6 - 4 commits from branch master
  • b8e165ac - Test the behaviour described in the README
  • bbd6a5bb - Black
  • 09ad5b66 - redirect CAS-users to CAS_URL/logout at logout
  • ead85189 - Test the logout view
  • 6a75f785 - Store the connexion method in a session variable

Compare with previous version

added 9 commits <ul><li>8b4943f0...f43036d6 - 4 commits from branch <code>master</code></li><li>b8e165ac - Test the behaviour described in the README</li><li>bbd6a5bb - Black</li><li>09ad5b66 - redirect CAS-users to CAS_URL/logout at logout</li><li>ead85189 - Test the logout view</li><li>6a75f785 - Store the connexion method in a session variable</li></ul> [Compare with previous version](/klub-dev-ens/authens/merge_requests/5/diffs?diff_id=1672&start_sha=8b4943f0854c1d893b5b6e3e0bfa1b04ebfd47d8)
lstephan commented 2020-06-09 17:49:10 +02:00 (Migrated from git.eleves.ens.fr)
Copy link

marked the checklist item Merge !4 avant as completed

marked the checklist item **Merge !4 avant** as completed
lstephan commented 2020-06-09 17:54:40 +02:00 (Migrated from git.eleves.ens.fr)
Copy link

unmarked as a Work In Progress

unmarked as a **Work In Progress**
lstephan commented 2020-06-09 17:58:57 +02:00 (Migrated from git.eleves.ens.fr)
Copy link

On ne permet pas de rediriger après logout CAS ?

On ne permet pas de rediriger après logout CAS ?
mpepin commented 2020-06-09 19:54:07 +02:00 (Migrated from git.eleves.ens.fr)
Copy link

Je n'y avais pas pensé mais si, c'est une bonne idée

Je n'y avais pas pensé mais si, c'est une bonne idée
mpepin commented 2020-06-10 22:23:31 +02:00 (Migrated from git.eleves.ens.fr)
Copy link

changed this line in version 5 of the diff

changed this line in [version 5 of the diff](/klub-dev-ens/authens/merge_requests/5/diffs?diff_id=1762&start_sha=6a75f78541fdd5028d076e7d3edd45d17148a44a#7d5b71cacc811b1c4e38a976d7f8b40a0658a548_98_99)
mpepin commented 2020-06-10 22:23:34 +02:00 (Migrated from git.eleves.ens.fr)
Copy link

added 1 commit

  • 6baac601 - Redirect after a CAS logout

Compare with previous version

added 1 commit <ul><li>6baac601 - Redirect after a CAS logout</li></ul> [Compare with previous version](/klub-dev-ens/authens/merge_requests/5/diffs?diff_id=1762&start_sha=6a75f78541fdd5028d076e7d3edd45d17148a44a)
mpepin commented 2020-06-10 22:23:51 +02:00 (Migrated from git.eleves.ens.fr)
Copy link

resolved all discussions

resolved all discussions
mpepin commented 2020-06-10 22:35:35 +02:00 (Migrated from git.eleves.ens.fr)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>8e95a016 - Redirect after a CAS logout</li></ul> [Compare with previous version](/klub-dev-ens/authens/merge_requests/5/diffs?diff_id=1763&start_sha=6baac6013b1d7f96f88981e6ed97fbf934d17091)
lstephan commented 2020-06-10 22:39:45 +02:00 (Migrated from git.eleves.ens.fr)
Copy link

si j'appelle /logout?next=https://www.google.fr ça merde ça non ?

si j'appelle `/logout?next=https://www.google.fr` ça merde ça non ?
mpepin commented 2020-06-10 23:03:06 +02:00 (Migrated from git.eleves.ens.fr)
Copy link

Hum, peut-être que je ne devrais pas forcer le nom de domaine effectivement. Je teste et je te dis

Hum, peut-être que je ne devrais pas forcer le nom de domaine effectivement. Je teste et je te dis
mpepin commented 2020-06-10 23:24:35 +02:00 (Migrated from git.eleves.ens.fr)
Copy link

changed this line in version 7 of the diff

changed this line in [version 7 of the diff](/klub-dev-ens/authens/merge_requests/5/diffs?diff_id=1766&start_sha=8e95a0164722c625843fd5a7c1dea3e9477f1679#7d5b71cacc811b1c4e38a976d7f8b40a0658a548_101_101)
mpepin commented 2020-06-10 23:24:35 +02:00 (Migrated from git.eleves.ens.fr)
Copy link

added 1 commit

  • 352fedb8 - Logout next url can be local or absolute

Compare with previous version

added 1 commit <ul><li>352fedb8 - Logout next url can be local or absolute</li></ul> [Compare with previous version](/klub-dev-ens/authens/merge_requests/5/diffs?diff_id=1766&start_sha=8e95a0164722c625843fd5a7c1dea3e9477f1679)
mpepin commented 2020-06-10 23:26:10 +02:00 (Migrated from git.eleves.ens.fr)
Copy link

Ok, maintenant ça devrait le faire.

Il faut donner une URL absolue quoi qu'il arrive puisqu'on sera redirigé depuis le CAS et non depuis notre site Django. Du coup je préfixe par request.get_host() uniquement si next_page est une url locale.

Ok, maintenant ça devrait le faire. Il faut donner une URL absolue quoi qu'il arrive puisqu'on sera redirigé depuis le CAS et non depuis notre site Django. Du coup je préfixe par `request.get_host()` uniquement si `next_page` est une url locale.
mpepin commented 2020-06-10 23:54:45 +02:00 (Migrated from git.eleves.ens.fr)
Copy link

resolved all discussions

resolved all discussions
lstephan commented 2020-06-11 00:50:17 +02:00 (Migrated from git.eleves.ens.fr)
Copy link

mentioned in commit 6fdde55b0f

mentioned in commit 6fdde55b0ffaa070921bd2165d0e340b388bd543
lstephan commented 2020-06-11 00:50:17 +02:00 (Migrated from git.eleves.ens.fr)
Copy link

merged

merged
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
documentation

   
Doing

   
Doing

   
Good first issue

   
To Do

   
To Do
  
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No labels
documentation
Doing
Doing
Good first issue
To Do
To Do
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
v1
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: DGNum/authens#27
No description provided.
Delete branch "kerl/cas_logout"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?