dfe137786c
Make constructing of a new Evaluation use the builder pattern rather than setting public mutable fields. This is currently a pure refactor (no functionality has changed) but has a few advantages: - We've encapsulated the internals of the fields in Evaluation, meaning we can change them without too much breakage of clients - We have type safety that prevents us from ever changing the fields of an Evaluation after it's built (which matters more in a world where we reuse Evaluations). More importantly, this paves the road for doing different things with the construction of an Evaluation - notably, sharing certain things like the GlobalsMap across subsequent evaluations in eg the REPL. Fixes: b/262 Change-Id: I4a27116faac14cdd144fc7c992d14ae095a1aca4 Reviewed-on: https://cl.tvl.fyi/c/depot/+/11956 Tested-by: BuildkiteCI Autosubmit: aspen <root@gws.fyi> Reviewed-by: flokli <flokli@flokli.de>
44 lines
1.1 KiB
Rust
44 lines
1.1 KiB
Rust
use criterion::{black_box, criterion_group, criterion_main, Criterion};
|
|
use itertools::Itertools;
|
|
#[cfg(not(target_env = "msvc"))]
|
|
use tikv_jemallocator::Jemalloc;
|
|
|
|
#[cfg(not(target_env = "msvc"))]
|
|
#[global_allocator]
|
|
static GLOBAL: Jemalloc = Jemalloc;
|
|
|
|
fn interpret(code: &str) {
|
|
tvix_eval::Evaluation::builder_pure()
|
|
.build()
|
|
.evaluate(code, None);
|
|
}
|
|
|
|
fn eval_literals(c: &mut Criterion) {
|
|
c.bench_function("int", |b| {
|
|
b.iter(|| {
|
|
interpret(black_box("42"));
|
|
})
|
|
});
|
|
}
|
|
|
|
fn eval_merge_attrs(c: &mut Criterion) {
|
|
c.bench_function("merge small attrs", |b| {
|
|
b.iter(|| {
|
|
interpret(black_box("{ a = 1; b = 2; } // { c = 3; }"));
|
|
})
|
|
});
|
|
|
|
c.bench_function("merge large attrs with small attrs", |b| {
|
|
let large_attrs = format!(
|
|
"{{{}}}",
|
|
(0..10000).map(|n| format!("a{n} = {n};")).join(" ")
|
|
);
|
|
let expr = format!("{large_attrs} // {{ c = 3; }}");
|
|
b.iter(move || {
|
|
interpret(black_box(&expr));
|
|
})
|
|
});
|
|
}
|
|
|
|
criterion_group!(benches, eval_literals, eval_merge_attrs);
|
|
criterion_main!(benches);
|