mdebray/tvl-depot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
tvl-depot/views
History
Florian Klink e9686f84d9 fix(views/kit): communicate :unsign in the tvl-kit URL directly 
Instead of prepending :unsign to all URLs in josh-proxy, and for all
calls to filteredGitPush, explicitly use it only in the filter we use
for the `export-kit` extraStep.

This means, people cloning tvl-kit via

> https://code.tvl.fyi/depot.git:workspace=views/kit.git

now need to update the URL to point to

> https://code.tvl.fyi/depot.git:unsign:workspace=views/kit.git

instead.

git@github.com:tvlfyi/kit.git will keep the same hashes, as it's updated
to export the unsigned workspace view of it.

This is less invasive than dooming every josh workspace to have to strip
signatures.

Change-Id: I6de05182fad4c3695081388c3bbf37306521d255
Reviewed-on: https://cl.tvl.fyi/c/depot/+/8369
Autosubmit: flokli <flokli@flokli.de>
Reviewed-by: tazjin <tazjin@tvl.su>
Tested-by: BuildkiteCI
2023-03-31 08:46:01 +00:00
..
kit fix(views/kit): communicate :unsign in the tvl-kit URL directly 2023-03-31 08:46:01 +00:00
tvix chore(3p/sources): Bump channels & overlays 2023-03-02 14:35:49 +00:00
.skip-subtree feat(kit): Export TVL kit as a josh workspace 2022-01-19 10:24:55 +00:00
default.nix fix(views/kit): communicate :unsign in the tvl-kit URL directly 2023-03-31 08:46:01 +00:00
README.md fix(views/kit): communicate :unsign in the tvl-kit URL directly 2023-03-31 08:46:01 +00:00

README.md

depot views

This folder contains external views of depot content, defined using josh workspaces. See the individual views for a description of their individual content and usage information.

Testing changes locally

Generally, when iterating on these files, it's best to locally invoke josh- filter (from //third_party//josh) locally to inspect how the workspace would look like:

  • Commit your changes. This is required, as josh-filter operates on your HEAD, not working directory state.
  • Invoke josh-filter with the filter expression, for example josh-filter ':workspace=views/tvix'.
  • Peek at the synthesized git history by looking at FILTERED_HEAD.

Testing changes in Gerrit

It's also possible to clone resulting workspaces for CLs that were already pushed to Gerrit, but didn't land in master yet.

For CL1234 at revision 2, the URL passed to git clone would look like this:

https://code.tvl.fyi/depot.git@refs/changes/32/1234/2:workspace=views/kit.git