6a116d5057
The store path is already contained in the PathInfo, and the ca bits is already passed into the function, so known to the caller - there's no need to duplicate this. We can also avoid having two separate block_on in our import builtin - we already know the content hash before constructing, as we pass it in via ca_hash. There's still some room to unclutter some more of the code around importing - we still do NAR calculation twice in some cases, and some of the code might be share-able from other places producing PathInfo too. Log a TODO for this cleanup. Change-Id: I6a5fc427d15bc9293a396310143c7694dd2996c0 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12592 Reviewed-by: Marijan Petričević <marijan.petricevic94@gmail.com> Reviewed-by: flokli <flokli@flokli.de> Tested-by: BuildkiteCI |
||
---|---|---|
.. | ||
build | ||
castore | ||
contributing | ||
eval | ||
figures | ||
nix-daemon | ||
store | ||
architecture.md | ||
community.md | ||
getting-started.md | ||
introduction.md | ||
lang-version.md | ||
language-spec.md | ||
SUMMARY.md | ||
TODO.md | ||
value-pointer-equality.md |