mdebray/tvl-depot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
tvl-depot/tvix/eval/src
History
Adam Joseph ae28dc3ca6 test(tvix/eval): test for b/338 catchable hygiene problem 
Commit 05f42519b5 fixed b/281 by
establishing a hygiene regimen to partition *catchable* errors
(i.e. those which tryEval can detect) from all other errors, like
internal VM failures or I/O errors (which Nix must not be allowed to
detect, since these errors are fundamentally impure).

Unfotunately there are still cases where tvix assumes that anything
other than Value::Bool means it should panic!().  I found another
one, and added a test case for it in:

  eval_okay_src_tests_tvix_tests_eval_okay_compare_ordering_catchable_nix

Not yet passing.

Change-Id: I69c62ed9ea5c8f81870e8de5c5fe12dcde849763
Reviewed-on: https://cl.tvl.fyi/c/depot/+/10220
Autosubmit: Adam Joseph <adam@westernsemico.com>
Reviewed-by: tazjin <tazjin@tvl.su>
Tested-by: BuildkiteCI
2023-12-12 14:26:46 +00:00
..
builtins feat(tvix/eval): nonrecursive nix_cmp_ordering(), fixes b/339 2023-12-12 14:26:46 +00:00
compiler chore(tvix): fix trivial clippy lints 2023-11-05 20:28:37 +00:00
tests test(tvix/eval): test for b/338 catchable hygiene problem 2023-12-12 14:26:46 +00:00
value feat(tvix/eval): nonrecursive nix_cmp_ordering(), fixes b/339 2023-12-12 14:26:46 +00:00
vm feat(tvix/eval): nonrecursive nix_cmp_ordering(), fixes b/339 2023-12-12 14:26:46 +00:00
chunk.rs docs(tvix/eval): fix some broken docstr references 2023-09-22 09:14:33 +00:00
errors.rs fix(tvix/eval): fix b/281 by adding Value::Catchable 2023-09-24 21:54:10 +00:00
io.rs docs(tvix/eval): document where EvalIO methods are used 2023-11-06 09:06:26 +00:00
lib.rs chore(tvix): add missing clippy attributes & config 2023-11-05 20:28:38 +00:00
nix_search_path.rs fix(tvix/eval): fix b/281 by adding Value::Catchable 2023-09-24 21:54:10 +00:00
observer.rs refactor(tvix/eval/observer): cargo clippy 2023-08-20 21:51:04 +00:00
opcode.rs docs(tvix/eval): document remaining opcodes 2023-09-08 21:38:42 +00:00
pretty_ast.rs fix(tvix/eval): fix current clippy warnings 2022-12-25 18:25:06 +00:00
properties.rs refactor(tvix/eval): Don't (ab)use PartialEq for Nix equality 2022-09-18 22:03:41 +00:00
source.rs refactor(tvix/eval): impl Default for SourceCode 2023-08-20 21:52:21 +00:00
spans.rs refactor(tvix/eval): implement From<Span> for LightSpan 2023-03-04 15:18:37 +00:00
systems.rs fix(tvix/eval): fix current clippy warnings 2022-12-25 18:25:06 +00:00
test_utils.rs test(tvix/eval): Add proof-of-concept test for Chunk 2022-09-18 17:55:06 +00:00
upvalues.rs fix(tvix/eval): remove impl PartialEq for Value 2022-11-04 00:30:13 +00:00
warnings.rs fix(tvix/eval): emit only warnings on shadowed outputs 2023-06-11 20:59:34 +00:00