tvl-depot/tvix
Florian Klink 21e5fc024d fix(tvix/castore/import): check small blobs first
ConcurrentBlobUploader buffers small blobs in memory, and then uploads
them to the BlobService in the background.

In these cases, we know the hash of the whole blob, so we could check if
it exists first before, uploading it.

We were however not, and this caused rate limiting issues in GCS, as it
has an update limit of one write per second on the same key, which we
ran into especially frequently with the empty blob.

This reduces the amount of writes of the same blob considerably.

In the future, we might be able to drop this, as our chunked blob
uploading protocol gets smarter and covers these cases.

Change-Id: Icf482df815812f80a0b65cec0426f8e686308abb
Reviewed-on: https://cl.tvl.fyi/c/depot/+/12497
Tested-by: BuildkiteCI
Autosubmit: flokli <flokli@flokli.de>
Reviewed-by: Connor Brewster <cbrewster@hey.com>
2024-09-19 12:51:09 +00:00
..
.vscode chore(tvix): fix vscode rust-analyzer recommendation 2022-10-15 16:54:28 +00:00
boot feat(tvix/boot/tests): use pkgs.nixos instead of nixosFor 2024-08-19 16:55:22 +00:00
build chore(tvix): Migrate members to inherit deps from workspace 2024-08-29 14:37:22 +00:00
build-go docs(tvix/build/protos): clarify content-addressing 2024-08-16 16:03:08 +00:00
castore fix(tvix/castore/import): check small blobs first 2024-09-19 12:51:09 +00:00
castore-go chore(3p/sources): Bump channels & overlays (2024-07-28) 2024-08-01 10:06:33 +00:00
cli chore(tvix): Migrate members to inherit deps from workspace 2024-08-29 14:37:22 +00:00
docs docs(tvix/contributing): remove reference to b/201 2024-09-03 15:17:30 +00:00
eval chore(3p/sources): bump channels & overlays (2024-09-01) 2024-09-05 20:56:31 +00:00
glue chore(3p/sources): bump channels & overlays (2024-09-01) 2024-09-05 20:56:31 +00:00
nar-bridge chore(tvix): Migrate members to inherit deps from workspace 2024-08-29 14:37:22 +00:00
nix-compat docs(tvix/nix-compat/wire/bytes/reader): None case doesn't exist 2024-09-08 02:32:57 +00:00
nix-compat-derive chore(tvix): Migrate members to inherit deps from workspace 2024-08-29 14:37:22 +00:00
nix-compat-derive-tests chore(tvix): Migrate members to inherit deps from workspace 2024-08-29 14:37:22 +00:00
nix-lang-test-suite docs(tvix): initial notes on a possible generic Nix lang test suite 2024-01-22 14:21:19 +00:00
scripts chore(tvix): Run criterion benchmarks for the whole workspace 2023-12-20 18:04:43 +00:00
serde chore(tvix): Migrate members to inherit deps from workspace 2024-08-29 14:37:22 +00:00
store chore(tvix): Migrate members to inherit deps from workspace 2024-08-29 14:37:22 +00:00
store-go chore(3p/sources): Bump channels & overlays (2024-07-28) 2024-08-01 10:06:33 +00:00
tools feat(nix-compat): Add NixDeserialize and NixRead traits 2024-08-25 15:05:50 +00:00
tracing chore(tvix): Migrate members to inherit deps from workspace 2024-08-29 14:37:22 +00:00
verify-lang-tests chore(tvix/verify-lang-tests): update latest Nix version 2024-08-14 15:01:03 +00:00
website chore(tvix/nar-bridge): move to nar-bridge-go 2024-05-15 21:31:36 +00:00
.gitignore chore(tvix): add /*.sled to .gitignore 2023-09-24 17:05:48 +00:00
buildkite.yml feat(tvix/buildkite): apply a 10 minutes timeout 2024-04-13 11:44:37 +00:00
Cargo.lock chore(tvix): Migrate members to inherit deps from workspace 2024-08-29 14:37:22 +00:00
Cargo.nix fix(tvix): Follow-up fixing no-default-features and comments 2024-08-30 13:55:11 +00:00
Cargo.toml fix(tvix): Follow-up fixing no-default-features and comments 2024-08-30 13:55:11 +00:00
clippy.toml refactor(tvix/castore): add PathComponent type for checked components 2024-08-17 15:59:10 +00:00
crate-hashes.json chore(tvix/[ca]store): bump bigtable_rs 2024-08-28 20:15:55 +00:00
default.nix chore(tvix/[ca]store): bump bigtable_rs 2024-08-28 20:15:55 +00:00
LICENSE chore(tvix): Bootstrap Tvix folder 2021-03-27 00:09:49 +00:00
logo.webp refactor(tvix): move logo to //tvix:logo 2023-09-10 13:13:14 +00:00
OWNERS chore(depot): update OWNERS files for aspen 2023-12-20 18:35:58 +00:00
README.md chore(tvix): drop nar-bridge-go 2024-07-30 14:36:31 +00:00
shell.nix chore(3p/sources): bump channels & overlays (2024-09-01) 2024-09-05 20:56:31 +00:00
utils.nix fix(tvix/utils): Add missing src filtering for nix-compat-derive[-tests] 2024-08-30 12:09:41 +00:00


Tvix is a new implementation of the Nix language and package manager. See the announcement post for information about the background of this project.

Tvix is developed by TVL in our monorepo, the depot, at //tvix. Code reviews take place on Gerrit, bugs are filed in our issue tracker.

For more information about Tvix, feel free to reach out. We are interested in people who would like to help us review designs, brainstorm and describe requirements that we may not yet have considered.

Most of the discussion around development happens in our dedicated IRC channel, #tvix-dev on hackint, which is also reachable via XMPP at #tvix-dev@irc.hackint.org (sic!) and via Matrix at #tvix-dev:hackint.org.

There's also the IRC channel of the wider TVL community, less on-topic, or our mailing list.

Contributions to Tvix follow the TVL review flow and contribution guidelines.

WARNING: Tvix is not ready for use in production. None of our current APIs should be considered stable in any way.

WARNING: Any other instances of this project or repository are josh-mirrors. We do not accept code contributions or issues outside of the tooling and communication methods outlined above.

Components

This folder contains the following components:

  • //tvix/castore - subtree storage/transfer in a content-addressed fashion
  • //tvix/cli - preliminary REPL & CLI implementation for Tvix
  • //tvix/eval - an implementation of the Nix programming language
  • //tvix/nar-bridge - a HTTP webserver providing a Nix HTTP Binary Cache interface in front of a tvix-store
  • //tvix/nix-compat - a Rust library for compatibility with C++ Nix, features like encodings and hashing schemes and formats
  • //tvix/serde - a Rust library for using the Nix language for app configuration
  • //tvix/store - a "filesystem" linking Nix store paths and metadata with the content-addressed layer

Some additional folders with auxiliary things exist and can be explored at your leisure.

Building the CLI

The CLI can also be built with standard Rust tooling (i.e. cargo build), as long as you are in a shell with the right dependencies.

  • If you cloned the full monorepo, it can be provided by mg shell //tvix:shell.
  • If you cloned the tvix workspace only (git clone https://code.tvl.fyi/depot.git:workspace=views/tvix.git), nix-shell provides it.

If you're in the TVL monorepo, you can also run mg build //tvix/cli (or mg build from inside that folder) for a more incremental build.

Please follow the depot-wide instructions on how to get mg and use the depot tooling.

Compatibility

Important note: We only use and test Nix builds of our software against Nix 2.3. There are a variety of bugs and subtle problems in newer Nix versions which we do not have the bandwidth to address, builds in newer Nix versions may or may not work.

Rust projects, crate2nix

Some parts of Tvix are written in Rust. To simplify the dependency management on the Nix side of these builds, we use crate2nix in a single Rust workspace in //tvix to maintain the Nix build configuration.

When making changes to Cargo dependency configuration in any of the Rust projects under //tvix, be sure to run mg run //tools:crate2nix-generate in //tvix itself and commit the changes to the generated Cargo.nix file. This only applies to the full TVL checkout.

When adding/removing a Cargo feature for a crate, you will want to add it to the features power set that gets tested in CI. For each crate there's a default.nix with a mkFeaturePowerset invocation, modify the list to include/remove the feature. Note that you don't want to add "collection" features, such as fs for tvix-[ca]store or default.

License structure

All code implemented for Tvix is licensed under the GPL-3.0, with the exception of the protocol buffer definitions used for communication between services which are available under a more permissive license (MIT).

The idea behind this structure is that any direct usage of our code (e.g. linking to it, embedding the evaluator, etc.) will fall under the terms of the GPL3, but users are free to implement their own components speaking these protocols under the terms of the MIT license.