tvl-depot/tvix/castore/src
sinavir 0f92400112 fix(tvix/nar-bridge): Remove name check for root node in nar generation
Nar-bridge tried to parse the name of the protobuf node encoded in the
URL into a PathComponent but this name was empty, leading to an error
when the user tried to retrieve the nar file.

This was an oversight from the conversion to stricter types (some of the
CLs in the serious containing cl/12217).

We need a version converting a protobuf without a name to our stricter
types, but an empty PathComponent cannot be constructed.

So we need a into_name_and_node() version that returns the name as
Bytes, not PathComponent.

Change-Id: I2996cdd2e0107133e502748947298f512f1cc521
Reviewed-on: https://cl.tvl.fyi/c/depot/+/12504
Reviewed-by: flokli <flokli@flokli.de>
Tested-by: BuildkiteCI
2024-09-24 09:45:33 +00:00
..
blobservice refactor(directoryservice): get rid of NaiveSeeker helper 2024-07-23 20:53:08 +00:00
directoryservice feat(tvix/castore): expose ValidatedDirectoryGraph type 2024-09-07 12:22:58 +00:00
fs refactor(tvix/castore): add into_nodes(), implement consuming proto conv 2024-08-17 15:59:10 +00:00
import fix(tvix/castore/import): check small blobs first 2024-09-19 12:51:09 +00:00
nodes refactor(tvix/castore): have SymlinkTarget-specific errors 2024-08-18 17:22:21 +00:00
path refactor(tvix/castore): have PathComponent-specific errors 2024-08-18 17:22:21 +00:00
proto fix(tvix/nar-bridge): Remove name check for root node in nar generation 2024-09-24 09:45:33 +00:00
tests refactor(tvix/castore): drop {Directory,File,Symlink}Node 2024-08-17 09:46:01 +00:00
composition.rs feat(tvix/composition): improve error message for unknown tag 2024-07-22 13:36:08 +00:00
digests.rs refactor(tvix/castore): use Directory struct separate from proto one 2024-08-13 12:17:01 +00:00
errors.rs fix(tvix/nar-bridge): Remove name check for root node in nar generation 2024-09-24 09:45:33 +00:00
fixtures.rs feat(tvix/castore): add Directory::try_from_iter() 2024-08-18 16:49:58 +00:00
hashing_reader.rs refactor(tvix/castore/hashing_reader): migrate to rstest 2024-04-07 14:51:47 +00:00
lib.rs refactor(tvix/castore): have PathComponent-specific errors 2024-08-18 17:22:21 +00:00
tonic.rs chore(tvix): upgrade to tonic 0.12 / hyper 1.0 2024-07-21 11:01:38 +00:00