tvl-depot/tvix/castore/src
Ben Webb 565c0fd24c fix(tvix/castore): u32 -> u64 in DirectoryError::SizeOverflow message
Fix a discrepancy in the error message for DirectoryError::SizeOverflow.

The message indicates that the SizeOverflow error occurs when total size
exceeds u32::MAX, but that's not true. All size fields within the
castore's internal Directory ADT are u64, and the SizeOverflow error is
only returned after a call to the checked_add implementation on u64.

See tvix/castore/nodes/directory.rs +111
and tvix/castore/nodes/directory.rs +88
as of this commit.

Change-Id: I74d161ea8927362e1cb601ba163489aa96fb91b1
Reviewed-on: https://cl.tvl.fyi/c/depot/+/12259
Tested-by: BuildkiteCI
Reviewed-by: flokli <flokli@flokli.de>
2024-08-21 22:05:57 +00:00
..
blobservice refactor(directoryservice): get rid of NaiveSeeker helper 2024-07-23 20:53:08 +00:00
directoryservice feat(tvix/castore): add Directory::try_from_iter() 2024-08-18 16:49:58 +00:00
fs refactor(tvix/castore): add into_nodes(), implement consuming proto conv 2024-08-17 15:59:10 +00:00
import refactor(tvix/castore): have SymlinkTarget-specific errors 2024-08-18 17:22:21 +00:00
nodes refactor(tvix/castore): have SymlinkTarget-specific errors 2024-08-18 17:22:21 +00:00
path refactor(tvix/castore): have PathComponent-specific errors 2024-08-18 17:22:21 +00:00
proto refactor(tvix/castore): have SymlinkTarget-specific errors 2024-08-18 17:22:21 +00:00
tests refactor(tvix/castore): drop {Directory,File,Symlink}Node 2024-08-17 09:46:01 +00:00
composition.rs feat(tvix/composition): improve error message for unknown tag 2024-07-22 13:36:08 +00:00
digests.rs refactor(tvix/castore): use Directory struct separate from proto one 2024-08-13 12:17:01 +00:00
errors.rs fix(tvix/castore): u32 -> u64 in DirectoryError::SizeOverflow message 2024-08-21 22:05:57 +00:00
fixtures.rs feat(tvix/castore): add Directory::try_from_iter() 2024-08-18 16:49:58 +00:00
hashing_reader.rs refactor(tvix/castore/hashing_reader): migrate to rstest 2024-04-07 14:51:47 +00:00
lib.rs refactor(tvix/castore): have PathComponent-specific errors 2024-08-18 17:22:21 +00:00
tonic.rs chore(tvix): upgrade to tonic 0.12 / hyper 1.0 2024-07-21 11:01:38 +00:00