tvl-depot/tvix/cli
Aspen Smith 8821746d6c fix(tvix/repl): Share globals and sourcemap across evaluations
Now that we can bind (potentially lazy, potentially lambda-containing)
values in the REPL and then reference them in subsequent evaluations,
it's important that the values to which we construct shared references
are shared across those subsequent evaluations - otherwise, we get
panics due to unknown source map locations, or dropped weak references
to globals.

This change assigns both the globals and the source map as fields on the
Repl after the first evaluation, and then passes those in (to the
EvaluationBuilder) on subsequent evaluations.

On the EvaluationBuilder side, there's some panicking introduced - this
is intentional, as my intent is for the builder to be configured
statically enough that panicking is the best way to report errors
here (it's always a bug to misconfigure an Evaluation, and we'd never
want to handle it dynamically).

Change-Id: I37225697235c22b683ca48a17d30fa8fedd12d1b
Reviewed-on: https://cl.tvl.fyi/c/depot/+/11960
Reviewed-by: flokli <flokli@flokli.de>
Autosubmit: aspen <root@gws.fyi>
Tested-by: BuildkiteCI
2024-07-07 15:04:26 +00:00
..
src fix(tvix/repl): Share globals and sourcemap across evaluations 2024-07-07 15:04:26 +00:00
tests fix(tvix/repl): Share globals and sourcemap across evaluations 2024-07-07 15:04:26 +00:00
Cargo.toml test(tvix/cli): Make the REPL testable 2024-07-07 14:19:17 +00:00
default.nix test(tvix/cli): Make the REPL testable 2024-07-07 14:19:17 +00:00