12bc53e031
-- c99f979ad34f155fbeeea69b88bdc7458d89a21c by Derek Mauro <dmauro@google.com>: Remove a floating point division by zero test. This isn't testing behavior related to the library, and MSVC warns about it in opt mode. PiperOrigin-RevId: 285220804 -- 68b015491f0dbf1ab547994673281abd1f34cd4b by Gennadiy Rozental <rogeeff@google.com>: This CL introduces following changes to the class FlagImpl: * We eliminate the CommandLineFlagLocks struct. Instead callback guard and callback function are combined into a single CallbackData struct, while primary data lock is stored separately. * CallbackData member of class FlagImpl is initially set to be nullptr and is only allocated and initialized when a flag's callback is being set. For most flags we do not pay for the extra space and extra absl::Mutex now. * Primary data guard is stored in data_guard_ data member. This is a properly aligned character buffer of necessary size. During initialization of the flag we construct absl::Mutex in this space using placement new call. * We now avoid extra value copy after successful attempt to parse value out of string. Instead we swap flag's current value with tentative value we just produced. PiperOrigin-RevId: 285132636 -- ed45d118fb818969eb13094cf7827c885dfc562c by Tom Manshreck <shreck@google.com>: Change null-term* (and nul-term*) to NUL-term* in comments PiperOrigin-RevId: 285036610 -- 729619017944db895ce8d6d29c1995aa2e5628a5 by Derek Mauro <dmauro@google.com>: Use the Posix implementation of thread identity on MinGW. Some versions of MinGW suffer from thread_local bugs. PiperOrigin-RevId: 285022920 -- 39a25493503c76885bc3254c28f66a251c5b5bb0 by Greg Falcon <gfalcon@google.com>: Implementation detail change. Add further ABSL_NAMESPACE_BEGIN and _END annotation macros to files in Abseil. PiperOrigin-RevId: 285012012 GitOrigin-RevId: c99f979ad34f155fbeeea69b88bdc7458d89a21c Change-Id: I4c85d3704e45d11a9ac50d562f39640a6adbedc1
401 lines
12 KiB
C++
401 lines
12 KiB
C++
//
|
|
// Copyright 2019 The Abseil Authors.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// https://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
#include "absl/flags/internal/flag.h"
|
|
|
|
#include "absl/base/optimization.h"
|
|
#include "absl/synchronization/mutex.h"
|
|
|
|
namespace absl {
|
|
ABSL_NAMESPACE_BEGIN
|
|
namespace flags_internal {
|
|
namespace {
|
|
|
|
// Currently we only validate flag values for user-defined flag types.
|
|
bool ShouldValidateFlagValue(const CommandLineFlag& flag) {
|
|
#define DONT_VALIDATE(T) \
|
|
if (flag.IsOfType<T>()) return false;
|
|
ABSL_FLAGS_INTERNAL_FOR_EACH_LOCK_FREE(DONT_VALIDATE)
|
|
DONT_VALIDATE(std::string)
|
|
DONT_VALIDATE(std::vector<std::string>)
|
|
#undef DONT_VALIDATE
|
|
|
|
return true;
|
|
}
|
|
|
|
// RAII helper used to temporarily unlock and relock `absl::Mutex`.
|
|
// This is used when we need to ensure that locks are released while
|
|
// invoking user supplied callbacks and then reacquired, since callbacks may
|
|
// need to acquire these locks themselves.
|
|
class MutexRelock {
|
|
public:
|
|
explicit MutexRelock(absl::Mutex* mu) : mu_(mu) { mu_->Unlock(); }
|
|
~MutexRelock() { mu_->Lock(); }
|
|
|
|
MutexRelock(const MutexRelock&) = delete;
|
|
MutexRelock& operator=(const MutexRelock&) = delete;
|
|
|
|
private:
|
|
absl::Mutex* mu_;
|
|
};
|
|
|
|
// This global lock guards the initialization and destruction of data_guard_,
|
|
// which is used to guard the other Flag data.
|
|
ABSL_CONST_INIT static absl::Mutex flag_mutex_lifetime_guard(absl::kConstInit);
|
|
|
|
} // namespace
|
|
|
|
void FlagImpl::Init() {
|
|
{
|
|
absl::MutexLock lock(&flag_mutex_lifetime_guard);
|
|
|
|
// Must initialize data guard for this flag.
|
|
if (!is_data_guard_inited_) {
|
|
new (&data_guard_) absl::Mutex;
|
|
is_data_guard_inited_ = true;
|
|
}
|
|
}
|
|
|
|
absl::MutexLock lock(reinterpret_cast<absl::Mutex*>(&data_guard_));
|
|
|
|
if (cur_ != nullptr) {
|
|
inited_.store(true, std::memory_order_release);
|
|
} else {
|
|
// Need to initialize cur field.
|
|
cur_ = MakeInitValue().release();
|
|
StoreAtomic();
|
|
inited_.store(true, std::memory_order_release);
|
|
InvokeCallback();
|
|
}
|
|
}
|
|
|
|
// Ensures that the lazily initialized data is initialized,
|
|
// and returns pointer to the mutex guarding flags data.
|
|
absl::Mutex* FlagImpl::DataGuard() const {
|
|
if (ABSL_PREDICT_FALSE(!inited_.load(std::memory_order_acquire))) {
|
|
const_cast<FlagImpl*>(this)->Init();
|
|
}
|
|
|
|
// data_guard_ is initialized.
|
|
return reinterpret_cast<absl::Mutex*>(&data_guard_);
|
|
}
|
|
|
|
void FlagImpl::Destroy() {
|
|
{
|
|
absl::MutexLock l(DataGuard());
|
|
|
|
// Values are heap allocated for Abseil Flags.
|
|
if (cur_) Delete(op_, cur_);
|
|
|
|
// Release the dynamically allocated default value if any.
|
|
if (def_kind_ == FlagDefaultSrcKind::kDynamicValue) {
|
|
Delete(op_, default_src_.dynamic_value);
|
|
}
|
|
|
|
// If this flag has an assigned callback, release callback data.
|
|
if (callback_data_) delete callback_data_;
|
|
}
|
|
|
|
absl::MutexLock l(&flag_mutex_lifetime_guard);
|
|
DataGuard()->~Mutex();
|
|
is_data_guard_inited_ = false;
|
|
}
|
|
|
|
std::unique_ptr<void, DynValueDeleter> FlagImpl::MakeInitValue() const {
|
|
void* res = nullptr;
|
|
if (def_kind_ == FlagDefaultSrcKind::kDynamicValue) {
|
|
res = Clone(op_, default_src_.dynamic_value);
|
|
} else {
|
|
res = (*default_src_.gen_func)();
|
|
}
|
|
return {res, DynValueDeleter{op_}};
|
|
}
|
|
|
|
std::string FlagImpl::Help() const {
|
|
return help_source_kind_ == FlagHelpSrcKind::kLiteral ? help_.literal
|
|
: help_.gen_func();
|
|
}
|
|
|
|
bool FlagImpl::IsModified() const {
|
|
absl::MutexLock l(DataGuard());
|
|
return modified_;
|
|
}
|
|
|
|
bool FlagImpl::IsSpecifiedOnCommandLine() const {
|
|
absl::MutexLock l(DataGuard());
|
|
return on_command_line_;
|
|
}
|
|
|
|
std::string FlagImpl::DefaultValue() const {
|
|
absl::MutexLock l(DataGuard());
|
|
|
|
auto obj = MakeInitValue();
|
|
return Unparse(marshalling_op_, obj.get());
|
|
}
|
|
|
|
std::string FlagImpl::CurrentValue() const {
|
|
absl::MutexLock l(DataGuard());
|
|
|
|
return Unparse(marshalling_op_, cur_);
|
|
}
|
|
|
|
void FlagImpl::SetCallback(
|
|
const flags_internal::FlagCallback mutation_callback) {
|
|
absl::MutexLock l(DataGuard());
|
|
|
|
if (callback_data_ == nullptr) {
|
|
callback_data_ = new CallbackData;
|
|
}
|
|
callback_data_->func = mutation_callback;
|
|
|
|
InvokeCallback();
|
|
}
|
|
|
|
void FlagImpl::InvokeCallback() const {
|
|
if (!callback_data_) return;
|
|
|
|
// Make a copy of the C-style function pointer that we are about to invoke
|
|
// before we release the lock guarding it.
|
|
FlagCallback cb = callback_data_->func;
|
|
|
|
// If the flag has a mutation callback this function invokes it. While the
|
|
// callback is being invoked the primary flag's mutex is unlocked and it is
|
|
// re-locked back after call to callback is completed. Callback invocation is
|
|
// guarded by flag's secondary mutex instead which prevents concurrent
|
|
// callback invocation. Note that it is possible for other thread to grab the
|
|
// primary lock and update flag's value at any time during the callback
|
|
// invocation. This is by design. Callback can get a value of the flag if
|
|
// necessary, but it might be different from the value initiated the callback
|
|
// and it also can be different by the time the callback invocation is
|
|
// completed. Requires that *primary_lock be held in exclusive mode; it may be
|
|
// released and reacquired by the implementation.
|
|
MutexRelock relock(DataGuard());
|
|
absl::MutexLock lock(&callback_data_->guard);
|
|
cb();
|
|
}
|
|
|
|
bool FlagImpl::RestoreState(const CommandLineFlag& flag, const void* value,
|
|
bool modified, bool on_command_line,
|
|
int64_t counter) {
|
|
{
|
|
absl::MutexLock l(DataGuard());
|
|
|
|
if (counter_ == counter) return false;
|
|
}
|
|
|
|
Write(flag, value, op_);
|
|
|
|
{
|
|
absl::MutexLock l(DataGuard());
|
|
|
|
modified_ = modified;
|
|
on_command_line_ = on_command_line;
|
|
}
|
|
|
|
return true;
|
|
}
|
|
|
|
// Attempts to parse supplied `value` string using parsing routine in the `flag`
|
|
// argument. If parsing successful, this function replaces the dst with newly
|
|
// parsed value. In case if any error is encountered in either step, the error
|
|
// message is stored in 'err'
|
|
bool FlagImpl::TryParse(const CommandLineFlag& flag, void** dst,
|
|
absl::string_view value, std::string* err) const {
|
|
auto tentative_value = MakeInitValue();
|
|
|
|
std::string parse_err;
|
|
if (!Parse(marshalling_op_, value, tentative_value.get(), &parse_err)) {
|
|
auto type_name = flag.Typename();
|
|
absl::string_view err_sep = parse_err.empty() ? "" : "; ";
|
|
absl::string_view typename_sep = type_name.empty() ? "" : " ";
|
|
*err = absl::StrCat("Illegal value '", value, "' specified for",
|
|
typename_sep, type_name, " flag '", flag.Name(), "'",
|
|
err_sep, parse_err);
|
|
return false;
|
|
}
|
|
|
|
void* old_val = *dst;
|
|
*dst = tentative_value.release();
|
|
tentative_value.reset(old_val);
|
|
|
|
return true;
|
|
}
|
|
|
|
void FlagImpl::Read(const CommandLineFlag& flag, void* dst,
|
|
const flags_internal::FlagOpFn dst_op) const {
|
|
absl::ReaderMutexLock l(DataGuard());
|
|
|
|
// `dst_op` is the unmarshaling operation corresponding to the declaration
|
|
// visibile at the call site. `op` is the Flag's defined unmarshalling
|
|
// operation. They must match for this operation to be well-defined.
|
|
if (ABSL_PREDICT_FALSE(dst_op != op_)) {
|
|
ABSL_INTERNAL_LOG(
|
|
ERROR,
|
|
absl::StrCat("Flag '", flag.Name(),
|
|
"' is defined as one type and declared as another"));
|
|
}
|
|
CopyConstruct(op_, cur_, dst);
|
|
}
|
|
|
|
void FlagImpl::StoreAtomic() {
|
|
size_t data_size = Sizeof(op_);
|
|
|
|
if (data_size <= sizeof(int64_t)) {
|
|
int64_t t = 0;
|
|
std::memcpy(&t, cur_, data_size);
|
|
atomic_.store(t, std::memory_order_release);
|
|
}
|
|
}
|
|
|
|
void FlagImpl::Write(const CommandLineFlag& flag, const void* src,
|
|
const flags_internal::FlagOpFn src_op) {
|
|
absl::MutexLock l(DataGuard());
|
|
|
|
// `src_op` is the marshalling operation corresponding to the declaration
|
|
// visible at the call site. `op` is the Flag's defined marshalling operation.
|
|
// They must match for this operation to be well-defined.
|
|
if (ABSL_PREDICT_FALSE(src_op != op_)) {
|
|
ABSL_INTERNAL_LOG(
|
|
ERROR,
|
|
absl::StrCat("Flag '", flag.Name(),
|
|
"' is defined as one type and declared as another"));
|
|
}
|
|
|
|
if (ShouldValidateFlagValue(flag)) {
|
|
void* obj = Clone(op_, src);
|
|
std::string ignored_error;
|
|
std::string src_as_str = Unparse(marshalling_op_, src);
|
|
if (!Parse(marshalling_op_, src_as_str, obj, &ignored_error)) {
|
|
ABSL_INTERNAL_LOG(ERROR,
|
|
absl::StrCat("Attempt to set flag '", flag.Name(),
|
|
"' to invalid value ", src_as_str));
|
|
}
|
|
Delete(op_, obj);
|
|
}
|
|
|
|
modified_ = true;
|
|
counter_++;
|
|
Copy(op_, src, cur_);
|
|
|
|
StoreAtomic();
|
|
InvokeCallback();
|
|
}
|
|
|
|
// Sets the value of the flag based on specified string `value`. If the flag
|
|
// was successfully set to new value, it returns true. Otherwise, sets `err`
|
|
// to indicate the error, leaves the flag unchanged, and returns false. There
|
|
// are three ways to set the flag's value:
|
|
// * Update the current flag value
|
|
// * Update the flag's default value
|
|
// * Update the current flag value if it was never set before
|
|
// The mode is selected based on 'set_mode' parameter.
|
|
bool FlagImpl::SetFromString(const CommandLineFlag& flag,
|
|
absl::string_view value, FlagSettingMode set_mode,
|
|
ValueSource source, std::string* err) {
|
|
absl::MutexLock l(DataGuard());
|
|
|
|
switch (set_mode) {
|
|
case SET_FLAGS_VALUE: {
|
|
// set or modify the flag's value
|
|
if (!TryParse(flag, &cur_, value, err)) return false;
|
|
modified_ = true;
|
|
counter_++;
|
|
StoreAtomic();
|
|
InvokeCallback();
|
|
|
|
if (source == kCommandLine) {
|
|
on_command_line_ = true;
|
|
}
|
|
break;
|
|
}
|
|
case SET_FLAG_IF_DEFAULT: {
|
|
// set the flag's value, but only if it hasn't been set by someone else
|
|
if (!modified_) {
|
|
if (!TryParse(flag, &cur_, value, err)) return false;
|
|
modified_ = true;
|
|
counter_++;
|
|
StoreAtomic();
|
|
InvokeCallback();
|
|
} else {
|
|
// TODO(rogeeff): review and fix this semantic. Currently we do not fail
|
|
// in this case if flag is modified. This is misleading since the flag's
|
|
// value is not updated even though we return true.
|
|
// *err = absl::StrCat(Name(), " is already set to ",
|
|
// CurrentValue(), "\n");
|
|
// return false;
|
|
return true;
|
|
}
|
|
break;
|
|
}
|
|
case SET_FLAGS_DEFAULT: {
|
|
if (def_kind_ == FlagDefaultSrcKind::kDynamicValue) {
|
|
if (!TryParse(flag, &default_src_.dynamic_value, value, err)) {
|
|
return false;
|
|
}
|
|
} else {
|
|
void* new_default_val = nullptr;
|
|
if (!TryParse(flag, &new_default_val, value, err)) {
|
|
return false;
|
|
}
|
|
|
|
default_src_.dynamic_value = new_default_val;
|
|
def_kind_ = FlagDefaultSrcKind::kDynamicValue;
|
|
}
|
|
|
|
if (!modified_) {
|
|
// Need to set both default value *and* current, in this case
|
|
Copy(op_, default_src_.dynamic_value, cur_);
|
|
StoreAtomic();
|
|
InvokeCallback();
|
|
}
|
|
break;
|
|
}
|
|
}
|
|
|
|
return true;
|
|
}
|
|
|
|
void FlagImpl::CheckDefaultValueParsingRoundtrip(
|
|
const CommandLineFlag& flag) const {
|
|
std::string v = DefaultValue();
|
|
|
|
absl::MutexLock lock(DataGuard());
|
|
|
|
auto dst = MakeInitValue();
|
|
std::string error;
|
|
if (!flags_internal::Parse(marshalling_op_, v, dst.get(), &error)) {
|
|
ABSL_INTERNAL_LOG(
|
|
FATAL,
|
|
absl::StrCat("Flag ", flag.Name(), " (from ", flag.Filename(),
|
|
"): std::string form of default value '", v,
|
|
"' could not be parsed; error=", error));
|
|
}
|
|
|
|
// We do not compare dst to def since parsing/unparsing may make
|
|
// small changes, e.g., precision loss for floating point types.
|
|
}
|
|
|
|
bool FlagImpl::ValidateInputValue(absl::string_view value) const {
|
|
absl::MutexLock l(DataGuard());
|
|
|
|
auto obj = MakeInitValue();
|
|
std::string ignored_error;
|
|
return flags_internal::Parse(marshalling_op_, value, obj.get(),
|
|
&ignored_error);
|
|
}
|
|
|
|
} // namespace flags_internal
|
|
ABSL_NAMESPACE_END
|
|
} // namespace absl
|