a4c3ffff11
-- ba4dd47492748bd630462eb68b7959037fc6a11a by Abseil Team <absl-team@google.com>: Work around nvcc 9.0 compiler bug for open-source Tensorflow build. With the current implementation, when I (unintentionally and transitively) include absl/types/optional.h in a CUDA compilation unit, I get the following nvcc error message: INFO: From Compiling tensorflow/core/kernels/crop_and_resize_op_gpu.cu.cc: external/com_google_absl/absl/types/optional.h: In member function 'void absl::optional_internal::optional_data_dtor_base<T, <anonymous> >::destruct()': external/com_google_absl/absl/types/optional.h:185:50: error: '__T0' was not declared in this scope data_.~T(); I've also seen similar compilation failures online, for flat_hash_map: https://devtalk.nvidia.com/default/topic/1042599/nvcc-preprocessor-bug-causes-compilation-failure/ The bug is always around unnamed template parameters. Therefore, the workaround is to make them named. PiperOrigin-RevId: 219208288 -- dad2f40cb2e8d5017660985ef6fb57f3c3cdcc80 by CJ Johnson <johnsoncj@google.com>: Adds internal macros for catching and throwing unknown exception types PiperOrigin-RevId: 219207362 -- 0a9840328d2d86e8420b853435fdbf1f7a19d931 by Abseil Team <absl-team@google.com>: Fix typo in mutex.h comments. PiperOrigin-RevId: 219199397 -- 0d576dc7597564210bfdf91518075064756f0bf4 by Matt Calabrese <calabrese@google.com>: Internal change. PiperOrigin-RevId: 219185475 -- 66be156095571959fb19a76da8ad0b53ec37658e by Abseil Team <absl-team@google.com>: Fix alignment conformance for VS 2017 >= 15.8 (fix #193) PiperOrigin-RevId: 219129894 -- a6e1825a12587945f8194677ccfdcaba6f7aad1d by Abseil Team <absl-team@google.com>: Reapply PR #173 PiperOrigin-RevId: 219129361 -- cf72ade4881b25acc6ccaea468f69793a0fdce32 by Abseil Team <absl-team@google.com>: Update .gitignore PiperOrigin-RevId: 219127495 -- 0537490c6348a2cb489abe15638928ac5aa6982a by Jon Cohen <cohenjon@google.com>: Small refactor and reformat of error messages from the exception safety test framework. PiperOrigin-RevId: 218927773 -- 4c556ca45fa25698ad12002a00c713aeceefab73 by CJ Johnson <johnsoncj@google.com>: Updates the inlined vector swap tests to check for number of moves that took place if available PiperOrigin-RevId: 218900777 -- dcbfda0021a1e6dfa9586986b1269c06ec394053 by Mark Barolak <mbar@google.com>: Add parens around calls to std::numeric_limits<>::min and std::numeric_limits<>::max to prevent compilation errors on Windows platforms where min and max are defined as macros. PiperOrigin-RevId: 218888700 GitOrigin-RevId: ba4dd47492748bd630462eb68b7959037fc6a11a Change-Id: I0e393958eb8cb501b85f6114979f6d4d86ed996c
168 lines
5.3 KiB
Python
168 lines
5.3 KiB
Python
"""absl specific copts.
|
|
|
|
Flags specified here must not impact ABI. Code compiled with and without these
|
|
opts will be linked together, and in some cases headers compiled with and
|
|
without these options will be part of the same program.
|
|
"""
|
|
GCC_FLAGS = [
|
|
"-Wall",
|
|
"-Wextra",
|
|
"-Wcast-qual",
|
|
"-Wconversion-null",
|
|
"-Wmissing-declarations",
|
|
"-Woverlength-strings",
|
|
"-Wpointer-arith",
|
|
"-Wunused-local-typedefs",
|
|
"-Wunused-result",
|
|
"-Wvarargs",
|
|
"-Wvla", # variable-length array
|
|
"-Wwrite-strings",
|
|
# Google style does not use unsigned integers, though STL containers
|
|
# have unsigned types.
|
|
"-Wno-sign-compare",
|
|
]
|
|
|
|
GCC_TEST_FLAGS = [
|
|
"-Wno-conversion-null",
|
|
"-Wno-missing-declarations",
|
|
"-Wno-sign-compare",
|
|
"-Wno-unused-function",
|
|
"-Wno-unused-parameter",
|
|
"-Wno-unused-private-field",
|
|
]
|
|
|
|
# Docs on single flags is preceded by a comment.
|
|
# Docs on groups of flags is preceded by ###.
|
|
|
|
LLVM_FLAGS = [
|
|
"-Wall",
|
|
"-Wextra",
|
|
"-Weverything",
|
|
# Abseil does not support C++98
|
|
"-Wno-c++98-compat-pedantic",
|
|
# Turns off all implicit conversion warnings. Most are re-enabled below.
|
|
"-Wno-conversion",
|
|
"-Wno-covered-switch-default",
|
|
"-Wno-deprecated",
|
|
"-Wno-disabled-macro-expansion",
|
|
"-Wno-double-promotion",
|
|
###
|
|
# Turned off as they include valid C++ code.
|
|
"-Wno-comma",
|
|
"-Wno-extra-semi",
|
|
"-Wno-packed",
|
|
"-Wno-padded",
|
|
###
|
|
# Google style does not use unsigned integers, though STL containers
|
|
# have unsigned types.
|
|
"-Wno-sign-compare",
|
|
###
|
|
"-Wno-float-conversion",
|
|
"-Wno-float-equal",
|
|
"-Wno-format-nonliteral",
|
|
# Too aggressive: warns on Clang extensions enclosed in Clang-only
|
|
# compilation paths.
|
|
"-Wno-gcc-compat",
|
|
###
|
|
# Some internal globals are necessary. Don't do this at home.
|
|
"-Wno-global-constructors",
|
|
"-Wno-exit-time-destructors",
|
|
###
|
|
"-Wno-nested-anon-types",
|
|
"-Wno-non-modular-include-in-module",
|
|
"-Wno-old-style-cast",
|
|
# Warns on preferred usage of non-POD types such as string_view
|
|
"-Wno-range-loop-analysis",
|
|
"-Wno-reserved-id-macro",
|
|
"-Wno-shorten-64-to-32",
|
|
"-Wno-switch-enum",
|
|
"-Wno-thread-safety-negative",
|
|
"-Wno-undef",
|
|
"-Wno-unknown-warning-option",
|
|
"-Wno-unreachable-code",
|
|
# Causes warnings on include guards
|
|
"-Wno-unused-macros",
|
|
"-Wno-weak-vtables",
|
|
###
|
|
# Implicit conversion warnings turned off by -Wno-conversion
|
|
# which are re-enabled below.
|
|
"-Wbitfield-enum-conversion",
|
|
"-Wbool-conversion",
|
|
"-Wconstant-conversion",
|
|
"-Wenum-conversion",
|
|
"-Wint-conversion",
|
|
"-Wliteral-conversion",
|
|
"-Wnon-literal-null-conversion",
|
|
"-Wnull-conversion",
|
|
"-Wobjc-literal-conversion",
|
|
"-Wno-sign-conversion",
|
|
"-Wstring-conversion",
|
|
###
|
|
]
|
|
|
|
LLVM_TEST_FLAGS = [
|
|
"-Wno-c99-extensions",
|
|
"-Wno-missing-noreturn",
|
|
"-Wno-missing-prototypes",
|
|
"-Wno-missing-variable-declarations",
|
|
"-Wno-null-conversion",
|
|
"-Wno-shadow",
|
|
"-Wno-shift-sign-overflow",
|
|
"-Wno-sign-compare",
|
|
"-Wno-unused-function",
|
|
"-Wno-unused-member-function",
|
|
"-Wno-unused-parameter",
|
|
"-Wno-unused-private-field",
|
|
"-Wno-unused-template",
|
|
"-Wno-used-but-marked-unused",
|
|
"-Wno-zero-as-null-pointer-constant",
|
|
# gtest depends on this GNU extension being offered.
|
|
"-Wno-gnu-zero-variadic-macro-arguments",
|
|
]
|
|
|
|
MSVC_FLAGS = [
|
|
"/W3",
|
|
"/wd4005", # macro-redefinition
|
|
"/wd4068", # unknown pragma
|
|
"/wd4180", # qualifier applied to function type has no meaning; ignored
|
|
"/wd4244", # conversion from 'type1' to 'type2', possible loss of data
|
|
"/wd4267", # conversion from 'size_t' to 'type', possible loss of data
|
|
"/wd4800", # forcing value to bool 'true' or 'false' (performance warning)
|
|
"/DNOMINMAX", # Don't define min and max macros (windows.h)
|
|
"/DWIN32_LEAN_AND_MEAN", # Don't bloat namespace with incompatible winsock versions.
|
|
"/D_CRT_SECURE_NO_WARNINGS", # Don't warn about usage of insecure C functions.
|
|
"/D_SCL_SECURE_NO_WARNINGS", # Don't warm when the compiler encounters a function or
|
|
# variable that is marked as deprecated (same as /wd4996).
|
|
"/D_ENABLE_EXTENDED_ALIGNED_STORAGE", # Introduced in VS 2017 15.8,
|
|
# before the member type would non-conformingly have an alignment of only alignof(max_align_t).
|
|
]
|
|
|
|
MSVC_TEST_FLAGS = [
|
|
"/wd4018", # signed/unsigned mismatch
|
|
"/wd4101", # unreferenced local variable
|
|
"/wd4503", # decorated name length exceeded, name was truncated
|
|
]
|
|
|
|
# /Wall with msvc includes unhelpful warnings such as C4711, C4710, ...
|
|
ABSL_DEFAULT_COPTS = select({
|
|
"//absl:windows": MSVC_FLAGS,
|
|
"//absl:llvm_compiler": LLVM_FLAGS,
|
|
"//conditions:default": GCC_FLAGS,
|
|
})
|
|
|
|
# in absence of modules (--compiler=gcc or -c opt), cc_tests leak their copts
|
|
# to their (included header) dependencies and fail to build outside absl
|
|
ABSL_TEST_COPTS = ABSL_DEFAULT_COPTS + select({
|
|
"//absl:windows": MSVC_TEST_FLAGS,
|
|
"//absl:llvm_compiler": LLVM_TEST_FLAGS,
|
|
"//conditions:default": GCC_TEST_FLAGS,
|
|
})
|
|
|
|
ABSL_EXCEPTIONS_FLAG = select({
|
|
"//absl:windows": ["/U_HAS_EXCEPTIONS", "/D_HAS_EXCEPTIONS=1", "/EHsc"],
|
|
"//conditions:default": ["-fexceptions"],
|
|
})
|
|
|
|
ABSL_EXCEPTIONS_FLAG_LINKOPTS = select({
|
|
"//conditions:default": [],
|
|
})
|