tvl-depot/tvix/eval/src
sterni 7165ebc43b fix(tvix/eval): remove incorrect imports when coercing
The default behavior of string coercion in C++ Nix is to weakly coerce
and import to store if necessary. There is a flag to make it strongly
coerce (coerceMore) and a flag that controls whether path values have
the corresponding file/directory imported into the store before
returning the (store) path as a string (copyToStore). We need to
implement our equivalent to the copyToStore (import_paths) flag for the
benefit of weak coercions that don't import into the store (dirOf,
baseNameOf, readFile, ...) and strong coercions that don't import into
the store (toString).

This makes coerce_to_string as well as CoercionKind weirder and more
versatile, but prevents us from reimplementing parts of the coercion
logic constantly as can be seen in the case of baseNameOf.

Note that it is not possible to test this properly in //tvix/eval tests
due to the lack of an appropriate EvalIO implementation being available.
Tests should be added to //tvix/glue down the line.

Change-Id: I8fb8ab99c7fe08e311d2ba1c36960746bf22f566
Reviewed-on: https://cl.tvl.fyi/c/depot/+/10361
Autosubmit: sterni <sternenseemann@systemli.org>
Tested-by: BuildkiteCI
Reviewed-by: Adam Joseph <adam@westernsemico.com>
2023-12-14 13:15:23 +00:00
..
builtins fix(tvix/eval): remove incorrect imports when coercing 2023-12-14 13:15:23 +00:00
compiler fix(tvix/eval): add unimplemented __curPos and builtins.filterSource 2023-12-12 17:20:50 +00:00
tests fix(tvix/eval): substring: propagate catchables 2023-12-12 17:51:29 +00:00
value fix(tvix/eval): remove incorrect imports when coercing 2023-12-14 13:15:23 +00:00
vm fix(tvix/eval): remove incorrect imports when coercing 2023-12-14 13:15:23 +00:00
chunk.rs docs(tvix/eval): fix some broken docstr references 2023-09-22 09:14:33 +00:00
errors.rs fix(tvix/eval): remove incorrect imports when coercing 2023-12-14 13:15:23 +00:00
io.rs refactor(tvix): use io::Result for EvalIO 2023-12-12 14:28:50 +00:00
lib.rs chore(tvix): add missing clippy attributes & config 2023-11-05 20:28:38 +00:00
nix_search_path.rs fix(tvix/eval): fix b/281 by adding Value::Catchable 2023-09-24 21:54:10 +00:00
observer.rs refactor(tvix/eval/observer): cargo clippy 2023-08-20 21:51:04 +00:00
opcode.rs fix(tvix/eval): remove incorrect imports when coercing 2023-12-14 13:15:23 +00:00
pretty_ast.rs fix(tvix/eval): fix current clippy warnings 2022-12-25 18:25:06 +00:00
properties.rs refactor(tvix/eval): Don't (ab)use PartialEq for Nix equality 2022-09-18 22:03:41 +00:00
source.rs refactor(tvix/eval): impl Default for SourceCode 2023-08-20 21:52:21 +00:00
spans.rs feat(tvix/eval): drop LightSpan::Delayed 2023-12-12 14:34:28 +00:00
systems.rs fix(tvix/eval): fix current clippy warnings 2022-12-25 18:25:06 +00:00
test_utils.rs test(tvix/eval): Add proof-of-concept test for Chunk 2022-09-18 17:55:06 +00:00
upvalues.rs fix(tvix/eval): remove impl PartialEq for Value 2022-11-04 00:30:13 +00:00
warnings.rs fix(tvix/eval): emit only warnings on shadowed outputs 2023-06-11 20:59:34 +00:00