2fcf2d0d20
Replace the custom, rather questionable base64 implementation with
absl::Base64{Une,E}scape. To make sure that the custom implementation
was doing the same thing I've also added a test covering
nix::Hash::to_string, which was one function that used it - the test
passed prior to the replacement, and continued to pass afterwards.
The previous base64Decode function threw an exception on failure - to
avoid going too far down the rabbit hole I've replicated that
functionality at all call sites, but this should be replaced with more
sensible error handling such as StatusOr eventually.
Also, before this change:
❯ nix eval -f . users.tazjin.emacs.outPath
"/nix/store/g6ri2q8nra96ix20bcsc734r1yyaylb1-tazjins-emacs"
And after:
❯ ./result/bin/nix eval -f . users.tazjin.emacs.outPath
"/nix/store/g6ri2q8nra96ix20bcsc734r1yyaylb1-tazjins-emacs"
Change-Id: Id292ffbb82fe808f3f1b34670afbe7b8c13ad615
Reviewed-on: https://cl.tvl.fyi/c/depot/+/1385
Reviewed-by: tazjin <mail@tazj.in>
Tested-by: BuildkiteCI
|
||
|---|---|---|
| .. | ||
| abseil_cpp | ||
| apereo-cas | ||
| bat_syntaxes | ||
| bufbuild | ||
| cgit | ||
| cpp/googleapis | ||
| emacs | ||
| farmhash | ||
| ffmpeg | ||
| gerrit | ||
| gerrit_plugins | ||
| git | ||
| git-bug | ||
| gitignoreSource | ||
| glog | ||
| gopkgs | ||
| grpc | ||
| gtest | ||
| haskell-language-server | ||
| haskell_overlay | ||
| immer | ||
| kernelPatches/trx40_usb_audio | ||
| lieer | ||
| lisp | ||
| naersk | ||
| nix | ||
| nixery | ||
| notmuch | ||
| nsfv | ||
| openldap | ||
| protobuf | ||
| python/broadlink | ||
| rapidcheck | ||
| rr | ||
| smtprelay | ||
| telega | ||
| terraform-gcp | ||
| default.nix | ||
| haskell-overlay.nix | ||
| README.md | ||
Third-Party Code
Code under this folder is one of the following:
-
Externally developed dependencies which have been imported ("vendored") into this repository. These dependencies come with their own licenses and whatever else.
-
Code that is developed inside of this repository, but released to an external repository via Copybara.