tvl-depot/tvix
Adam Joseph 2b4920c355 fix(tvix/cli): panic on root cause of the fetchurl(non-boot) bug
Currently we produce wrong drvPaths for a large number of packages
that use fetchurl (but not fetchurlBoot, which is what stdenv uses).
A simple reproducer is `pkgs.perl538`.

I debugged this down to the root cause, which is the fact that tvix
doesn't realize that the mapping from FOD-paths to outputHash is
*NOT* a 1:1 mapping.  It is a many-to-one mapping.  You can have
lots of different FODs with the same outputHash or even the same
outPath.  For example, perl538.src and perldevel.src use the same
source tarball but a different `version`.

Anyways, I have found the root cause but have run out of time for a
while, so I've added a panic!() to in the spot where we have a logic
bug in order to call it out.

Change-Id: I9766b39cfe2fe7eafec84945b2ad6cc28f9c4b7d
Reviewed-on: https://cl.tvl.fyi/c/depot/+/9364
Reviewed-by: flokli <flokli@flokli.de>
Tested-by: BuildkiteCI
Autosubmit: Adam Joseph <adam@westernsemico.com>
2023-12-10 14:16:21 +00:00
..
.vscode chore(tvix): fix vscode rust-analyzer recommendation 2022-10-15 16:54:28 +00:00
boot refactor(tvix/nar-bridge): mv nar-bridge{,-http} 2023-10-05 06:17:10 +00:00
castore refactor(tvix/castore): address clippy 2023-12-09 12:58:39 +00:00
castore-go feat(tvix/castore): extend blobstore protos for verified streaming 2023-11-05 15:13:52 +00:00
cli refactor(tvix/glue): move builtins into separate directory 2023-11-04 15:20:46 +00:00
docs docs(tvix/docs): add document about drvPath differences 2023-08-20 22:08:02 +00:00
eval refactor(tvix/eval): address clippy lints 2023-12-09 12:58:39 +00:00
glue fix(tvix/cli): panic on root cause of the fetchurl(non-boot) bug 2023-12-10 14:16:21 +00:00
nar-bridge fix(tvix/nar-bridge): fix FOD hash 2023-12-09 09:24:53 +00:00
nix-compat refactor(nix-compat/aterm): address clippy 2023-12-09 12:58:39 +00:00
proto refactor(tvix): move castore into tvix-castore crate 2023-09-22 12:51:21 +00:00
scripts refactor(tvix): Make benchmark script directory-agnostic 2023-12-06 16:19:46 +00:00
serde fix(tvix/eval): fix b/281 by adding Value::Catchable 2023-09-24 21:54:10 +00:00
store refactor(store/fs): address clippy 2023-12-09 12:58:39 +00:00
store-go chore(tvix/store-go): bump castore-go 2023-11-05 20:32:34 +00:00
tools chore(3p/sources): bump channels & overlays (2023-11-27) 2023-11-27 21:16:46 +00:00
verify-lang-tests fix(tvix/eval): update identifier quoting to match cppnix 2.17 2023-09-15 00:00:59 +00:00
website feat(tvix/website): add structured data for search engines 2023-10-05 17:14:13 +00:00
.gitignore chore(tvix): add /*.sled to .gitignore 2023-09-24 17:05:48 +00:00
buildkite.yml chore(tvix): move buildkite.yml from views/tvix to tvix/ 2023-10-25 08:22:57 +00:00
Cargo.lock chore(tvix/nix_cli): drop crate 2023-12-09 12:58:39 +00:00
Cargo.nix chore(tvix/nix_cli): drop crate 2023-12-09 12:58:39 +00:00
Cargo.toml chore(tvix/nix_cli): drop crate 2023-12-09 12:58:39 +00:00
clippy.toml chore(tvix): add missing clippy attributes & config 2023-11-05 20:28:38 +00:00
crate-hashes.json fix(tvix): patch futures::AsyncBufReadExt::fill_buf 2023-11-19 08:35:38 +00:00
default.nix feat(tvix): make clippy stricter 2023-12-09 12:58:39 +00:00
LICENSE chore(tvix): Bootstrap Tvix folder 2021-03-27 00:09:49 +00:00
logo.webp refactor(tvix): move logo to //tvix:logo 2023-09-10 13:13:14 +00:00
OWNERS chore(gerrit): migrate OWNERS files to code-owners style 2022-09-19 11:13:28 +00:00
README.md fix(tvix/nar-bridge): drop pathinfoservice 2023-11-28 16:08:59 +00:00
shell.nix fix(tvix): fix cargo test for nix_oracle 2023-11-03 09:15:27 +00:00


Tvix is a new implementation of the Nix language and package manager. See the announcement post for information about the background of this project.

Tvix is developed by TVL in our monorepo, the depot, at //tvix. Code reviews take place on Gerrit, bugs are filed in our issue tracker.

For more information about Tvix, feel free to reach out. We are interested in people who would like to help us review designs, brainstorm and describe requirements that we may not yet have considered.

Most of the discussion around development happens on our IRC channel, which you can join in several ways documented on tvl.fyi, or on our mailing list.

Contributions to Tvix follow the TVL review flow and contribution guidelines.

WARNING: Tvix is not ready for use in production. None of our current APIs should be considered stable in any way.

WARNING: Any other instances of this project or repository are josh-mirrors. We do not accept code contributions or issues outside of the tooling and communication methods outlined above.

Components

This folder contains the following components:

  • //tvix/castore - subtree storage/transfer in a content-addressed fashion
  • //tvix/cli - preliminary REPL & CLI implementation for Tvix
  • //tvix/eval - an implementation of the Nix programming language
  • //tvix/nar-bridge
    • nar-bridge-http: A HTTP webserver providing a Nix HTTP Binary Cache interface in front of a tvix-store
  • //tvix/nix-compat - a Rust library for compatibility with C++ Nix, features like encodings and hashing schemes and formats
  • //tvix/serde - a Rust library for using the Nix language for app configuration
  • //tvix/store - a "filesystem" linking Nix store paths and metadata with the content-addressed layer

Some additional folders with auxiliary things exist and can be explored at your leisure.

Building the CLI

The CLI can also be built with standard Rust tooling (i.e. cargo build), as long as you are in a shell with the right dependencies.

  • If you cloned the full monorepo, it can be provided by mg shell //tvix:shell.
  • If you cloned the tvix workspace only (git clone https://code.tvl.fyi/depot.git:workspace=views/tvix.git), nix-shell provides it.

If you're in the TVL monorepo, you can also run mg build //tvix/cli (or mg build from inside that folder) for a more incremental build.

Please follow the depot-wide instructions on how to get mg and use the depot tooling.

Compatibility

Important note: We only use and test Nix builds of our software against Nix 2.3. There are a variety of bugs and subtle problems in newer Nix versions which we do not have the bandwidth to address, builds in newer Nix versions may or may not work.

Rust projects, crate2nix

Some parts of Tvix are written in Rust. To simplify the dependency management on the Nix side of these builds, we use crate2nix in a single Rust workspace in //tvix to maintain the Nix build configuration.

When making changes to Cargo dependency configuration in any of the Rust projects under //tvix, be sure to run mg run //tvix:crate2nixGenerate -- in //tvix itself and commit the changes to the generated Cargo.nix file. This only applies to the full TVL checkout.

License structure

All code implemented for Tvix is licensed under the GPL-3.0, with the exception of the protocol buffer definitions used for communication between services which are available under a more permissive license (MIT).

The idea behind this structure is that any direct usage of our code (e.g. linking to it, embedding the evaluator, etc.) will fall under the terms of the GPL3, but users are free to implement their own components speaking these protocols under the terms of the MIT license.