0ecd10bf30
This provides a Nix HTTP Binary Cache interface in front of a tvix-store that's reachable via gRPC. TODOs: - remove import command, move serve up to toplevel. We have nix-copy- closure and tvix-store commands. - loop into CI. We should be able to fetch the protos as a third-party dependency. - Check if we can test nar-bridge slightly easier in an integration test. - Ensure we support connecting to unix sockets and grpc+http at least, using the same syntax as tvix-store. - Don't buffer the entire blob when rendering NAR Co-Authored-By: Connor Brewster <cbrewster@hey.com> Co-Authored-By: Márton Boros <martonboros@gmail.com> Co-Authored-By: Vo Minh Thu <noteed@gmail.com> Change-Id: I6064474e49dfe78cea67676957462d9f28658d4a Reviewed-on: https://cl.tvl.fyi/c/depot/+/9339 Tested-by: BuildkiteCI Reviewed-by: tazjin <tazjin@tvl.su>
140 lines
4.3 KiB
Go
140 lines
4.3 KiB
Go
package server
|
|
|
|
import (
|
|
"bufio"
|
|
"bytes"
|
|
"fmt"
|
|
"net/http"
|
|
|
|
"code.tvl.fyi/tvix/nar-bridge/pkg/reader"
|
|
storev1pb "code.tvl.fyi/tvix/store/protos"
|
|
"github.com/go-chi/chi/v5"
|
|
nixhash "github.com/nix-community/go-nix/pkg/hash"
|
|
"github.com/nix-community/go-nix/pkg/nixbase32"
|
|
"github.com/sirupsen/logrus"
|
|
log "github.com/sirupsen/logrus"
|
|
)
|
|
|
|
func registerNarPut(s *Server) {
|
|
s.handler.Put(narUrl, func(w http.ResponseWriter, r *http.Request) {
|
|
defer r.Body.Close()
|
|
|
|
ctx := r.Context()
|
|
|
|
// parse the narhash sent in the request URL
|
|
narHashFromUrl, err := parseNarHashFromUrl(chi.URLParamFromCtx(ctx, "narhash"))
|
|
if err != nil {
|
|
log.WithError(err).WithField("url", r.URL).Error("unable to decode nar hash from url")
|
|
w.WriteHeader(http.StatusBadRequest)
|
|
_, err := w.Write([]byte("unable to decode nar hash from url"))
|
|
if err != nil {
|
|
log.WithError(err).Error("unable to write error message to client")
|
|
}
|
|
|
|
return
|
|
}
|
|
|
|
log := log.WithField("narhash_url", narHashFromUrl.SRIString())
|
|
|
|
directoriesUploader := NewDirectoriesUploader(ctx, s.directoryServiceClient)
|
|
defer directoriesUploader.Done() //nolint:errcheck
|
|
|
|
rd := reader.New(bufio.NewReader(r.Body))
|
|
pathInfo, err := rd.Import(
|
|
ctx,
|
|
genBlobServiceWriteCb(ctx, s.blobServiceClient),
|
|
func(directory *storev1pb.Directory) error {
|
|
return directoriesUploader.Put(directory)
|
|
},
|
|
)
|
|
|
|
if err != nil {
|
|
log.Errorf("error during NAR import: %v", err)
|
|
w.WriteHeader(http.StatusInternalServerError)
|
|
_, err := w.Write([]byte(fmt.Sprintf("error during NAR import: %v", err)))
|
|
if err != nil {
|
|
log.WithError(err).Errorf("unable to write error message to client")
|
|
}
|
|
|
|
return
|
|
}
|
|
|
|
log.Infof("closing the stream")
|
|
|
|
// Close the directories uploader
|
|
directoriesPutResponse, err := directoriesUploader.Done()
|
|
if err != nil {
|
|
log.WithError(err).Error("error during directory upload")
|
|
w.WriteHeader(http.StatusBadRequest)
|
|
_, err := w.Write([]byte("error during directory upload"))
|
|
if err != nil {
|
|
log.WithError(err).Errorf("unable to write error message to client")
|
|
}
|
|
|
|
return
|
|
}
|
|
// If we uploaded directories (so directoriesPutResponse doesn't return null),
|
|
// the RootDigest field in directoriesPutResponse should match the digest
|
|
// returned in the PathInfo struct returned by the `Import` call.
|
|
// This check ensures the server-side came up with the same root hash.
|
|
|
|
if directoriesPutResponse != nil {
|
|
rootDigestPathInfo := pathInfo.GetNode().GetDirectory().GetDigest()
|
|
rootDigestDirectoriesPutResponse := directoriesPutResponse.GetRootDigest()
|
|
|
|
log := log.WithFields(logrus.Fields{
|
|
"root_digest_pathinfo": rootDigestPathInfo,
|
|
"root_digest_directories_put_resp": rootDigestDirectoriesPutResponse,
|
|
})
|
|
if !bytes.Equal(rootDigestPathInfo, rootDigestDirectoriesPutResponse) {
|
|
log.Errorf("returned root digest doesn't match what's calculated")
|
|
|
|
w.WriteHeader(http.StatusBadRequest)
|
|
_, err := w.Write([]byte("error in root digest calculation"))
|
|
if err != nil {
|
|
log.WithError(err).Error("unable to write error message to client")
|
|
}
|
|
|
|
return
|
|
}
|
|
}
|
|
|
|
// Compare the nar hash specified in the URL with the one that has been
|
|
// calculated while processing the NAR file
|
|
piNarHash, err := nixhash.ParseNixBase32(
|
|
"sha256:" + nixbase32.EncodeToString(pathInfo.GetNarinfo().NarSha256),
|
|
)
|
|
if err != nil {
|
|
panic("must parse nixbase32")
|
|
}
|
|
|
|
if !bytes.Equal(narHashFromUrl.Digest(), piNarHash.Digest()) {
|
|
log := log.WithFields(logrus.Fields{
|
|
"narhash_received_sha256": piNarHash.SRIString(),
|
|
"narsize": pathInfo.GetNarinfo().GetNarSize(),
|
|
})
|
|
log.Error("received bytes don't match narhash from URL")
|
|
|
|
w.WriteHeader(http.StatusBadRequest)
|
|
_, err := w.Write([]byte("received bytes don't match narHash specified in URL"))
|
|
if err != nil {
|
|
log.WithError(err).Errorf("unable to write error message to client")
|
|
}
|
|
|
|
return
|
|
|
|
}
|
|
|
|
// Insert the partial pathinfo structs into our lookup map,
|
|
// so requesting the NAR file will be possible.
|
|
// The same might exist already, but it'll have the same contents (so
|
|
// replacing will be a no-op), except maybe the root node Name field value, which
|
|
// is safe to ignore (as not part of the NAR).
|
|
s.narHashToPathInfoMu.Lock()
|
|
s.narHashToPathInfo[piNarHash.SRIString()] = pathInfo
|
|
s.narHashToPathInfoMu.Unlock()
|
|
|
|
// Done!
|
|
})
|
|
|
|
}
|