13327debeb
-- 15d7bcf28220750db46930f4d8c090b54e3ae5fe by Jon Cohen <cohenjon@google.com>: Fix miscellaneous CMake change interleaving issues for the daily release: * add back the absl::container target * Add copts to absl_cc_library targets in absl/container/CMakeLists.txt * Add trailing newline to the end of AbseilConfigureCopts.cmake PiperOrigin-RevId: 223057096 -- baac35470d75b6561477f688dc4eb021f604cf71 by Abseil Team <absl-team@google.com>: Internal Cleanup. PiperOrigin-RevId: 223051579 -- 6791c2f2e35b030b5579f36d3c607c6ba92fa089 by Abseil Team <absl-team@google.com>: Internal Change. PiperOrigin-RevId: 223046855 -- 5467ad987ea82aef77d2f1cc85aa9105e7d9c320 by Samuel Benzaquen <sbenza@google.com>: Workaround for gcc bug https://gcc.gnu.org/PR88115 PiperOrigin-RevId: 223041901 -- 36fa5cfd41df2b71d26487c45363901bbf6a2463 by Tom Manshreck <shreck@google.com>: Clarify visit() constraints PiperOrigin-RevId: 223032194 -- afdf4013de036b411db7f92cde8a2493e6665223 by Abseil Team <absl-team@google.com>: Fix comment typos. PiperOrigin-RevId: 223024090 -- e11c01927eb8b898f6633282824022104b258342 by Jon Cohen <cohenjon@google.com>: Make absl::spinlock_test_common TESTONLY This should fix https://github.com/abseil/abseil-cpp/issues/221 PiperOrigin-RevId: 222885323 -- 5ccc576d1c68e4b92705aa8064f1e8d715e5415e by Abseil Team <absl-team@google.com>: Internal change. PiperOrigin-RevId: 222877017 -- 96ff25bf78c4f4bca0d6e61faa4feeab91a2e73c by Jon Cohen <cohenjon@google.com>: Align CMake and Bazel compile options. This is the first step towards a single source of truth for Abseil compile options. Also makes absl_test and absl_cc_test make binaries and targets with compatible names to each other to make testing easier. PiperOrigin-RevId: 222858408 -- 7dd3e2618ad5a5de5d918fc73e438ef0b98cec6a by Abseil Team <absl-team@google.com>: Revert "absl: cap SpinLock backoff to 4ms" PiperOrigin-RevId: 222656230 -- 0d49538a3cab714156ed0a5651656c0aa098a1e5 by Abseil Team <absl-team@google.com>: Update absl/container/CMakeLists.txt to use new functions i.e. absl_cc_(library|test) PiperOrigin-RevId: 222535766 -- 92744e9d0e5c3bf9e1167a7bdf1a6777192531b1 by Abseil Team <absl-team@google.com>: Disable header parsing for broken targets PiperOrigin-RevId: 222257218 -- 39a6c623601c44e02d91e412f126a813d719507b by Abseil Team <absl-team@google.com>: absl: cap SpinLock backoff to 4ms The current backoff logic has 3 problems: 1. It can produce too high values (up to 256ms), which can negatively affect tail latency. The value was chosen long time ago and now it's a good idea to reconsider it. 2. It does not have low bound, so on any iteration it can produce a very small value that will lead to unnecessary cpu consumption. 3. It does not increase low bound with the number of iterations. So if the SpinLock is actually somehow locked for a very prolonged time, a waiter can still wake periodically. Rework the logic to solve these problems. Add lower bound of 128us, no code should rely on absence of episodic delays in this range as they can occur everywhere. Lower upper bound to 4ms. A thread sleeping for 4ms does not consume significant cpu time (see below). Grow lower bound with the number of iterations. This is cpu consumption of a process doing usleep(x) in a loop (sampled with ps): 64us -> 4.0% 128us -> 2.7% 256us -> 3.5% 512us -> 2.8% 1024us -> 1.6% 2048us -> 0.6% 4096us -> 0.3% 8192us -> 0.0% Few millisecond sleeps do not consume significant time. PiperOrigin-RevId: 222196086 -- 17104a2396ddda61fb0faed0a72ff8c161ca17ea by Shahriar Rouf <nafi@google.com>: Add benchmarks for hashing civil_times. PiperOrigin-RevId: 222152108 GitOrigin-RevId: 15d7bcf28220750db46930f4d8c090b54e3ae5fe Change-Id: I73b929feaf6ce72b70fdafd6108f53bbbeaf9738
170 lines
5.4 KiB
Python
170 lines
5.4 KiB
Python
"""absl specific copts.
|
|
|
|
Flags specified here must not impact ABI. Code compiled with and without these
|
|
opts will be linked together, and in some cases headers compiled with and
|
|
without these options will be part of the same program.
|
|
|
|
DO NOT CHANGE THIS FILE WITHOUT CHANGING THE SAME FLAG IN absl/CMake/AbseilConfigureCopts.cmake!!
|
|
"""
|
|
GCC_FLAGS = [
|
|
"-Wall",
|
|
"-Wextra",
|
|
"-Wcast-qual",
|
|
"-Wconversion-null",
|
|
"-Wmissing-declarations",
|
|
"-Woverlength-strings",
|
|
"-Wpointer-arith",
|
|
"-Wunused-local-typedefs",
|
|
"-Wunused-result",
|
|
"-Wvarargs",
|
|
"-Wvla", # variable-length array
|
|
"-Wwrite-strings",
|
|
# Google style does not use unsigned integers, though STL containers
|
|
# have unsigned types.
|
|
"-Wno-sign-compare",
|
|
]
|
|
|
|
GCC_TEST_FLAGS = [
|
|
"-Wno-conversion-null",
|
|
"-Wno-missing-declarations",
|
|
"-Wno-sign-compare",
|
|
"-Wno-unused-function",
|
|
"-Wno-unused-parameter",
|
|
"-Wno-unused-private-field",
|
|
]
|
|
|
|
# Docs on single flags is preceded by a comment.
|
|
# Docs on groups of flags is preceded by ###.
|
|
|
|
LLVM_FLAGS = [
|
|
"-Wall",
|
|
"-Wextra",
|
|
"-Weverything",
|
|
# Abseil does not support C++98
|
|
"-Wno-c++98-compat-pedantic",
|
|
# Turns off all implicit conversion warnings. Most are re-enabled below.
|
|
"-Wno-conversion",
|
|
"-Wno-covered-switch-default",
|
|
"-Wno-deprecated",
|
|
"-Wno-disabled-macro-expansion",
|
|
"-Wno-double-promotion",
|
|
###
|
|
# Turned off as they include valid C++ code.
|
|
"-Wno-comma",
|
|
"-Wno-extra-semi",
|
|
"-Wno-packed",
|
|
"-Wno-padded",
|
|
###
|
|
# Google style does not use unsigned integers, though STL containers
|
|
# have unsigned types.
|
|
"-Wno-sign-compare",
|
|
###
|
|
"-Wno-float-conversion",
|
|
"-Wno-float-equal",
|
|
"-Wno-format-nonliteral",
|
|
# Too aggressive: warns on Clang extensions enclosed in Clang-only
|
|
# compilation paths.
|
|
"-Wno-gcc-compat",
|
|
###
|
|
# Some internal globals are necessary. Don't do this at home.
|
|
"-Wno-global-constructors",
|
|
"-Wno-exit-time-destructors",
|
|
###
|
|
"-Wno-nested-anon-types",
|
|
"-Wno-non-modular-include-in-module",
|
|
"-Wno-old-style-cast",
|
|
# Warns on preferred usage of non-POD types such as string_view
|
|
"-Wno-range-loop-analysis",
|
|
"-Wno-reserved-id-macro",
|
|
"-Wno-shorten-64-to-32",
|
|
"-Wno-switch-enum",
|
|
"-Wno-thread-safety-negative",
|
|
"-Wno-undef",
|
|
"-Wno-unknown-warning-option",
|
|
"-Wno-unreachable-code",
|
|
# Causes warnings on include guards
|
|
"-Wno-unused-macros",
|
|
"-Wno-weak-vtables",
|
|
###
|
|
# Implicit conversion warnings turned off by -Wno-conversion
|
|
# which are re-enabled below.
|
|
"-Wbitfield-enum-conversion",
|
|
"-Wbool-conversion",
|
|
"-Wconstant-conversion",
|
|
"-Wenum-conversion",
|
|
"-Wint-conversion",
|
|
"-Wliteral-conversion",
|
|
"-Wnon-literal-null-conversion",
|
|
"-Wnull-conversion",
|
|
"-Wobjc-literal-conversion",
|
|
"-Wno-sign-conversion",
|
|
"-Wstring-conversion",
|
|
###
|
|
]
|
|
|
|
LLVM_TEST_FLAGS = [
|
|
"-Wno-c99-extensions",
|
|
"-Wno-missing-noreturn",
|
|
"-Wno-missing-prototypes",
|
|
"-Wno-missing-variable-declarations",
|
|
"-Wno-null-conversion",
|
|
"-Wno-shadow",
|
|
"-Wno-shift-sign-overflow",
|
|
"-Wno-sign-compare",
|
|
"-Wno-unused-function",
|
|
"-Wno-unused-member-function",
|
|
"-Wno-unused-parameter",
|
|
"-Wno-unused-private-field",
|
|
"-Wno-unused-template",
|
|
"-Wno-used-but-marked-unused",
|
|
"-Wno-zero-as-null-pointer-constant",
|
|
# gtest depends on this GNU extension being offered.
|
|
"-Wno-gnu-zero-variadic-macro-arguments",
|
|
]
|
|
|
|
MSVC_FLAGS = [
|
|
"/W3",
|
|
"/wd4005", # macro-redefinition
|
|
"/wd4068", # unknown pragma
|
|
"/wd4180", # qualifier applied to function type has no meaning; ignored
|
|
"/wd4244", # conversion from 'type1' to 'type2', possible loss of data
|
|
"/wd4267", # conversion from 'size_t' to 'type', possible loss of data
|
|
"/wd4800", # forcing value to bool 'true' or 'false' (performance warning)
|
|
"/DNOMINMAX", # Don't define min and max macros (windows.h)
|
|
"/DWIN32_LEAN_AND_MEAN", # Don't bloat namespace with incompatible winsock versions.
|
|
"/D_CRT_SECURE_NO_WARNINGS", # Don't warn about usage of insecure C functions.
|
|
"/D_SCL_SECURE_NO_WARNINGS", # Don't warm when the compiler encounters a function or
|
|
# variable that is marked as deprecated (same as /wd4996).
|
|
"/D_ENABLE_EXTENDED_ALIGNED_STORAGE", # Introduced in VS 2017 15.8,
|
|
# before the member type would non-conformingly have an alignment of only alignof(max_align_t).
|
|
]
|
|
|
|
MSVC_TEST_FLAGS = [
|
|
"/wd4018", # signed/unsigned mismatch
|
|
"/wd4101", # unreferenced local variable
|
|
"/wd4503", # decorated name length exceeded, name was truncated
|
|
]
|
|
|
|
# /Wall with msvc includes unhelpful warnings such as C4711, C4710, ...
|
|
ABSL_DEFAULT_COPTS = select({
|
|
"//absl:windows": MSVC_FLAGS,
|
|
"//absl:llvm_compiler": LLVM_FLAGS,
|
|
"//conditions:default": GCC_FLAGS,
|
|
})
|
|
|
|
# in absence of modules (--compiler=gcc or -c opt), cc_tests leak their copts
|
|
# to their (included header) dependencies and fail to build outside absl
|
|
ABSL_TEST_COPTS = ABSL_DEFAULT_COPTS + select({
|
|
"//absl:windows": MSVC_TEST_FLAGS,
|
|
"//absl:llvm_compiler": LLVM_TEST_FLAGS,
|
|
"//conditions:default": GCC_TEST_FLAGS,
|
|
})
|
|
|
|
ABSL_EXCEPTIONS_FLAG = select({
|
|
"//absl:windows": ["/U_HAS_EXCEPTIONS", "/D_HAS_EXCEPTIONS=1", "/EHsc"],
|
|
"//conditions:default": ["-fexceptions"],
|
|
})
|
|
|
|
ABSL_EXCEPTIONS_FLAG_LINKOPTS = select({
|
|
"//conditions:default": [],
|
|
})
|