mdebray/tvl-depot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
tvl-depot/tvix/eval/src
History
sterni 10c6cb7251 fix(tvix/eval): type check function argument with set pattern 
C++ Nix forces and typechecks the passed argument even if it is not
necessary in order to compute the return value of the function. I
discovered this when I thought our formals miscompilation might be that
we are too strict, but doesn't look like it in this case.

Change-Id: Ifb3c92592293052c489d1e3ae8c7c54e4b6b4dc6
Reviewed-on: https://cl.tvl.fyi/c/depot/+/8701
Tested-by: BuildkiteCI
Autosubmit: sterni <sternenseemann@systemli.org>
Reviewed-by: tazjin <tazjin@tvl.su>
2023-06-07 15:17:20 +00:00
..
builtins fix(tvix): don't call function eagerly in genList, map & mapAttrs 2023-05-26 22:35:39 +00:00
compiler fix(tvix/eval): type check function argument with set pattern 2023-06-07 15:17:20 +00:00
tests fix(tvix/eval): type check function argument with set pattern 2023-06-07 15:17:20 +00:00
value fix(tvix/eval): type check function argument with set pattern 2023-06-07 15:17:20 +00:00
vm fix(tvix/eval): type check function argument with set pattern 2023-06-07 15:17:20 +00:00
chunk.rs feat(tvix/eval): implement Chunk::extend method 2023-05-25 11:28:13 +00:00
errors.rs feat(tvix/eval): report all known spans on infinite recursion 2023-03-17 19:32:38 +00:00
io.rs refactor(tvix/eval): stop borrowing &mut self 2023-05-25 11:11:59 +00:00
lib.rs feat(tvix/eval): add Evaluation::strict to toggle top-level deepseq 2023-03-22 13:44:20 +00:00
nix_search_path.rs refactor(tvix/eval): use &Path instead of PathBuf 2023-05-22 09:43:33 +00:00
observer.rs chore(tvix): Generator{Request|Response} -> VM{Request|Response} 2023-03-14 09:22:22 +00:00
opcode.rs fix(tvix/eval): type check function argument with set pattern 2023-06-07 15:17:20 +00:00
pretty_ast.rs fix(tvix/eval): fix current clippy warnings 2022-12-25 18:25:06 +00:00
properties.rs refactor(tvix/eval): Don't (ab)use PartialEq for Nix equality 2022-09-18 22:03:41 +00:00
source.rs chore(tvix/eval): implement std::error::Error for tvix_eval::Error 2023-01-02 22:24:43 +00:00
spans.rs refactor(tvix/eval): implement From<Span> for LightSpan 2023-03-04 15:18:37 +00:00
systems.rs fix(tvix/eval): fix current clippy warnings 2022-12-25 18:25:06 +00:00
test_utils.rs test(tvix/eval): Add proof-of-concept test for Chunk 2022-09-18 17:55:06 +00:00
upvalues.rs fix(tvix/eval): remove impl PartialEq for Value 2022-11-04 00:30:13 +00:00
warnings.rs chore(tvix/eval): delete "useless parenthesis" warning/optimisation 2023-01-23 17:59:06 +00:00