0ecd10bf30
This provides a Nix HTTP Binary Cache interface in front of a tvix-store that's reachable via gRPC. TODOs: - remove import command, move serve up to toplevel. We have nix-copy- closure and tvix-store commands. - loop into CI. We should be able to fetch the protos as a third-party dependency. - Check if we can test nar-bridge slightly easier in an integration test. - Ensure we support connecting to unix sockets and grpc+http at least, using the same syntax as tvix-store. - Don't buffer the entire blob when rendering NAR Co-Authored-By: Connor Brewster <cbrewster@hey.com> Co-Authored-By: Márton Boros <martonboros@gmail.com> Co-Authored-By: Vo Minh Thu <noteed@gmail.com> Change-Id: I6064474e49dfe78cea67676957462d9f28658d4a Reviewed-on: https://cl.tvl.fyi/c/depot/+/9339 Tested-by: BuildkiteCI Reviewed-by: tazjin <tazjin@tvl.su>
212 lines
5.8 KiB
Go
212 lines
5.8 KiB
Go
package server
|
|
|
|
import (
|
|
"bytes"
|
|
"context"
|
|
"encoding/base64"
|
|
"encoding/hex"
|
|
"errors"
|
|
"fmt"
|
|
"io"
|
|
"io/fs"
|
|
"net/http"
|
|
"sync"
|
|
|
|
"code.tvl.fyi/tvix/nar-bridge/pkg/writer"
|
|
storev1pb "code.tvl.fyi/tvix/store/protos"
|
|
"github.com/go-chi/chi/v5"
|
|
nixhash "github.com/nix-community/go-nix/pkg/hash"
|
|
"github.com/nix-community/go-nix/pkg/nixbase32"
|
|
log "github.com/sirupsen/logrus"
|
|
)
|
|
|
|
const (
|
|
narUrl = "/nar/{narhash:^([" + nixbase32.Alphabet + "]{52})$}.nar"
|
|
)
|
|
|
|
func renderNar(
|
|
ctx context.Context,
|
|
log *log.Entry,
|
|
directoryServiceClient storev1pb.DirectoryServiceClient,
|
|
blobServiceClient storev1pb.BlobServiceClient,
|
|
narHashToPathInfoMu *sync.Mutex,
|
|
narHashToPathInfo map[string]*storev1pb.PathInfo,
|
|
w io.Writer,
|
|
narHash *nixhash.Hash,
|
|
headOnly bool,
|
|
) error {
|
|
// look in the lookup table
|
|
narHashToPathInfoMu.Lock()
|
|
pathInfo, found := narHashToPathInfo[narHash.SRIString()]
|
|
narHashToPathInfoMu.Unlock()
|
|
|
|
// if we didn't find anything, return 404.
|
|
if !found {
|
|
return fmt.Errorf("narHash not found: %w", fs.ErrNotExist)
|
|
}
|
|
|
|
// if this was only a head request, we're done.
|
|
if headOnly {
|
|
return nil
|
|
}
|
|
|
|
directories := make(map[string]*storev1pb.Directory)
|
|
|
|
// If the root node is a directory, ask the directory service for all directories
|
|
if pathInfoDirectory := pathInfo.GetNode().GetDirectory(); pathInfoDirectory != nil {
|
|
rootDirectoryDigest := pathInfoDirectory.GetDigest()
|
|
log = log.WithField("root_directory", base64.StdEncoding.EncodeToString(rootDirectoryDigest))
|
|
|
|
directoryStream, err := directoryServiceClient.Get(ctx, &storev1pb.GetDirectoryRequest{
|
|
ByWhat: &storev1pb.GetDirectoryRequest_Digest{
|
|
Digest: rootDirectoryDigest,
|
|
},
|
|
Recursive: true,
|
|
})
|
|
if err != nil {
|
|
return fmt.Errorf("unable to query directory stream: %w", err)
|
|
}
|
|
|
|
// For now, we just stream all of these locally and put them into a hashmap,
|
|
// which is used in the lookup function below.
|
|
for {
|
|
directory, err := directoryStream.Recv()
|
|
if err != nil {
|
|
if err == io.EOF {
|
|
break
|
|
}
|
|
return fmt.Errorf("unable to receive from directory stream: %w", err)
|
|
}
|
|
|
|
// calculate directory digest
|
|
// TODO: do we need to do any more validation?
|
|
directoryDgst, err := directory.Digest()
|
|
if err != nil {
|
|
return fmt.Errorf("unable to calculate directory digest: %w", err)
|
|
}
|
|
|
|
// TODO: debug level
|
|
log.WithField("directory", base64.StdEncoding.EncodeToString(directoryDgst)).Info("received directory node")
|
|
|
|
directories[hex.EncodeToString(directoryDgst)] = directory
|
|
}
|
|
|
|
}
|
|
|
|
// render the NAR file
|
|
err := writer.Export(
|
|
w,
|
|
pathInfo,
|
|
func(directoryDigest []byte) (*storev1pb.Directory, error) {
|
|
// TODO: debug level
|
|
log.WithField("directory", base64.StdEncoding.EncodeToString(directoryDigest)).Info("Get directory")
|
|
directoryRefStr := hex.EncodeToString(directoryDigest)
|
|
directory, found := directories[directoryRefStr]
|
|
if !found {
|
|
return nil, fmt.Errorf(
|
|
"directory with hash %v does not exist: %w",
|
|
directoryDigest,
|
|
fs.ErrNotExist,
|
|
)
|
|
}
|
|
|
|
return directory, nil
|
|
},
|
|
func(blobDigest []byte) (io.ReadCloser, error) {
|
|
// TODO: debug level
|
|
log.WithField("blob", base64.StdEncoding.EncodeToString(blobDigest)).Info("Get blob")
|
|
resp, err := blobServiceClient.Read(ctx, &storev1pb.ReadBlobRequest{
|
|
Digest: blobDigest,
|
|
})
|
|
if err != nil {
|
|
return nil, fmt.Errorf("unable to get blob: %w", err)
|
|
|
|
}
|
|
|
|
// TODO: spin up a goroutine producing this.
|
|
data := &bytes.Buffer{}
|
|
for {
|
|
chunk, err := resp.Recv()
|
|
if errors.Is(err, io.EOF) {
|
|
break
|
|
}
|
|
if err != nil {
|
|
return nil, fmt.Errorf("read chunk: %w", err)
|
|
}
|
|
_, err = data.Write(chunk.GetData())
|
|
if err != nil {
|
|
return nil, fmt.Errorf("buffer chunk: %w", err)
|
|
}
|
|
}
|
|
return io.NopCloser(data), nil
|
|
},
|
|
)
|
|
if err != nil {
|
|
return fmt.Errorf("unable to export nar: %w", err)
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func registerNarGet(s *Server) {
|
|
// TODO: properly compose this
|
|
s.handler.Head(narUrl, func(w http.ResponseWriter, r *http.Request) {
|
|
defer r.Body.Close()
|
|
|
|
ctx := r.Context()
|
|
|
|
// parse the narhash sent in the request URL
|
|
narHash, err := parseNarHashFromUrl(chi.URLParamFromCtx(ctx, "narhash"))
|
|
if err != nil {
|
|
log.WithError(err).WithField("url", r.URL).Error("unable to decode nar hash from url")
|
|
w.WriteHeader(http.StatusBadRequest)
|
|
_, err := w.Write([]byte("unable to decode nar hash from url"))
|
|
if err != nil {
|
|
log.WithError(err).Errorf("unable to write error message to client")
|
|
}
|
|
|
|
return
|
|
}
|
|
|
|
log := log.WithField("narhash_url", narHash.SRIString())
|
|
|
|
err = renderNar(ctx, log, s.directoryServiceClient, s.blobServiceClient, &s.narHashToPathInfoMu, s.narHashToPathInfo, w, narHash, true)
|
|
if err != nil {
|
|
log.WithError(err).Info("unable to render nar")
|
|
if errors.Is(err, fs.ErrNotExist) {
|
|
w.WriteHeader(http.StatusNotFound)
|
|
} else {
|
|
w.WriteHeader(http.StatusInternalServerError)
|
|
}
|
|
}
|
|
|
|
})
|
|
s.handler.Get(narUrl, func(w http.ResponseWriter, r *http.Request) {
|
|
defer r.Body.Close()
|
|
|
|
ctx := r.Context()
|
|
|
|
// parse the narhash sent in the request URL
|
|
narHash, err := parseNarHashFromUrl(chi.URLParamFromCtx(ctx, "narhash"))
|
|
if err != nil {
|
|
log.WithError(err).WithField("url", r.URL).Error("unable to decode nar hash from url")
|
|
w.WriteHeader(http.StatusBadRequest)
|
|
_, err := w.Write([]byte("unable to decode nar hash from url"))
|
|
if err != nil {
|
|
log.WithError(err).Errorf("unable to write error message to client")
|
|
}
|
|
|
|
return
|
|
}
|
|
|
|
log := log.WithField("narhash_url", narHash.SRIString())
|
|
|
|
err = renderNar(ctx, log, s.directoryServiceClient, s.blobServiceClient, &s.narHashToPathInfoMu, s.narHashToPathInfo, w, narHash, false)
|
|
if err != nil {
|
|
if errors.Is(err, fs.ErrNotExist) {
|
|
w.WriteHeader(http.StatusNotFound)
|
|
} else {
|
|
w.WriteHeader(http.StatusInternalServerError)
|
|
}
|
|
}
|
|
})
|
|
}
|