tvl-depot/tvix
Matthew Tromp 0b987a509f fix(tvix/eval): don't bubble up io errors from path_exists
path_exists was returning an error when certain common IO errors were
encountered. e.g. in the path "/dev/null/.", path_exists would throw
an error because the underlying call to Path::try_exists threw an
error because null isn't a directory. But if null isn't a directory,
then the path is invalid, so this should really be returning
false. That's what nix's behavior is and that's what makes sense.

The trait function isn't being changed because some other
implementers (e.g. tvix_store_io) have actual errors they can throw.

Fixes: b/411
Change-Id: I9e810e7a198bffe61365697c6d3d7e71f264c20b
Reviewed-on: https://cl.tvl.fyi/c/depot/+/12042
Tested-by: BuildkiteCI
Autosubmit: chickadee <matthewktromp@gmail.com>
Reviewed-by: aspen <root@gws.fyi>
2024-07-27 21:29:46 +00:00
..
.vscode chore(tvix): fix vscode rust-analyzer recommendation 2022-10-15 16:54:28 +00:00
boot fix(tvix/boot/tests): check nar-bridge being fully up 2024-07-23 14:47:03 +00:00
build chore(tvix): upgrade to tonic 0.12 / hyper 1.0 2024-07-21 11:01:38 +00:00
build-go chore(3p/sources): Bump channels & overlays 2024-06-08 15:20:48 +00:00
castore test(tvix/castore/dirsvc): check for a pitfall with deduplicated dirs 2024-07-25 09:52:29 +00:00
castore-go chore(3p/sources): Bump channels & overlays 2024-06-08 15:20:48 +00:00
cli fix(tvix/cli): Make :q actually quit 2024-07-27 21:19:43 +00:00
docs docs(tvix/docs): add TODO for protobuf 2024-07-23 13:24:42 +00:00
eval fix(tvix/eval): don't bubble up io errors from path_exists 2024-07-27 21:29:46 +00:00
glue refactor(tvix): move service addrs into shared clap struct 2024-07-22 13:36:08 +00:00
nar-bridge refactor(tvix): move service addrs into shared clap struct 2024-07-22 13:36:08 +00:00
nar-bridge-go chore(tvix/nar-bridge): move to nar-bridge-go 2024-05-15 21:31:36 +00:00
nix-compat refactor(tvix/nix-compat): introduce CaHash::algo_str 2024-07-27 10:53:56 +00:00
nix-lang-test-suite docs(tvix): initial notes on a possible generic Nix lang test suite 2024-01-22 14:21:19 +00:00
scripts chore(tvix): Run criterion benchmarks for the whole workspace 2023-12-20 18:04:43 +00:00
serde refactor(tvix): use composition & registry for from_addr 2024-07-18 19:19:26 +00:00
store feat(tvix/store): add redb PathInfoService 2024-07-22 18:49:04 +00:00
store-go chore(3p/sources): Bump channels & overlays 2024-06-08 15:20:48 +00:00
tools refactor(tvix/nix-compat): introduce CaHash::algo_str 2024-07-27 10:53:56 +00:00
tracing chore(tvix/tracing): switch tracing-opentelemetry from git to release 2024-07-22 13:36:08 +00:00
verify-lang-tests fix(tvix/eval): don't force lambda arg in map, mapAttrs & genList 2024-03-19 06:20:17 +00:00
website chore(tvix/nar-bridge): move to nar-bridge-go 2024-05-15 21:31:36 +00:00
.gitignore chore(tvix): add /*.sled to .gitignore 2023-09-24 17:05:48 +00:00
buildkite.yml feat(tvix/buildkite): apply a 10 minutes timeout 2024-04-13 11:44:37 +00:00
Cargo.lock feat(tvix/store): add redb PathInfoService 2024-07-22 18:49:04 +00:00
Cargo.nix feat(tvix/store): add redb PathInfoService 2024-07-22 18:49:04 +00:00
Cargo.toml feat(tvix/nar-bridge): init 2024-07-20 16:53:23 +00:00
clippy.toml chore(tvix): add missing clippy attributes & config 2023-11-05 20:28:38 +00:00
crate-hashes.json chore(tvix/tracing): switch tracing-opentelemetry from git to release 2024-07-22 13:36:08 +00:00
default.nix chore(tvix/tracing): switch tracing-opentelemetry from git to release 2024-07-22 13:36:08 +00:00
LICENSE chore(tvix): Bootstrap Tvix folder 2021-03-27 00:09:49 +00:00
logo.webp refactor(tvix): move logo to //tvix:logo 2023-09-10 13:13:14 +00:00
OWNERS chore(depot): update OWNERS files for aspen 2023-12-20 18:35:58 +00:00
README.md feat(tvix): add CI targets for checking crate features powerset 2024-06-03 16:35:51 +00:00
shell.nix refactor(tvix/store): drop FUSE multithread workaround for Darwin 2024-06-16 12:02:11 +00:00
utils.nix fix(tvix/repl): Share globals and sourcemap across evaluations 2024-07-07 15:04:26 +00:00


Tvix is a new implementation of the Nix language and package manager. See the announcement post for information about the background of this project.

Tvix is developed by TVL in our monorepo, the depot, at //tvix. Code reviews take place on Gerrit, bugs are filed in our issue tracker.

For more information about Tvix, feel free to reach out. We are interested in people who would like to help us review designs, brainstorm and describe requirements that we may not yet have considered.

Most of the discussion around development happens in our dedicated IRC channel, #tvix-dev on hackint, which is also reachable via XMPP at #tvix-dev@irc.hackint.org (sic!) and via Matrix at #tvix-dev:hackint.org.

There's also the IRC channel of the wider TVL community, less on-topic, or our mailing list.

Contributions to Tvix follow the TVL review flow and contribution guidelines.

WARNING: Tvix is not ready for use in production. None of our current APIs should be considered stable in any way.

WARNING: Any other instances of this project or repository are josh-mirrors. We do not accept code contributions or issues outside of the tooling and communication methods outlined above.

Components

This folder contains the following components:

  • //tvix/castore - subtree storage/transfer in a content-addressed fashion
  • //tvix/cli - preliminary REPL & CLI implementation for Tvix
  • //tvix/eval - an implementation of the Nix programming language
  • //tvix/nar-bridge-go - a HTTP webserver providing a Nix HTTP Binary Cache interface in front of a tvix-store
  • //tvix/nix-compat - a Rust library for compatibility with C++ Nix, features like encodings and hashing schemes and formats
  • //tvix/serde - a Rust library for using the Nix language for app configuration
  • //tvix/store - a "filesystem" linking Nix store paths and metadata with the content-addressed layer

Some additional folders with auxiliary things exist and can be explored at your leisure.

Building the CLI

The CLI can also be built with standard Rust tooling (i.e. cargo build), as long as you are in a shell with the right dependencies.

  • If you cloned the full monorepo, it can be provided by mg shell //tvix:shell.
  • If you cloned the tvix workspace only (git clone https://code.tvl.fyi/depot.git:workspace=views/tvix.git), nix-shell provides it.

If you're in the TVL monorepo, you can also run mg build //tvix/cli (or mg build from inside that folder) for a more incremental build.

Please follow the depot-wide instructions on how to get mg and use the depot tooling.

Compatibility

Important note: We only use and test Nix builds of our software against Nix 2.3. There are a variety of bugs and subtle problems in newer Nix versions which we do not have the bandwidth to address, builds in newer Nix versions may or may not work.

Rust projects, crate2nix

Some parts of Tvix are written in Rust. To simplify the dependency management on the Nix side of these builds, we use crate2nix in a single Rust workspace in //tvix to maintain the Nix build configuration.

When making changes to Cargo dependency configuration in any of the Rust projects under //tvix, be sure to run mg run //tools:crate2nix-generate in //tvix itself and commit the changes to the generated Cargo.nix file. This only applies to the full TVL checkout.

When adding/removing a Cargo feature for a crate, you will want to add it to the features power set that gets tested in CI. For each crate there's a default.nix with a mkFeaturePowerset invocation, modify the list to include/remove the feature. Note that you don't want to add "collection" features, such as fs for tvix-[ca]store or default.

License structure

All code implemented for Tvix is licensed under the GPL-3.0, with the exception of the protocol buffer definitions used for communication between services which are available under a more permissive license (MIT).

The idea behind this structure is that any direct usage of our code (e.g. linking to it, embedding the evaluator, etc.) will fall under the terms of the GPL3, but users are free to implement their own components speaking these protocols under the terms of the MIT license.