mdebray/tvl-depot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
16513 commits 5 branches 0 tags 172 MiB
Commit graph

9 commits

Author SHA1 Message Date
William Carroll
d052ab21fd fix(wpcarro/emacs): Debug bookmark-open 
also add missing dependency on project.el

Change-Id: I4648f07eb31888c9c4bd6c094543b8d8ee05225a
Reviewed-on: https://cl.tvl.fyi/c/depot/+/5287
Tested-by: BuildkiteCI
Reviewed-by: wpcarro <wpcarro@gmail.com>
Autosubmit: wpcarro <wpcarro@gmail.com>
 2022-02-14 21:54:37 +00:00
William Carroll
a8e76b24e8 refactor(wpcarro/emacs): Simplify bookmark.el 
- narrow lib's scope and update documentation
- remove unnecessary dependencies

Change-Id: I5931a5a6e571466b3334dc02e88c9c283754d263
Reviewed-on: https://cl.tvl.fyi/c/depot/+/5282
Tested-by: BuildkiteCI
Reviewed-by: wpcarro <wpcarro@gmail.com>
Autosubmit: wpcarro <wpcarro@gmail.com>
 2022-02-14 20:12:22 +00:00
William Carroll
d2052ff753 fix(wpcarro/emacs): Remove duplicate fn defn 
Prefer the version of `bookmark-install-kbds` that defines named functions,
which are useful for the `which-key` integration.

Change-Id: I2ba8d457f04cba72da24244db8cd333f44e9a606
Reviewed-on: https://cl.tvl.fyi/c/depot/+/5102
Reviewed-by: wpcarro <wpcarro@gmail.com>
Autosubmit: wpcarro <wpcarro@gmail.com>
Tested-by: BuildkiteCI
 2022-01-28 19:14:25 +00:00
William Carroll
7c558f7c53 fix(wpcarro/emacs): Redefine bookmark-install-kbd as public fn 
I originally refactored this by inlining it as a lambda function, but I was
ignoring the fact that my work machines relied on it because I have Elisp code
in google-briefcase that calls `bookmark-install-kbd`.

Change-Id: I03804250fdfdc22be1445718a061a46461eb9af8
Reviewed-on: https://cl.tvl.fyi/c/depot/+/4820
Tested-by: BuildkiteCI
Reviewed-by: wpcarro <wpcarro@gmail.com>
 2022-01-08 06:23:51 +00:00
William Carroll
4c51588850 refactor(wpcarro/emacs): Tidy-up bookmark.el 
TL;DR:
- Prefer dash.el
- Remove "current project" bookmark
- Prefer named functions instead of lambdas to (hopefully) improve `which-key`

Change-Id: I090bf372316702f313284a80af9dd076dbf270a3
Reviewed-on: https://cl.tvl.fyi/c/depot/+/4806
Tested-by: BuildkiteCI
Reviewed-by: wpcarro <wpcarro@gmail.com>
Autosubmit: wpcarro <wpcarro@gmail.com>
 2022-01-08 06:10:32 +00:00
William Carroll
7c3fef10d9 refactor(wpcarro/emacs): Prefer simpler project-find-file 
This version better interacts with google3.

Change-Id: Ib65618dbdc7d76a27479a4e0cfc52c079537dc64
Reviewed-on: https://cl.tvl.fyi/c/depot/+/4808
Tested-by: BuildkiteCI
Reviewed-by: wpcarro <wpcarro@gmail.com>
Autosubmit: wpcarro <wpcarro@gmail.com>
 2022-01-08 05:42:10 +00:00
William Carroll
286e24c76f refactor(wpcarro/emacs): Prefer tvl-depot-path reference 
Instead of homegrown constants-depot (which doesn't even exist).

Change-Id: Iabb5f5f5bbb589bb07f9fc0921d75acd9396793e
Reviewed-on: https://cl.tvl.fyi/c/depot/+/4567
Reviewed-by: wpcarro <wpcarro@gmail.com>
Autosubmit: wpcarro <wpcarro@gmail.com>
Tested-by: BuildkiteCI
 2021-12-24 17:32:24 +00:00
William Carroll
c1e381eecc refactor(wpcarro): Remove briefcase references 
TL;DR:
- prefer WPCARRO env-var to BRIEFCASE
- remove repository URLs from Emacs libraries
- prefer tvl-depot-path where possible
- reduce the scope of constants.el
- prune (some not all) stale CI configuration

Change-Id: I21e9130402502ec6fa2fc4b46753c890069be62d
Reviewed-on: https://cl.tvl.fyi/c/depot/+/4545
Tested-by: BuildkiteCI
Reviewed-by: wpcarro <wpcarro@gmail.com>
 2021-12-24 01:46:31 +00:00
Vincent Ambo
019f8fd211 subtree(users/wpcarro): docking briefcase at '24f5a642' 
git-subtree-dir: users/wpcarro
git-subtree-mainline: 464bbcb15c
git-subtree-split: 24f5a642af
Change-Id: I6105b3762b79126b3488359c95978cadb3efa789
 2021-12-14 02:15:47 +03:00