Commit graph

28 commits

Author SHA1 Message Date
Luke Granger-Brown
e20848ecf1 chore(depot): update OWNERS files for aspen
Change-Id: Id94b646a6ea035782298c421d6667530da6fc5b6
Reviewed-on: https://cl.tvl.fyi/c/depot/+/10384
Tested-by: BuildkiteCI
Owners-Override: lukegb <lukegb@tvl.fyi>
Reviewed-by: lukegb <lukegb@tvl.fyi>
2023-12-20 18:35:58 +00:00
Luke Granger-Brown
f190712b7f chore(gerrit): migrate OWNERS files to code-owners style
Change-Id: Iacc521dfdd4b4a2d5cef3920cf8189bcce35a488
2022-09-19 11:13:28 +00:00
sterni
02566cdcfb feat(nix/buildLisp): add ecl
Adds ECL as a second supported implementation, specifically a statically
linked ECL. This is interesting because we can create statically linked
binaries, but has a few drawbacks which doesn't make it generally
useful:

* Loading things is very slow: The statically linked ECL only has byte
  compilation available, so when we do load things or use the REPL it is
  significantly worse than with e. g. SBCL.

* We can't load shared objects via the FFI since ECL's dffi is not
  available when linked statically. This means that as it stands, we
  can't build a statically linked //web/panettone for example.

Since ECL is quite slow anyways, I think these drawbacks are worth it
since the biggest reason for using ECL would be to get a statically
linked binary. If we change our minds, it shouldn't be too hard to
provide ecl-static and ecl-dynamic as separate implementations.

ECL is LGPL and some libraries it uses as part of its runtime are as
well. I've outlined in the ecl-static overlay why this should be of no
concern in the context of depot even though we are statically linking.

Currently everything is building except projects that are using cffi to
load shared libaries which have gotten an appropriate
`badImplementations` entry. To get the rest building the following
changes were made:

* Anywhere a dependency on UIOP is expressed as `bundled "uiop"` we now
  use `bundled "asdf"` for all implementations except SBCL. From my
  testing, SBCL seems to be the only implementation to support using
  `(require 'uiop)` to only load the UIOP package. Where both a
  dependency on ASDF and UIOP exists, we just delete the UIOP one.
  `(require 'asdf)` always causes UIOP to be available.

* Where appropriate only conditionally compile SBCL-specific code and
  if any build the corresponding files for ECL.

* //lisp/klatre: Use the standard condition parse-error for all
  implementations except SBCL in try-parse-integer.

* //3p/lisp/ironclad: disable SBCL assembly optimization hack for all
  other platforms as it may interfere with compilation.

* //3p/lisp/trivial-mimes: prevent call to asdf function by substituting
  it out of the source since it always errors out in ECL and we hardcode
  the correct path elsewhere anyways.

As it stands ECL still suffers from a very weird problem which happens
when compiling postmodern and moptilities:
https://gitlab.com/embeddable-common-lisp/ecl/-/issues/651

Change-Id: I0285924f92ac154126b4c42145073c3fb33702ed
Reviewed-on: https://cl.tvl.fyi/c/depot/+/3297
Tested-by: BuildkiteCI
Reviewed-by: tazjin <mail@tazj.in>
Reviewed-by: eta <tvl@eta.st>
2021-08-24 22:00:15 +00:00
sterni
5711b4ee16 fix(lisp/klatre): declare ignore unused variables
CCL refuses to compile anything with undeclared ignored variables, so we
need to be more verbose here.

Change-Id: I9bf32e0bc303716d3cd6fe7b525d1434062d69eb
Reviewed-on: https://cl.tvl.fyi/c/depot/+/3348
Tested-by: BuildkiteCI
Reviewed-by: grfn <grfn@gws.fyi>
2021-08-14 14:46:36 +00:00
sterni
17a75dfc42 fix(lisp/klatre): fix inline declaration for chunk-list functions
Found this typo because CCL is really particular about everything
related to declare.

Change-Id: I6d4615c1df7c9d45722e85fa82ebdd094273205d
Reviewed-on: https://cl.tvl.fyi/c/depot/+/3347
Tested-by: BuildkiteCI
Reviewed-by: grfn <grfn@gws.fyi>
2021-08-14 14:46:32 +00:00
Vincent Ambo
44a9a09ecd chore(klatre): add grfn to owners
Change-Id: Ied733a0d88568bc9ac432ea7960fa92f8b59a99a
Reviewed-on: https://cl.tvl.fyi/c/depot/+/3165
Tested-by: BuildkiteCI
Reviewed-by: sterni <sternenseemann@systemli.org>
2021-05-29 19:14:54 +00:00
sterni
f60d174591 feat(klatre): expose utility to format dot time offset
Turns out this is an annoying thingy you sometimes to implement
independently from formatting an entire timestamp, so we expose it for
reuse.

Change-Id: I11de2823eb03849ea78fc79e2f546e413882930f
Reviewed-on: https://cl.tvl.fyi/c/depot/+/3163
Tested-by: BuildkiteCI
Reviewed-by: grfn <grfn@gws.fyi>
Reviewed-by: tazjin <mail@tazj.in>
2021-05-29 19:13:11 +00:00
sterni
71946b84b8 feat(klatre): support offsets in format-dottime
Instead of bothering with local-time's feature rich timezone support we
just pass the offset as an integer and render it ourselves.

Change-Id: I1df2d02153e3ef21ae3b2871ad6ef57d0f6eff86
Reviewed-on: https://cl.tvl.fyi/c/depot/+/2423
Tested-by: BuildkiteCI
Reviewed-by: tazjin <mail@tazj.in>
Reviewed-by: glittershark <grfn@gws.fyi>
2021-01-25 20:09:21 +00:00
Griffin Smith
94796399e2 feat(web/panettone): Display issue history
Display the history of an issue (which currently is just opening and
closing) inline with the issue's comments on the issue show page

Change-Id: Id167bceef765cb4c24e86983d1dcd6624d0e5956
Reviewed-on: https://cl.tvl.fyi/c/depot/+/1497
Tested-by: BuildkiteCI
Reviewed-by: tazjin <mail@tazj.in>
2020-07-31 02:05:49 +00:00
Griffin Smith
974c2e05af feat(web/panettone): Read config from env
Read the port and data directory from environment variables, in
preparation for deploying as a systemd unit to Whitby

Change-Id: I066dced7b7926b6bdc77132d13a4da6c886b20e8
Reviewed-on: https://cl.tvl.fyi/c/depot/+/1338
Tested-by: BuildkiteCI
Reviewed-by: tazjin <mail@tazj.in>
2020-07-23 22:09:15 +00:00
Griffin Smith
fa01f515e2 feat(web/panettone): The start of a very simple issue tracker
Initial commit for Panettone, a very simple issue tracker for TVL. In
its current state this launches a web server with authenticates with our
ldap server, and supports listing and creating issues via static html
pages and simple forms.

We've been needing an issue tracker for a while now, but none of the
options out there seem very good - or there are some good ones, but
they're AGPL licensed and we don't want to deal with them. Rather than
muck around with Trac or Bugzilla, we've decided to write our own.

Change-Id: I704f0996d15199329bbd5450f3d959046bf13973
Reviewed-on: https://cl.tvl.fyi/c/depot/+/1337
Tested-by: BuildkiteCI
Reviewed-by: tazjin <mail@tazj.in>
2020-07-23 19:47:38 +00:00
Griffin Smith
f591c32dfb feat(klatre): add dottime-format function
Add a function to klatre format a timestamp using dottime

Change-Id: I24d8d91f49f352b606f44834f7229ab55b55afa0
Reviewed-on: https://cl.tvl.fyi/c/depot/+/1344
Tested-by: BuildkiteCI
Reviewed-by: tazjin <mail@tazj.in>
Reviewed-by: kanepyork <rikingcoding@gmail.com>
2020-07-23 00:08:29 +00:00
Griffin Smith
d60c639162 feat(lisp/klatre): Add klatre, a grab-bag lisp util package
Add Klatre, a grab-bag common lisp utility package, including
definitions for `comment`, `posp`, `chunk-list`, and `mapconcat`.

The name traces its lineage back to Abseil, a similar grab-bag utility
library for C++ - abseiling is what you do to go down a route after
you're done climbing it, and klatre is norwegian for "to climb"

Change-Id: I5efd91d8af827883679ce1a2eed3229b28e082ac
Reviewed-on: https://cl.tvl.fyi/c/depot/+/1346
Tested-by: BuildkiteCI
Reviewed-by: tazjin <mail@tazj.in>
2020-07-23 00:08:29 +00:00
Vincent Ambo
4bbbb58cb5 chore: Rename pkgs->depot in all Nix file headers 2020-02-21 13:54:53 +00:00
Vincent Ambo
253a166bbc refactor(lisp/dns): Return dns-answer from query functions 2020-01-27 02:10:39 +00:00
Vincent Ambo
ca1217655d docs(lisp/dns): Add initial README file 2020-01-27 00:49:34 +00:00
Vincent Ambo
90dd824606 feat(lisp/dns): Support CNAME & NS record RDATAs 2020-01-27 00:47:53 +00:00
Vincent Ambo
a8c9058a58 refactor(lisp/dns): Refactor structure of lookup-generic calls 2020-01-27 00:15:58 +00:00
Vincent Ambo
479510005b chore(lisp/dns): Remove unused dependencies 2020-01-26 21:06:59 +00:00
Vincent Ambo
3f9546197e feat(lisp/dns): Export struct fields 2020-01-26 20:34:03 +00:00
Vincent Ambo
4c109f66b6 feat(lisp/dns): Introduce enum for DNS types & decode RDATA
Adds some of the most common DNS types in the enum (others TBD), and
starts decoding RDATA for TXT and A.
2020-01-26 20:29:30 +00:00
Vincent Ambo
72abb43577 chore(lisp/dns): Add 'message.lisp' to build instructions 2020-01-26 20:00:22 +00:00
Vincent Ambo
8f805a29d1 feat(lisp/dns): Use new DNS deserialiser in dns:lookup-generic
This enables arbitrary DNS lookups (with the caveat that RRDATAs are
currently not deserialised into a record-type-specific format).

An error condition has been defined for error-responses from the HTTP
server which provides interactive restarts for attempting a new call
with different parameters.
2020-01-26 19:58:52 +00:00
Vincent Ambo
1440fc0dd7 feat(lisp/dns): Implement qname compression parsing
Implements support for the compresion scheme used in binary DNS
messages.

This makes it possible to decode messages entirely, but not yet
actually resolve the labels to their "real" values.

All qnames are stored with file-offsets pointing at the position at
which their reading started, which enables the implementation of a
function to resolve pointers internally.
2020-01-26 18:27:35 +00:00
Vincent Ambo
cefb60f20c refactor(lisp/dns): Introduce structured QNAME representation
Adds a struct that represents QNAMEs, tracks the stream offset at
which the QNAME parsing began and makes it possible to resolve
pointers inside of the QNAME.

Note that resolving pointers needs to happen *after* the call to
lisp-binary currently. It might be possible to implement this inside
of lisp-binary in the future by switching on the top two bits of the
qname field, but since this is happening *inside* of a reader function
I'm not currently sure how to implement it.
2020-01-26 02:51:29 +00:00
Vincent Ambo
7ef14db936 feat(lisp/dns): Check in initial DNS message implementation
This uses lisp-binary to define serialisation types for the DNS
messages defined by RFC 1035.

Currently the compression scheme used for QNAMEs is not supported,
hence deserialisation of even simple records fails after the header
and question sections are read.
2020-01-26 01:20:45 +00:00
Vincent Ambo
09621f5371 refactor(lisp/dns): Split package into multiple files
Adds a package definition file and moves the current client into
client.lisp

Note that the client is not working at all at this commit as this is a
work-in-progress snapshot.
2020-01-26 01:20:45 +00:00
Vincent Ambo
e50c362244 feat(lisp/dns): Check in very early DNS-over-HTTPS client
This includes very barebones support for querying TXT and MX records
right now. The returned structure is not turned into a more convenient
format and error handling is, well, NIL.
2020-01-22 18:04:26 +00:00