Commit graph

15566 commits

Author SHA1 Message Date
William Carroll
6961948da5 Allow Elisp linting to run concurrently with Emacs init
No reason for init-emacs to block lint-elisp.
2020-09-01 16:50:12 +01:00
William Carroll
baf08416cf Apply checkdoc fixes to set.el
While I don't agree with what checkdoc is advising here, I'd rather not fight
it.
2020-09-01 16:27:42 +01:00
William Carroll
75a9a156a0 Redefine >> macro as >-> in >.el
I created a strangely named Elisp module, >.el, just to appease the CI gods. My
gut tells me that this is a desperate idea and fails the smell test. I'm pretty
eager to pass the linting phase of my Elisp CI, however, and I can always revert
this.
2020-09-01 16:26:39 +01:00
William Carroll
718899c629 More Elisp linting
In order for this to scale, I need to solve two things:
1. Ad-hoc ignore fill-column rules for URLs and other exceptions.
2. Run Elisp flychecker without evaluating my Elisp code and firing its
   side-effects.
2020-09-01 14:00:42 +01:00
William Carroll
3b2fffe954 Consume utils.builder in home.nix
Consuming my newly defined Nix utilities.
2020-09-01 12:17:44 +01:00
William Carroll
3fb9324c82 Delete comment monzo_ynab deployment
I haven't used this since I wrote it months ago...
2020-09-01 12:17:16 +01:00
William Carroll
a076027945 Define {builder,fs}.nix for utils.nix
Re-export everything from utils.nix.
2020-09-01 12:16:34 +01:00
William Carroll
fb5ec068dd More Elisp linting
This should cover most of the remaining linting errors. After this, I expect
fewer than ten linting errors.
2020-09-01 10:17:43 +01:00
Griffin Smith
adebfbbf24 feat(tvix): Print "Tvix" in the version string
Rather than printing "Nix" in the version string, print "Tvix". This is
cosmetically nice, but also is very useful when making sure I actually
have installed tvix on a system successfully.

Change-Id: Idd1a9954bd66509327f52b7457cfba2f090ab30c
Reviewed-on: https://cl.tvl.fyi/c/depot/+/1924
Reviewed-by: kanepyork <rikingcoding@gmail.com>
Tested-by: BuildkiteCI
2020-09-01 03:30:12 +00:00
Eelco Dolstra
785cb3a754 refactor(tvix): getEnv(): Return std::optional
This allows distinguishing between an empty value and no value.

Patch ported from upstream at
ba87b08f85

Change-Id: I061cc8e16b1a7a0341adfc3b0edca1c0c51d5c97
Reviewed-on: https://cl.tvl.fyi/c/depot/+/1884
Tested-by: BuildkiteCI
Reviewed-by: kanepyork <rikingcoding@gmail.com>
2020-09-01 02:21:53 +00:00
Griffin Smith
c5f3b12f04 feat(tvix): Support systemd socket activation
When the nix daemon starts up, first check (using sd_listen_fds) whether
we have been systemd socket-activated. If so, instead of passing the nix
daemon socket path to grpc, start a manual accept(2) loop, passing the
client file descriptors to grpc via AddInsecureChannelFromFd. There's an
open grpc issue at https://github.com/grpc/grpc/issues/19133 for
building support into grpc to do this automatically, but as of right now
this appears to be the only way to make this happen.

Making this happen, by the way, was a bit of a journey - at one point I
attempted to ServerBuilder's experimental AddExternalConnectionAcceptor
API, and that didn't work either - it appears that the final missing
piece to getting this working was explicitly fcntl(2)ing the client file
descriptors to set O_NONBLOCK before passing them into gRPC. With that
set, this all works inside of the test vm.

Fixes: b/56
Change-Id: I5d2ab2b5b02eb570249b30a9674e115c61b0ab0e
Reviewed-on: https://cl.tvl.fyi/c/depot/+/1882
Reviewed-by: kanepyork <rikingcoding@gmail.com>
Reviewed-by: tazjin <mail@tazj.in>
Tested-by: BuildkiteCI
2020-09-01 01:07:11 +00:00
Griffin Smith
e472aa016e feat(tvix): Expose depot in the test vm
Expose depot to the test vm via NIX_PATH, so we can test the build of
depot packages from inside the test vm.

Change-Id: I26314634895ab1339f5715c0b0b261028eefdaa3
Reviewed-on: https://cl.tvl.fyi/c/depot/+/1923
Tested-by: BuildkiteCI
Reviewed-by: tazjin <mail@tazj.in>
2020-09-01 01:07:11 +00:00
Griffin Smith
912268ed5e feat(gs/system): Add nixbuild.net as remote builder
Change-Id: I3b071cc91af5ee896e88c10d6594333ff4eddf77
Reviewed-on: https://cl.tvl.fyi/c/depot/+/1922
Tested-by: BuildkiteCI
Reviewed-by: glittershark <grfn@gws.fyi>
2020-09-01 01:07:11 +00:00
Griffin Smith
7a83b8fe40 fix(ops/monorepo-gerrit): Escape escape characters with more escape characters
Escape!

Change-Id: Idec7d17feda13ccf1ec03c41106ec6ed581d9e47
Reviewed-on: https://cl.tvl.fyi/c/depot/+/1901
Tested-by: BuildkiteCI
Reviewed-by: tazjin <mail@tazj.in>
2020-08-31 23:21:45 +00:00
Vincent Ambo
2afa22e512 feat(whitby): Double the number of Buildkite agents
Allow 16 things to happen in parallel, which is useful now that the
CI granularity is on a per-target level.

Change-Id: Ie65dd119ea0666618fbb249613e70a68276db834
Reviewed-on: https://cl.tvl.fyi/c/depot/+/1902
Reviewed-by: glittershark <grfn@gws.fyi>
Tested-by: BuildkiteCI
2020-08-31 23:21:16 +00:00
Vincent Ambo
fcb014e43d chore(glittershark/system): Include chupacabraSystem in CI builds
Change-Id: Ic8a63f76a0b19f6b1f9ab836d1418849cce06aa0
Reviewed-on: https://cl.tvl.fyi/c/depot/+/1895
Tested-by: BuildkiteCI
Reviewed-by: glittershark <grfn@gws.fyi>
2020-08-31 23:14:11 +00:00
Vincent Ambo
77a47fa85c chore(tazjin/nixos): Include camdenSystem and frogSystem in CI
Change-Id: I83c99a853e7a14a41ba87fed9d7988d4a2556920
Reviewed-on: https://cl.tvl.fyi/c/depot/+/1894
Tested-by: BuildkiteCI
Reviewed-by: tazjin <mail@tazj.in>
2020-08-31 23:14:11 +00:00
Vincent Ambo
9c482d6238 feat(ci): Add subtarget support for builds
We have naturally evolved a distinction between logical and physical
targets.

Physical targets are those which correspond directly to a tree
location on disk and can be built with `-A path.to.files`, while
logical targets are those that are exported from within an expression
but do not have a corresponding file on disk.

This change adds support for exporting logical targets from any tree
location by adding a `meta.targets` attribute containing keys into
itself, which will be consumed by the CI target gathering logic and
included in the generated pipeline.

Note that the labels for subtargets are syntactically different to
emphasise that they do not correspond to a file location. For example,
this change enables 'ops.nixos.whitbySystem' as a subtarget, which is
labeled in CI as `ops/nixos:whitbySystem`.

Change-Id: Ied09647a62c2ba98e3914548e3742ad422c63ecf
Reviewed-on: https://cl.tvl.fyi/c/depot/+/1893
Tested-by: BuildkiteCI
Reviewed-by: glittershark <grfn@gws.fyi>
2020-08-31 23:14:11 +00:00
Vincent Ambo
61d2d2d503 feat(ops/pipelines): Dynamically generate CI pipeline from targets
Create the pipeline by outputting a file that contains nix-build
invocations for each target's *derivation path*.

Each invocation has a generated Nix expression passed to it with `-E`
which fetches the correct target from the tree while correctly
handling targets with strange characters (such as in Go-packages).

This makes it possible to run target-level granular pipelines. We're
getting somewhere!

Change-Id: Ia6946e389dafd1d4926130bb8891446d6e17133b
Reviewed-on: https://cl.tvl.fyi/c/depot/+/1855
Tested-by: BuildkiteCI
Reviewed-by: glittershark <grfn@gws.fyi>
Reviewed-by: lukegb <lukegb@tvl.fyi>
2020-08-31 23:14:11 +00:00
Griffin Smith
21690c644b fix(panettone): Automatically reconnect to ldap
Wrap all ldap access in a macro that automatically reconnects and
retries operations that fail due to a connection error, to handle the
case where the ldap server restarts while we still have an open
connection.

Fixes: #44
Change-Id: I4859cf509106e480f97fed17e7f08e0eea909352
Reviewed-on: https://cl.tvl.fyi/c/depot/+/1871
Tested-by: BuildkiteCI
Reviewed-by: eta <eta@theta.eu.org>
2020-08-31 23:03:45 +00:00
Griffin Smith
2bc564bd0d chore(tvix): Add riking to owners
Change-Id: Icefafe6967cb83a43c9e417a29ce8cc97fb3432d
Reviewed-on: https://cl.tvl.fyi/c/depot/+/1892
Tested-by: BuildkiteCI
Reviewed-by: kanepyork <rikingcoding@gmail.com>
Reviewed-by: tazjin <mail@tazj.in>
2020-08-31 23:01:44 +00:00
William Carroll
a638e15c0d Lint string, macros.el
More of the same type of linting... basically preferring `namespace-` instead of
`namespace/`.
2020-08-31 23:33:25 +01:00
William Carroll
158f810981 Delete bills.el
Another cold, stale Elisp module.
2020-08-31 23:28:22 +01:00
William Carroll
644e01eb21 Fix fill-column errors
- removing stale comments
- dropping stale KBDs
2020-08-31 17:20:04 +01:00
William Carroll
ff8277625f Lint prelude.el
This was a doozey because I use it everywhere. Is there a better way to globally
rename things? Aye aye aye... computers, man!
2020-08-31 17:08:56 +01:00
Griffin Smith
2279419ede refactor(tvix): Drop meson.build files
These are unused, and I'm not sure they ever actually worked.

Change-Id: I6bb6b4257b7815932581ded7929437dba80961c9
Reviewed-on: https://cl.tvl.fyi/c/depot/+/1885
Tested-by: BuildkiteCI
Reviewed-by: kanepyork <rikingcoding@gmail.com>
Reviewed-by: tazjin <mail@tazj.in>
2020-08-31 15:38:16 +00:00
Griffin Smith
a9ca270710 feat(gs/emacs): Add binding for slack-all-threads
Change-Id: I5509be5c8ea10e1bb5f8aad890ecc16716c3f1fa
Reviewed-on: https://cl.tvl.fyi/c/depot/+/1896
Reviewed-by: glittershark <grfn@gws.fyi>
Tested-by: BuildkiteCI
2020-08-31 15:35:22 +00:00
William Carroll
5d3bb0b7ea Additional linting
Running `M-x checkdoc` on some of the modules that passed the package-lint but
failed additional lints.
2020-08-31 16:07:11 +01:00
William Carroll
2a51698672 Lint more Elisp files, delete others
I may regret this, but I delete Ocaml and ReasonML modules; I can alway restore
them thanks to Git.

Added more ceremony to other modules to appease the linting gods.
2020-08-31 15:57:34 +01:00
William Carroll
1e253a756b Delete entr.el
As I strive to lean down my Emacs configuration modules like this must go.
2020-08-31 15:49:27 +01:00
William Carroll
b475f7166e Delete unused .nix expressions
These were never more than scratch buffers that I used when I was feeling around
in the dark trying to learn Nix.
2020-08-31 15:48:25 +01:00
William Carroll
d6cf2fe462 Remove (require 'kaomoji) from init.el
I should've done this when I deleted kaomoji.el because this broke my
"Initialize Emacs" step.
2020-08-31 15:47:41 +01:00
William Carroll
69a14dd37f Delete unused Elisp modules
It is striking how much Elisp I wrote after switching to EXWM... I think I'm
finally coming down from that high.
2020-08-31 15:06:49 +01:00
William Carroll
a35f723d92 Lint maybe.el
This change had rippling implications.
2020-08-31 14:59:48 +01:00
William Carroll
1c87082648 Lint pulse-audio.el
Next commit will contain all of the remaining linting...
2020-08-31 14:53:34 +01:00
William Carroll
59881551a7 Delete pushover.el
Again: another strong cup of coffee bred overzeal.
2020-08-31 14:51:57 +01:00
William Carroll
1ea996b676 Lint random.el
Usual lints... fixes usage in tree.el.
2020-08-31 14:51:27 +01:00
William Carroll
5b50e34e12 Delete ghost module, scheduler.el
Must've had a particularly strong cup of coffee the day I decided to attempt to
write this.
2020-08-31 14:49:45 +01:00
William Carroll
c78b2339f9 Lint region.el
Business as usual...
2020-08-31 14:49:45 +01:00
William Carroll
8d02e5a5ef Lint timestring.el
Sidenote: I have *no* idea when or why I wrote this... sleep-writing Elisp
2020-08-31 14:46:47 +01:00
William Carroll
2844c1ffbd Lint tree.el
- add Version, URL, Package-Requires sections
- prefer `tree-` prefer to `tree/`
2020-08-31 14:44:53 +01:00
William Carroll
1aa4b3a547 Lint tuple.el
- add Version, URL, Package-Requires sections
- prefer `tuple-` prefix to `tuple/`
2020-08-31 14:43:50 +01:00
William Carroll
9661a3ff36 Lint vector.el
- add Version, URL, Package-Requires sections
- prefer `vector-` prefix to `vector/`
2020-08-31 14:42:06 +01:00
William Carroll
91083d1ac5 Lint vterm-mgt.el
- Add Version, URL, Package-Requires sections
2020-08-31 14:42:04 +01:00
William Carroll
b09980f681 Lint window.el
- remove "Emacs" from description
- add Version, URL, Package-Requires sections
- prefer `window-` prefix to `window/`
2020-08-31 14:42:03 +01:00
William Carroll
84d6fb8f39 Lint window-manager.el
- change `exwm/` prefixes to `window-manager-`
- add Version, URL, Package-Requires sections
- move `pkill` into wpc-misc.el
- unify `window-manager,` `exwm` competing prefixes
2020-08-31 14:42:03 +01:00
William Carroll
a2d45c8db7 Lint wpc-clojure.el
- change clojure.el to wpc-clojure.el
- delete stale, commented code
- add Configuration header
- add Version, URL, Package-Requires sections
2020-08-31 14:28:22 +01:00
William Carroll
28cdbb18b6 Lint wpc-company.el
- change company.el to wpc-company.el
- add Version, URL, Package-Requires sections
2020-08-31 14:27:06 +01:00
William Carroll
8d9e4f4865 Lint wpc-dired.el
- change dired.el to wpc-dired.el
- add Version, URL, Package-Requires sections
2020-08-31 14:26:24 +01:00
William Carroll
85a0cddf8b Lint wpc-elixir.el
- Add Version, URL, Package-Requires sections
2020-08-31 14:25:44 +01:00