mdebray/tvl-depot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

feat(storage): Add generic support for content-types

Browse source 
When serving a manifest, it is important to set the content-type
correctly (otherwise pulling an image is likely to give a cryptic
error message, "Error response from daemon: missing signature key").

This makes sure that we set the content-type properly for both
manifests and layers.
This commit is contained in:
Jerome Petazzoni 2021-04-13 16:26:04 +02:00 committed by Vincent Ambo
parent 954953d8ba
commit f172107ef1
1 changed files with 10 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
tools/nixery/main.go
View file

@ -195,6 +195,16 @@ func (h *registryHandler) serveManifestTag(w http.ResponseWriter, r *http.Reques
// serveBlob serves a blob from storage by digest
func (h *registryHandler) serveBlob(w http.ResponseWriter, r *http.Request, blobType, digest string) {
storage := h.state.Storage
switch blobType {
case "manifests":
// It is necessary to set the correct content-type when serving manifests.
// Otherwise, you may get the following mysterious error message when pulling:
// "Error response from daemon: missing signature key"
w.Header().Add("Content-Type", mf.ManifestType)
case "blobs":
// It is not strictly necessary to set this content-type, but since we're here...
w.Header().Add("Content-Type", mf.LayerType)
}
err := storage.Serve(digest, r, w)
if err != nil {
log.WithError(err).WithFields(log.Fields{