feat(tvix/eval): nonrecursive nix_cmp_ordering(), fixes b/339

Browse source

This commit rewrites Value::nix_cmp_ordering() into an equivalent
nonrecursive form.  Except for calls to Thunk::force(), the new form
no longer uses generators, and is async only because of the fact
that it calls Thunk::force().

I originally believed that this commit would make evaluation faster.
In fact it is slightly slower.  I believe this is due to the added
vec![] allocation.  I am investigating.

Prev-Nixpkgs-Benchmark: {"attrpath":"pkgsCross.aarch64-multiplatform.hello.outPath","peak-kbytes":"460048","system-seconds":"0.68","user-seconds":"5.73"}
This-Nixpkgs-Benchmark: {"attrpath":"pkgsCross.aarch64-multiplatform.hello.outPath","peak-kbytes":"460224","system-seconds":"0.67","user-seconds":"5.84"}
Change-Id: Ic627bc220d9c5aa3c5e68b9b8bf199837cd55af5
Reviewed-on: https://cl.tvl.fyi/c/depot/+/10212
Reviewed-by: tazjin <tazjin@tvl.su>
Tested-by: BuildkiteCI
Autosubmit: Adam Joseph <adam@westernsemico.com>

...

This commit is contained in:

Adam Joseph 2023-12-08 02:46:38 -08:00 • committed by clbot

parent 8a40f75c2d

commit edbd5055a1

7 changed files with 75 additions and 44 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

0

tvix/eval/src/tests/tvix_tests/notyetpassing/eval-okay-list-comparison.exp → tvix/eval/src/tests/tvix_tests/eval-okay-list-comparison.exp

Unescape Escape View file

0

tvix/eval/src/tests/tvix_tests/notyetpassing/eval-okay-list-comparison.nix → tvix/eval/src/tests/tvix_tests/eval-okay-list-comparison.nix

Unescape Escape View file