refactor(ops/pipelines): Move ⚓ into postBuildSteps
There is no need for this step to be part of the static pipeline (it should not run if the build fails anyways). Change-Id: I71400a452d6f8f4708d146b346eaffda5da2f766 Reviewed-on: https://cl.tvl.fyi/c/depot/+/5049 Tested-by: BuildkiteCI Autosubmit: tazjin <tazjin@tvl.su> Reviewed-by: ezemtsov <eugene.zemtsov@gmail.com>
This commit is contained in:
parent
cb107c4fbe
commit
ec2b98d131
2 changed files with 18 additions and 18 deletions
|
@ -19,6 +19,24 @@ let
|
|||
parentTargetMap = if (externalArgs ? parentTargetMap)
|
||||
then builtins.fromJSON (builtins.readFile externalArgs.parentTargetMap)
|
||||
else {};
|
||||
|
||||
postBuildSteps = [
|
||||
# After successful builds, create a gcroot for builds on canon.
|
||||
#
|
||||
# This anchors *most* of the depot, in practice it's unimportant
|
||||
# if there is a build race and we get +-1 of the targets.
|
||||
#
|
||||
# Unfortunately this requires a third evaluation of the graph, but
|
||||
# since it happens after :duck: it should not affect the timing of
|
||||
# status reporting back to Gerrit.
|
||||
{
|
||||
label = ":anchor:";
|
||||
branches = "refs/heads/canon";
|
||||
command = ''
|
||||
nix-build -A ci.gcroot --out-link /nix/var/nix/gcroots/depot/canon
|
||||
'';
|
||||
}
|
||||
];
|
||||
};
|
||||
|
||||
drvmap = depot.nix.buildkite.mkDrvmap depot.ci.targets;
|
||||
|
|
|
@ -109,21 +109,3 @@ steps:
|
|||
find ./pipeline -name 'post-chunk-*.json' | tac | while read chunk; do
|
||||
buildkite-agent pipeline upload $$chunk
|
||||
done
|
||||
|
||||
# After duck, on success, create a gcroot if the build branch is
|
||||
# canon.
|
||||
#
|
||||
# We care that this anchors *most* of the depot, in practice it's
|
||||
# unimportant if there is a build race and we get +-1 of the
|
||||
# targets.
|
||||
#
|
||||
# Unfortunately this requires a third evaluation of the graph, but
|
||||
# since it happens after :duck: it should not affect the timing of
|
||||
# status reporting back to Gerrit.
|
||||
- label: ":anchor:"
|
||||
branches: "refs/heads/canon"
|
||||
command: |
|
||||
nix-build -A ci.gcroot --out-link /nix/var/nix/gcroots/depot/canon
|
||||
depends_on:
|
||||
- step: ":duck:"
|
||||
allow_failure: false
|
||||
|
|
Loading…
Reference in a new issue