mdebray/tvl-depot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(wpcarro/slx): Fix LTE/GTE parsing error

Browse source 
Fix: `i += 2`. Welp!
Change-Id: I06061f0c5bb5283c8b85bd3f5a6e52e2eb59d4f5
Reviewed-on: https://cl.tvl.fyi/c/depot/+/7885
Tested-by: BuildkiteCI
Reviewed-by: wpcarro <wpcarro@gmail.com>
Autosubmit: wpcarro <wpcarro@gmail.com>
This commit is contained in:
William Carroll 2023-01-20 15:47:14 -08:00 committed by clbot
parent 7f37cfb184
commit e20c0d2fbf
2 changed files with 8 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
users/wpcarro/slx.js/index.js
View file

@ -166,7 +166,7 @@ function tokenize(x) {
}
if (x[i] === '<' && i + 1 < x.length && x[i + 1] === '=') {
result.push(['COMPARE', 'LTE']);
i += 1;
i += 2;
continue;
}
if (x[i] === '<') {
@ -176,7 +176,7 @@ function tokenize(x) {
}
if (x[i] === '>' && i + i < x.length && x[i + 1] === '=') {
result.push(['COMPARE', 'GTE']);
i += 1;
i += 2;
continue;
}
if (x[i] === '>') {

8
users/wpcarro/slx.js/tests.js
View file

@ -15,7 +15,11 @@ const cfg = {
dateKey: 'birthday',
};
const tests = [
['support numeric comparisons', 'age=83', xs, cfg, [john]],
['support EQ', 'age=83', xs, cfg, [john]],
['supports LT', 'age<83', xs, cfg, [graham]],
['supports LTE', 'age<=83', xs, cfg, [john, graham]],
['supports GT', 'age>48', xs, cfg, [john]],
['supports GTE', 'age>=48', xs, cfg, [john, graham]],
['supports grouping (1)', 'last:/^C/ (age=83 OR age=48)', xs, cfg, [john, graham]],
['supports grouping (2)', '(age=83)', xs, cfg, [john]],
['supports grouping (3)', '(age=83 OR age=48)', xs, cfg, [john, graham]],
@ -44,7 +48,7 @@ class App extends React.Component {
const [label, query, xs, cfg, expected] = test;
const actual = select(query, xs, cfg);
return (
<tr>
<tr style={{backgroundColor: equal(actual, expected) ? null : 'red'}}>
<td>{equal(actual, expected) ? "pass" : "fail"}</td>
<td>{label}</td>
<td>select("{query}", {JSON.stringify(xs)}, {JSON.stringify(cfg)})</td>