mdebray/tvl-depot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

chore(tvix/eval): notes on coercion and contexts

Browse source 
We make a case for adding a `reject_context` `CoercionKind` here.
It does happen during concatenation actually for path concats.

Change-Id: I0c196aad917550b9bcd0896cd2127a94f8181ffb
Reviewed-on: https://cl.tvl.fyi/c/depot/+/10444
Tested-by: BuildkiteCI
Reviewed-by: tazjin <tazjin@tvl.su>
Autosubmit: raitobezarius <tvl@lahfa.xyz>
This commit is contained in:
Ryan Lahfa 2023-12-26 04:49:31 +01:00 committed by clbot
parent 743c362049
commit e15b6580cc
1 changed files with 3 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
tvix/eval/src/vm/mod.rs
View file

@ -1232,6 +1232,9 @@ async fn add_values(co: GenCo, a: Value, b: Value) -> Result<Value, ErrorKind> {
// contain any string context, the resulting error of such a // contain any string context, the resulting error of such a
// case can not be replicated by us. // case can not be replicated by us.
import_paths: false, import_paths: false,
// FIXME(raitobezarius): per https://b.tvl.fyi/issues/364, this is a usecase
// for having a `reject_context: true` option here. This didn't occur yet in
// nixpkgs during my evaluations, therefore, I skipped it.
}, },
) )
.await .await