mdebray/tvl-depot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

feat(besadii): Temporarily add Code-Review labels on CLs

Browse source 
Besadii already adds 'Verified'-labels, which are used to signal CI
status on CLs, however we don't actually use these labels (yet) which
also means that they are not displayed in the Gerrit UI.

This change temporarily introduces the Code-Review label *in
addition* (with the same values as Verified), providing a build status
signal on the CL but without being required for submission.

Change-Id: I2c3a37c59aceb426815ad4e400c80ab85be482dd
Reviewed-on: https://cl.tvl.fyi/c/depot/+/781
Tested-by: BuildkiteCI
Reviewed-by: ericvolp12 <ericvolp12@gmail.com>
Reviewed-by: lukegb <lukegb@tvl.fyi>
This commit is contained in:
Vincent Ambo 2020-06-29 18:54:29 +01:00 committed by tazjin
parent 40d0792405
commit d3f9cb0ec3
1 changed files with 7 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
ops/besadii/main.go2
View file

@ -267,6 +267,13 @@ func postCommandMain() {
OmitDuplicateComments: true, OmitDuplicateComments: true,
Labels: map[string]int{ Labels: map[string]int{
"Verified": verified, "Verified": verified,
// TODO(tazjin): The Code-Review label is only used here
// temporarily, as our build rules do not check for 'Verified'
// right now (because CI doesn't run 24/7).
//
// Having a Code-Review label lets us signal the build status on
// the review, but without having to always require it.
"Code-Review": verified,
}, },
} }