refactor(3p/nix): Apply clang-tidy's modernize-* fixes

This applies the modernization fixes listed here:

https://clang.llvm.org/extra/clang-tidy/checks/list.html

The 'modernize-use-trailing-return-type' fix was excluded due to my
personal preference (more specifically, I think the 'auto' keyword is
misleading in that position).
This commit is contained in:
Vincent Ambo 2020-05-20 04:33:07 +01:00
parent fed31b2c9b
commit d331d3a0b5
59 changed files with 349 additions and 321 deletions

View file

@ -1,9 +1,10 @@
#include <cerrno>
#include <cstdio>
#include <cstdlib>
#include <cstring>
#include <regex>
#include <utility>
#include <errno.h>
#include <stdio.h>
#include <sys/stat.h>
#include <sys/types.h>
#include <unistd.h>
@ -27,7 +28,7 @@ static void makeWritable(const Path& path) {
struct MakeReadOnly {
Path path;
explicit MakeReadOnly(const Path& path) : path(path) {}
explicit MakeReadOnly(Path path) : path(std::move(path)) {}
~MakeReadOnly() {
try {
/* This will make the path read-only. */