mdebray/tvl-depot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(wpcarro/emacs): Remove lingering dash.el dep

Browse source 
CI couldn't catch this because the dependency is discovered at runtime, and
there were no tests consuming `list-concat`. Added the tests and removed the
usage of `-concat`.

Change-Id: I5bcce9aa8170001a9d35c104da09374ab30ffbc5
Reviewed-on: https://cl.tvl.fyi/c/depot/+/6043
Reviewed-by: wpcarro <wpcarro@gmail.com>
Autosubmit: wpcarro <wpcarro@gmail.com>
Tested-by: BuildkiteCI
This commit is contained in:
William Carroll 2022-08-05 13:33:28 -07:00 committed by clbot
parent 8670746109
commit cc802eb44b
2 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
users/wpcarro/emacs/pkgs/list/list.el
View file

@ -44,7 +44,7 @@
(defun list-concat (&rest lists)
"Joins `LISTS' into on list."
(apply #'-concat lists))
(apply #'append lists))
(defun list-duplicate (n x)
"Duplicates the given element, X, N times in a list."

4
users/wpcarro/emacs/pkgs/list/tests.el
View file

@ -97,6 +97,10 @@
(should (equal '(a b c) (list-delete 'b '(a b b c))))
(should (equal '() (list-delete 'b '()))))
(ert-deftest list-concat ()
(should (equal '(1 2 3 4 5) (list-concat '(1) '(2 3) '(4 5))))
(should (equal '(1 2 3) (list-concat '() '(1 2 3)))))
;; TODO(wpcarro): Supoprt this.
;; (ert-deftest list-zip ()
;; (should (equal '((1 3 5) (2 4 6)) (list-zip '(1 2) '(3 4) '(5 6))))