mdebray/tvl-depot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(nix-compat/store_path): use Box<str>

Browse source 
We don't actually build up names in place here, so we don't need a
capacity field. Saves 8 bytes.

Change-Id: Icb01b45561e28fd525b726612f56d4640bc834c7
Reviewed-on: https://cl.tvl.fyi/c/depot/+/11604
Reviewed-by: flokli <flokli@flokli.de>
Tested-by: BuildkiteCI
This commit is contained in:
edef 2024-05-08 06:10:03 +00:00
parent 51e0f78e93
commit ca10a8726f
1 changed files with 5 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
tvix/nix-compat/src/store_path/mod.rs
View file

@ -56,7 +56,7 @@ pub enum Error {
#[derive(Clone, Debug, PartialEq, Eq, Hash)]
pub struct StorePath {
digest: [u8; DIGEST_SIZE],
name: String,
name: Box<str>,
}
impl StorePath {
@ -65,7 +65,7 @@ impl StorePath {
}
pub fn name(&self) -> &str {
self.name.as_ref()
&self.name
}
pub fn as_ref(&self) -> StorePathRef<'_> {
@ -176,10 +176,7 @@ pub struct StorePathRef<'a> {
impl<'a> From<&'a StorePath> for StorePathRef<'a> {
fn from(&StorePath { digest, ref name }: &'a StorePath) -> Self {
StorePathRef {
digest,
name: name.as_ref(),
}
StorePathRef { digest, name }
}
}
@ -209,7 +206,7 @@ impl<'a> StorePathRef<'a> {
pub fn to_owned(&self) -> StorePath {
StorePath {
digest: self.digest,
name: self.name.to_owned(),
name: self.name.into(),
}
}
@ -394,7 +391,7 @@ mod tests {
let expected_digest: [u8; DIGEST_SIZE] = hex!("8a12321522fd91efbd60ebb2481af88580f61600");
assert_eq!("net-tools-1.60_p20170221182432", nixpath.name);
assert_eq!("net-tools-1.60_p20170221182432", nixpath.name());
assert_eq!(nixpath.digest, expected_digest);
assert_eq!(example_nix_path_str, nixpath.to_string())