mdebray/tvl-depot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

docs(tvix/eval): clarify difference between ThunkSet and Blackhole

Browse source 
The comment explaining ThunkSet makes it seem like it does the same
think as ThunkRepr::Blackhole.  In fact neither one is a substitute
for the other.  Let's explain the difference.

Change-Id: I89ceaaa9d3c499edbc7d48f70ca5d11f97666c43
Reviewed-on: https://cl.tvl.fyi/c/depot/+/10250
Tested-by: BuildkiteCI
Reviewed-by: tazjin <tazjin@tvl.su>
Autosubmit: Adam Joseph <adam@westernsemico.com>
This commit is contained in:
Adam Joseph 2023-12-11 00:43:21 -08:00 committed by clbot
parent ddba4d4e17
commit c956138ee6
1 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
tvix/eval/src/value/thunk.rs
View file

@ -413,8 +413,11 @@ impl TotalDisplay for Thunk {
} }
} }
/// A wrapper type for tracking which thunks have already been seen in a /// A wrapper type for tracking which thunks have already been seen
/// context. This is necessary for cycle detection. /// in a context. This is necessary for printing and deeply forcing
/// cyclic non-diverging data structures like `rec { f = [ f ]; }`.
/// This is separate from the ThunkRepr::Blackhole mechanism, which
/// detects diverging data structures like `(rec { f = f; }).f`.
/// ///
/// The inner `HashSet` is not available on the outside, as it would be /// The inner `HashSet` is not available on the outside, as it would be
/// potentially unsafe to interact with the pointers in the set. /// potentially unsafe to interact with the pointers in the set.