mdebray/tvl-depot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

docs(tvix/contributing): remove reference to b/201

Browse source 
This should be fixed with the switch to a "GitHub App" for
authentication.

Change-Id: I0bd8b4b9c9f53a754a12ce07f193d19f61f56014
Reviewed-on: https://cl.tvl.fyi/c/depot/+/12414
Reviewed-by: Ilan Joselevich <personal@ilanjoselevich.com>
Tested-by: BuildkiteCI
Autosubmit: flokli <flokli@flokli.de>
This commit is contained in:
Florian Klink 2024-09-01 16:20:38 +03:00 committed by clbot
parent 7f1ecff989
commit c60f4ccfda
1 changed files with 3 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
tvix/docs/src/contributing/gerrit.md
View file

@ -10,11 +10,9 @@ StackOverflow account.
Additionally if you would prefer not to use an SSO option or wish to have a Additionally if you would prefer not to use an SSO option or wish to have a
backup authentication strategy in the event of downed server or otherwise, we backup authentication strategy in the event of downed server or otherwise, we
recommend setting up a TVL-specific LDAP account. Do note that our IdP recommend setting up a TVL-specific LDAP account.
(Keycloak) sometimes has [problems doing SSO with GitHub][github-problematic],
so you might get an “unexpected error” while trying to sign in with GitHub; You can create such an account by following these instructions:
that error is not your fault. You can create that account by following these
instructions:
1. Checkout [TVL’s monorepo][check-out-monorepo] if you haven’t already 1. Checkout [TVL’s monorepo][check-out-monorepo] if you haven’t already
2. Be a member of `#tvix-dev` (and/or `#tvl`) on [hackint][], a communication 2. Be a member of `#tvix-dev` (and/or `#tvl`) on [hackint][], a communication
@ -107,7 +105,6 @@ system, as well as the other [attention set rules][attention-set-rules].
[ops-users]: https://code.tvl.fyi/tree/ops/users/default.nix [ops-users]: https://code.tvl.fyi/tree/ops/users/default.nix
[hackint]: https://hackint.org [hackint]: https://hackint.org
[github-diff]: https://gerrit.wikimedia.org/r/Documentation/intro-gerrit-walkthrough-github.html [github-diff]: https://gerrit.wikimedia.org/r/Documentation/intro-gerrit-walkthrough-github.html
[github-problematic]: https://b.tvl.fyi/issues/201
[attention sets]: https://gerrit-review.googlesource.com/Documentation/user-attention-set.html [attention sets]: https://gerrit-review.googlesource.com/Documentation/user-attention-set.html
[attention-set-rules]: https://gerrit-review.googlesource.com/Documentation/user-attention-set.html#_rules [attention-set-rules]: https://gerrit-review.googlesource.com/Documentation/user-attention-set.html#_rules
[^keycloak]: [^amend]: `git commit --amend` [^keycloak]: [^amend]: `git commit --amend`