mdebray/tvl-depot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove redundant with-current-buffer in manage-window (#13)

Browse source 
All this logic runs in the context of the EXWM buffer. If there are
concerns about the X windows associating with a different buffer while
we're still trying to manage it, we probably have bigger problems.

* exwm-manage.el (exwm-manage--manage-window): assume that the current
buffer doesn't change.
This commit is contained in:
Steven Allen 2024-02-04 12:49:33 -08:00 committed by GitHub
parent 2bb9a5787e
commit c2856d15e8
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 10 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
exwm-manage.el
View file

@ -393,23 +393,19 @@ Override current hinds if FORCE is non-nil."
(if (plist-get exwm--configurations 'char-mode) (if (plist-get exwm--configurations 'char-mode)
(exwm-input-release-keyboard id) (exwm-input-release-keyboard id)
(exwm-input-grab-keyboard id)) (exwm-input-grab-keyboard id))
(let ((simulation-keys (plist-get exwm--configurations 'simulation-keys)) (when-let ((simulation-keys (plist-get exwm--configurations 'simulation-keys)))
(prefix-keys (plist-get exwm--configurations 'prefix-keys)))
(with-current-buffer (exwm--id->buffer id)
(when simulation-keys
(exwm-input-set-local-simulation-keys simulation-keys)) (exwm-input-set-local-simulation-keys simulation-keys))
(when prefix-keys (when-let ((prefix-keys (plist-get exwm--configurations 'prefix-keys)))
(setq-local exwm-input-prefix-keys prefix-keys)))) (setq-local exwm-input-prefix-keys prefix-keys))
(setq exwm-workspace--switch-history-outdated t) (setq exwm-workspace--switch-history-outdated t)
(exwm--update-desktop id) (exwm--update-desktop id)
(exwm-manage--update-ewmh-state id) (exwm-manage--update-ewmh-state id)
(with-current-buffer (exwm--id->buffer id)
(when (or (plist-get exwm--configurations 'fullscreen) (when (or (plist-get exwm--configurations 'fullscreen)
(exwm-layout--fullscreen-p)) (exwm-layout--fullscreen-p))
(setq exwm--ewmh-state (delq xcb:Atom:_NET_WM_STATE_FULLSCREEN (setq exwm--ewmh-state (delq xcb:Atom:_NET_WM_STATE_FULLSCREEN
exwm--ewmh-state)) exwm--ewmh-state))
(exwm-layout-set-fullscreen id)) (exwm-layout-set-fullscreen id))
(run-hooks 'exwm-manage-finish-hook))))) (run-hooks 'exwm-manage-finish-hook))))
(defun exwm-manage--unmanage-window (id &optional withdraw-only) (defun exwm-manage--unmanage-window (id &optional withdraw-only)
"Unmanage window ID. "Unmanage window ID.