mdebray/tvl-depot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

feat(tvix): Write build logs to LOG(INFO) in buildDerivation

Browse source 
This was referencing a nonexistent note in buildPaths, for one, but for
another let's get log outputs when calling this RPC.

Change-Id: Ic9d17834b356ea84d69692ccc0249d09777e833b
Reviewed-on: https://cl.tvl.fyi/c/depot/+/2173
Tested-by: BuildkiteCI
Reviewed-by: kanepyork <rikingcoding@gmail.com>
This commit is contained in:
Griffin Smith 2020-11-27 14:51:18 -05:00 committed by glittershark
parent 39f96c4d9f
commit bbfc47e96d
1 changed files with 1 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
third_party/nix/src/libstore/rpc-store.cc vendored
View file

@ -384,9 +384,6 @@ BuildResult RpcStore::buildDerivation(const Path& drvPath,
*request.mutable_derivation() = proto_drv;
request.set_build_mode(BuildModeToProto(buildMode));
// Same note as in ::buildPaths ...
std::ostream discard_logs = DiscardLogsSink();
std::unique_ptr<grpc::ClientReader<proto::BuildEvent>> reader =
stub_->BuildDerivation(&ctx, request);
@ -395,7 +392,7 @@ BuildResult RpcStore::buildDerivation(const Path& drvPath,
proto::BuildEvent event;
while (reader->Read(&event)) {
if (event.has_build_log()) {
discard_logs << event.build_log().line();
LOG(INFO) << event.build_log().line();
} else if (event.has_result()) {
result = BuildResult::FromProto(event.result());
}