mdebray/tvl-depot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

test(tvix/eval): check thunking behavior of basic exprs

Browse source 
nix_oracle.rs now gives us the possibility to check this by stuffing the
expressions in a list. In fact, the incorrect behavior fixed in

- cl/8656
- cl/8655
- cl/8662

was discovered using this test suite.

Change-Id: Id0ab01ee6be0b875791214e0a72a2ac941c46c96
Reviewed-on: https://cl.tvl.fyi/c/depot/+/8658
Autosubmit: sterni <sternenseemann@systemli.org>
Tested-by: BuildkiteCI
Reviewed-by: tazjin <tazjin@tvl.su>
This commit is contained in:
sterni 2023-05-27 21:37:35 +02:00 committed by clbot
parent 0ab6494286
commit b492067c19
1 changed files with 55 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

55
tvix/eval/tests/nix_oracle.rs
View file

@ -86,6 +86,12 @@ macro_rules! compare_strict_eval_tests {
}
}
macro_rules! compare_lazy_eval_tests {
($($tests:tt)*) => {
compare_eval_tests!(Strictness::Lazy, { $($tests)* });
}
}
compare_strict_eval_tests! {
literal_int("1");
add_ints("1 + 1");
@ -100,3 +106,52 @@ compare_strict_eval_tests! {
(./. + ./.)
]"#);
}
// TODO(sterni): tvix_tests should gain support for something similar in the future,
// but this requires messing with the path naming which would break compat with
// C++ Nix's test suite
compare_lazy_eval_tests! {
// Wrap every expression type supported by [Compiler::compile] in a list
// with lazy evaluation enabled, so we can check it being thunked or not
// against C++ Nix.
unthunked_literals_in_list("[ https://tvl.fyi 1 1.2 ]");
unthunked_path_in_list("[ ./nix_oracle.rs ]");
unthunked_string_literal_in_list("[ \":thonking:\" ]");
thunked_unary_ops_in_list("[ (!true) (-1) ]");
thunked_bin_ops_in_list(r#"
let
# Necessary to fool the optimiser for && and ||
true' = true;
false' = false;
in
[
(true' && false')
(true' || false')
(false -> true)
(40 + 2)
(43 - 1)
(21 * 2)
(126 / 3)
({ } // { bar = null; })
(12 == 13)
(3 < 2)
(4 > 2)
(23 >= 42)
(33 <= 22)
([ ] ++ [ ])
(42 != null)
]
"#);
thunked_has_attrs_in_list("[ ({ } ? foo) ]");
thunked_list_in_list("[ [ 1 2 3 ] ]");
thunked_attr_set_in_list("[ { foo = null; } ]");
thunked_select_in_list("[ ({ foo = null; }.bar) ]");
thunked_assert_in_list("[ (assert false; 12) ]");
thunked_if_in_list("[ (if false then 13 else 12) ]");
thunked_let_in_list("[ (let foo = 12; in foo) ]");
thunked_with_in_list("[ (with { foo = 13; }; fooo) ]");
unthunked_identifier_in_list("let foo = 12; in [ foo ]");
thunked_lambda_in_list("[ (x: x) ]");
thunked_function_application_in_list("[ (builtins.add 1 2) ]");
thunked_legacy_let_in_list("[ (let { foo = 12; body = foo; }) ]");
}