fix(panettone): Fix username display on issue events

7aebba7, which added anchor links to comments, also incorrectly added
only the *key* for the `:id` attribute to the `li` element for
issue *events*, swallowing up the next form (which happened to be the
username) as the value. this adds a *proper* value for the `:id`
attribute, bringing back the actual display of the username.

Fixes: b/97
Change-Id: I33ee628ddfd4a291e069980512fcc5f74014aac4
Reviewed-on: https://cl.tvl.fyi/c/depot/+/3141
Tested-by: BuildkiteCI
Reviewed-by: sterni <sternenseemann@systemli.org>
This commit is contained in:
Griffin Smith 2021-05-23 14:22:44 +02:00 committed by grfn
parent ba6bee80fb
commit a7d07e1a8a

View file

@ -317,11 +317,12 @@
(who:esc (format-dottime (created-at comment))))))))))
(defmethod render/issue-history-item ((event model:issue-event))
(let ((user (find-user-by-dn (acting-user-dn event))))
(let ((user (find-user-by-dn (acting-user-dn event)))
(fragment (format nil "event-~A" (id event))))
(who:with-html-output (*standard-output*)
(:li
:class "event"
:id
:id fragment
(who:esc (displayname-if-known user))
(if (string= (field event) "STATUS")
(who:htm