mdebray/tvl-depot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(tvix/nix-compat-derive): Get rid of external feature flag

Browse source 
The external feature flag was there because I couldn't find a way to
refer to crate and nix-compat with the same name so that the generated
code could be the same.

In essence `use nix_compat::nix_daemon:🇩🇪:NixDeserialize` is an error
when used inside nix_compat crate.

So my best fix was the external feature flag until I found the solution
used here which also removes the flag completely.

Change-Id: Ia3e89c6c350c3fb22ca87f974a39c21542aae152
Reviewed-on: https://cl.tvl.fyi/c/depot/+/12376
Tested-by: BuildkiteCI
Reviewed-by: flokli <flokli@flokli.de>
Autosubmit: Brian Olsen <me@griff.name>
This commit is contained in:
Brian Olsen 2024-08-28 15:45:50 +02:00 • committed by clbot
parent 743407e7ab
commit a5fcfd80a1
5 changed files with 3 additions and 56 deletions
Download patch file Download diff file Expand all files Collapse all files

6
tvix/Cargo.nix
View file

@ -7419,7 +7419,6 @@ rec {
name = "nix-compat-derive";
packageId = "nix-compat-derive";
optional = true;
usesDefaultFeatures = false;
}
{
name = "nom";
@ -7575,10 +7574,7 @@ rec {
packageId = "tokio-test";
}
];
features = {
"default" = [ "external" ];
};
resolvedDefaultFeatures = [ "default" "external" ];
};
"nix-compat-derive-tests" = rec {
crateName = "nix-compat-derive-tests";