mdebray/tvl-depot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

chore: clean up some obsolete TODOs

Browse source 
* //3p/nix: probably not worth investing time into this anymore

* //users/sterni/emacs: The emoji problem disappeared by itself with a
  newer emacs version, however a different one remains…

* //web/panettone: If we ever want to change the behavior, we should
  just decide the behavior statically instead of using conditions and
  restarts, as we only call it in one place, so making different
  decisions depending on call sites is not really a use case we have.

Change-Id: Iff9d439ce356db41ce34d690fb7b6a01822022fa
Reviewed-on: https://cl.tvl.fyi/c/depot/+/5223
Tested-by: BuildkiteCI
Reviewed-by: tazjin <tazjin@tvl.su>
Autosubmit: sterni <sternenseemann@systemli.org>
This commit is contained in:
sterni 2022-02-04 12:15:57 +01:00 committed by clbot
parent 0e45761853
commit a2ecd53f58
3 changed files with 1 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
third_party/nix/src/libexpr/primops.cc vendored
View file

@ -1370,7 +1370,6 @@ static void prim_functionArgs(EvalState& state, const Pos& pos, Value** args,
Value& v) { Value& v) {
state.forceValue(*args[0]); state.forceValue(*args[0]);
if (args[0]->type == tPrimOpApp || args[0]->type == tPrimOp) { if (args[0]->type == tPrimOpApp || args[0]->type == tPrimOp) {
// TODO(sterni): return set of formal arguments for fetch* primops
state.mkAttrs(v, 0); state.mkAttrs(v, 0);
return; return;
} }

2
users/sterni/emacs/init.el
View file

@ -1,5 +1,5 @@
;; Set default font and fallback font via set-fontset-font ;; Set default font and fallback font via set-fontset-font
;; TODO(sterni): Investigate non-emoji representation of some glyphs ;; TODO(sterni): Investigate why ZWJ sequences aren't shaped properly
(let ((mono-font "Bitstream Vera Sans Mono-12") (let ((mono-font "Bitstream Vera Sans Mono-12")
(emoji-font "Noto Color Emoji-12")) (emoji-font "Noto Color Emoji-12"))
(setq default-frame-alist `((font . ,mono-font))) (setq default-frame-alist `((font . ,mono-font)))

3
web/panettone/src/inline-markdown.lisp
View file

@ -124,7 +124,4 @@
; only eliminates the slight use case for nesting :em inside :del, but ; only eliminates the slight use case for nesting :em inside :del, but
; shouldn't be too bad. As a side effect this is the precise behavior ; shouldn't be too bad. As a side effect this is the precise behavior
; we want for :code. ; we want for :code.
;
; TODO(sterni): maybe bring back the restart-based system which allowed
; to skip nested tokens if desired.
(t (write-string (who:escape-string tok-str) target))))) (t (write-string (who:escape-string tok-str) target)))))