mdebray/tvl-depot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

refactor(tvl.el): Don't submit on rubberstamp

Browse source 
Now that we're requiring CI to verify all changes (yay) it's not
actually possible to push and submit in one go - this repurposes the
rubberstamp command to push and self-+2, which is still useful for
self-owned things like system config etc.

Change-Id: Ie064adb6b7b0c1fd6bffdf4583a201ea02d4f8ac
Reviewed-on: https://cl.tvl.fyi/c/depot/+/939
Tested-by: BuildkiteCI
Reviewed-by: tazjin <mail@tazj.in>
This commit is contained in:
Griffin Smith 2020-07-06 11:10:40 -04:00 committed by glittershark
parent 9e622eceae
commit a0f9ae996d
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
tools/emacs-pkgs/tvl/tvl.el
View file

@ -75,12 +75,12 @@ rubberstamp operation is dangerous and should only be used in
(interactive)
(magit-push-refspecs tvl-gerrit-remote
(tvl--gerrit-ref "canon"
'("Code-Review+2" "publish-comments" "submit"))
'("Code-Review+2" "publish-comments"))
nil))
(transient-append-suffix
#'magit-push ["r"]
(list "P" "push, rubberstamp & submit to Gerrit" #'magit-gerrit-rubberstamp))
(list "P" "push & rubberstamp to Gerrit" #'magit-gerrit-rubberstamp))
(defun tvl-depot-status ()
"Open the TVL monorepo in magit."