mdebray/tvl-depot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

docs(ops/pipelines/depot): correct comment about fallback build cmd

Browse source 
We can gcroot the derivation files and drop this step, but have
elected not to do so for the moment, see cl/3436.

Change-Id: I993a1f3921e9f21e18fa260e76d3dd15ffa556bd
Reviewed-on: https://cl.tvl.fyi/c/depot/+/4327
Tested-by: BuildkiteCI
Autosubmit: sterni <sternenseemann@systemli.org>
Reviewed-by: tazjin <mail@tazj.in>
This commit is contained in:
sterni 2021-12-14 17:20:17 +01:00 committed by clbot
parent 15e3afccef
commit 9f22b4f1c8
1 changed files with 3 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
ops/pipelines/depot.nix
View file

@ -36,10 +36,9 @@ let
# at least one of its `outPath`s, so we need to discard the string context # at least one of its `outPath`s, so we need to discard the string context
# if we don't want to build everything during pipeline construction. # if we don't want to build everything during pipeline construction.
"nix-store --realise '${drvPath}'" "nix-store --realise '${drvPath}'"
# However, Nix doesn't track references of store paths to derivations, so # Since we don't gcroot the derivation files, they may be deleted by the
# there's no guarantee that the derivation file is not garbage collected. # garbage collector. In that case we can reevaluate and build the attribute
# To handle this case we fall back to an ordinary build if the derivation # using nix-build.
# file is missing.
"|| (test ! -f '${drvPath}' && nix-build -E '${mkBuildExpr target}' --show-trace)" "|| (test ! -f '${drvPath}' && nix-build -E '${mkBuildExpr target}' --show-trace)"
]; ];
label = ":nix: ${mkLabel target}"; label = ":nix: ${mkLabel target}";