* Don't use substitutes in addToStore().
This commit is contained in:
parent
06434072e7
commit
9df93f30bd
2 changed files with 21 additions and 15 deletions
|
@ -181,7 +181,7 @@ bool isInPrefix(const string & path, const string & _prefix)
|
|||
|
||||
|
||||
string expandId(const FSId & id, const string & target,
|
||||
const string & prefix, FSIdSet pending)
|
||||
const string & prefix, FSIdSet pending, bool ignoreSubstitutes)
|
||||
{
|
||||
Nest nest(lvlDebug, format("expanding %1%") % (string) id);
|
||||
|
||||
|
@ -221,6 +221,8 @@ string expandId(const FSId & id, const string & target,
|
|||
}
|
||||
}
|
||||
|
||||
if (!ignoreSubstitutes) {
|
||||
|
||||
if (pending.find(id) != pending.end())
|
||||
throw Error(format("id %1% already being expanded") % (string) id);
|
||||
pending.insert(id);
|
||||
|
@ -240,6 +242,8 @@ string expandId(const FSId & id, const string & target,
|
|||
return expandId(id, target, prefix, pending);
|
||||
}
|
||||
|
||||
}
|
||||
|
||||
throw Error(format("cannot expand id `%1%'") % (string) id);
|
||||
}
|
||||
|
||||
|
@ -257,7 +261,8 @@ void addToStore(string srcPath, string & dstPath, FSId & id,
|
|||
|
||||
try {
|
||||
/* !!! should not use the substitutes! */
|
||||
dstPath = expandId(id, deterministicName ? dstPath : "", nixStore);
|
||||
dstPath = expandId(id, deterministicName ? dstPath : "",
|
||||
nixStore, FSIdSet(), true);
|
||||
return;
|
||||
} catch (...) {
|
||||
}
|
||||
|
|
|
@ -35,7 +35,8 @@ bool queryPathId(const string & path, FSId & id);
|
|||
substitute (since when we build the substitute, we would first try
|
||||
to expand the id... kaboom!). */
|
||||
string expandId(const FSId & id, const string & target = "",
|
||||
const string & prefix = "/", FSIdSet pending = FSIdSet());
|
||||
const string & prefix = "/", FSIdSet pending = FSIdSet(),
|
||||
bool ignoreSubstitutes = false);
|
||||
|
||||
/* Copy a file to the nixStore directory and register it in dbRefs.
|
||||
Return the hash code of the value. */
|
||||
|
|
Loading…
Reference in a new issue