mdebray/tvl-depot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

feat(ci): Add subtarget support for builds

Browse source 
We have naturally evolved a distinction between logical and physical
targets.

Physical targets are those which correspond directly to a tree
location on disk and can be built with `-A path.to.files`, while
logical targets are those that are exported from within an expression
but do not have a corresponding file on disk.

This change adds support for exporting logical targets from any tree
location by adding a `meta.targets` attribute containing keys into
itself, which will be consumed by the CI target gathering logic and
included in the generated pipeline.

Note that the labels for subtargets are syntactically different to
emphasise that they do not correspond to a file location. For example,
this change enables 'ops.nixos.whitbySystem' as a subtarget, which is
labeled in CI as `ops/nixos:whitbySystem`.

Change-Id: Ied09647a62c2ba98e3914548e3742ad422c63ecf
Reviewed-on: https://cl.tvl.fyi/c/depot/+/1893
Tested-by: BuildkiteCI
Reviewed-by: glittershark <grfn@gws.fyi>
This commit is contained in:
Vincent Ambo 2020-08-31 01:36:03 +01:00 • committed by tazjin
parent 61d2d2d503
commit 9c482d6238
3 changed files with 31 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

19
ops/pipelines/depot.nix
View file

@ -13,12 +13,19 @@ let
# Create an expression that builds the target at the specified
# location.
mkBuildExpr =
let descend = expr: attr: "builtins.getAttr \"${attr}\" (${expr})";
in foldl' descend "import ./. {}";
mkBuildExpr = target:
let
descend = expr: attr: "builtins.getAttr \"${attr}\" (${expr})";
targetExpr = foldl' descend "import ./. {}" target.__readTree;
subtargetExpr = descend targetExpr target.__subtarget;
in if target ? __subtarget then subtargetExpr else targetExpr;
# Create a pipeline label from the targets tree location.
mkLabel = concatStringsSep "/";
mkLabel = target:
let label = concatStringsSep "/" target.__readTree;
in if target ? __subtarget
then "${label}:${target.__subtarget}"
else label;
# Create a pipeline step from a single target.
#
@ -27,9 +34,9 @@ let
# regardless, but this data is not accessible.
mkStep = target: {
command = ''
nix-build -E '${mkBuildExpr target.__readTree}' || (buildkite-agent meta-data set "failure" "1"; exit 1)
nix-build -E '${mkBuildExpr target}' || (buildkite-agent meta-data set "failure" "1"; exit 1)
'';
label = ":nix: ${mkLabel target.__readTree}";
label = ":nix: ${mkLabel target}";
};
# Protobuf check step which validates that changes to .proto files