mdebray/tvl-depot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

feat(tvix/castore): derive Eq and Hash automatically

Browse source 
This allows these messages to be put in HashSets.

Change-Id: Ia58094cafe53eb624578821d3d8d969c5d21a1d7
Reviewed-on: https://cl.tvl.fyi/c/depot/+/11219
Tested-by: BuildkiteCI
Reviewed-by: Connor Brewster <cbrewster@hey.com>
Autosubmit: flokli <flokli@flokli.de>
This commit is contained in:
Florian Klink 2024-03-20 18:00:39 +02:00 committed by clbot
parent 345a639e79
commit 9793745459
2 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
tvix/castore/build.rs
View file

@ -15,6 +15,7 @@ fn main() -> Result<()> {
// https://github.com/hyperium/tonic/issues/908
let mut config = prost_build::Config::new();
config.bytes(["."]);
config.type_attribute(".", "#[derive(Eq, Hash)]");
builder
.build_server(true)

4
tvix/castore/src/proto/mod.rs
View file

@ -1,4 +1,4 @@
#![allow(clippy::derive_partial_eq_without_eq, non_snake_case)]
#![allow(non_snake_case)]
// https://github.com/hyperium/tonic/issues/1056
use bstr::ByteSlice;
use std::{collections::HashSet, iter::Peekable, str};
@ -167,8 +167,6 @@ impl node::Node {
}
}
impl Eq for node::Node {}
impl PartialOrd for node::Node {
fn partial_cmp(&self, other: &Self) -> Option<std::cmp::Ordering> {
Some(self.cmp(other))