fix(tvix/eval): fix branching on catchable defaults (b/343)

Browse source

This commit adds Opcode::OpJumpIfCatchable, which can be inserted
ahead of most VM operations which expect a boolean on the stack, in
order to handle catchables in branching position properly.

Other than remembering to patch the jump, no other changes should be
required.

This commit also fixes b/343 by emitting this new opcode when
compiling if-then-else.  There are probably other places where we
need to do the same thing.

Change-Id: I48de3010014c0bbeba15d34fc0d4800e0bb5a1ef
Reviewed-on: https://cl.tvl.fyi/c/depot/+/10288
Tested-by: BuildkiteCI
Reviewed-by: tazjin <tazjin@tvl.su>
Autosubmit: Adam Joseph <adam@westernsemico.com>

...

This commit is contained in:

Adam Joseph 2023-12-11 21:17:22 -08:00 • committed by clbot

parent e54eeda0ff

commit 9792920f8c

6 changed files with 20 additions and 0 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

0

tvix/eval/src/tests/tvix_tests/notyetpassing/eval-okay-test-catchables-in-default-args.exp → tvix/eval/src/tests/tvix_tests/eval-okay-test-catchables-in-default-args.exp

Unescape Escape View file

0

tvix/eval/src/tests/tvix_tests/notyetpassing/eval-okay-test-catchables-in-default-args.nix → tvix/eval/src/tests/tvix_tests/eval-okay-test-catchables-in-default-args.nix

Unescape Escape View file